Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-08-11 Thread Niklas Nielsen 


> On July 27, 2015, 11:36 p.m., Adam B wrote:
> > Great first patch. Thanks for updating FrameworkInfo on reregistration with 
> > the master too!
> > A handful of nits in my first pass. I'll take another look once you've 
> > simplified the tests with Kapil's suggestions.
> 
> Niklas Nielsen wrote:
> Any updates here? :)
> 
> Adam B wrote:
> Looks like @neilc or somebody resolved some of these issues, but I don't 
> see a new patch revision with the changes. Neil?

Ping


- Niklas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/#review93242
---


On July 27, 2015, 6:25 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36867/
> ---
> 
> (Updated July 27, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2841
> https://issues.apache.org/jira/browse/MESOS-2841
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is intended to support frameworks that want to offer capabilities to the
> rest of the cluster (e.g., storage or some arbitrary third-party service). We
> want processes running in the cluster to be able to discover these 
> capabilities;
> however, we don't want to commit to a fixed set of capabilities or how those
> capabilities should be represented. Hence, this commit represents this
> information using freeform key-value pairs, similar to the labels mechanism
> already in use elsewhere.
> 
> Jira: MESOS-2841
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
>   src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 
>   src/master/master.hpp 2c924addfb4c52d3048ee6ded13ce638145cc93f 
>   src/tests/fault_tolerance_tests.cpp 
> 7b977f5e8195d9f42b21f36eb36fb156471caa20 
>   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
> 
> Diff: https://reviews.apache.org/r/36867/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-08-04 Thread Neil Conway 
Hi folks,
Thanks for the great feedback! I addressed almost all of these issues, but
had a few things left to wrap up before uploading a new patch -- I'm
traveling at the moment, but I should have a new patch by tomorrow.
Neil

On Mon, Aug 3, 2015 at 8:45 PM Adam B  wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36867/
>
> On July 27th, 2015, 11:36 p.m. PDT, *Adam B* wrote:
>
> Great first patch. Thanks for updating FrameworkInfo on reregistration with 
> the master too!
> A handful of nits in my first pass. I'll take another look once you've 
> simplified the tests with Kapil's suggestions.
>
> On August 3rd, 2015, 1:33 p.m. PDT, *Niklas Nielsen* wrote:
>
> Any updates here? :)
>
> Looks like @neilc or somebody resolved some of these issues, but I don't see 
> a new patch revision with the changes. Neil?
>
>
> - Adam
>
> On July 27th, 2015, 6:25 p.m. PDT, Neil Conway wrote:
> Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
> By Neil Conway.
>
> *Updated July 27, 2015, 6:25 p.m.*
> *Bugs: * MESOS-2841 
> *Repository: * mesos
> Description
>
> This is intended to support frameworks that want to offer capabilities to the
> rest of the cluster (e.g., storage or some arbitrary third-party service). We
> want processes running in the cluster to be able to discover these 
> capabilities;
> however, we don't want to commit to a fixed set of capabilities or how those
> capabilities should be represented. Hence, this commit represents this
> information using freeform key-value pairs, similar to the labels mechanism
> already in use elsewhere.
>
> Jira: MESOS-2841
>
> Testing
>
> make check
>
> Diffs
>
>- include/mesos/mesos.proto (a6748d1cd82238f005c6a49c70d22d095462f1ba)
>- src/master/http.cpp (3a1598fad4db03e5f62fd4a6bd26b2bedeee4070)
>- src/master/master.hpp (2c924addfb4c52d3048ee6ded13ce638145cc93f)
>- src/tests/fault_tolerance_tests.cpp
>(7b977f5e8195d9f42b21f36eb36fb156471caa20)
>- src/tests/master_tests.cpp (05c148ee1660b86428afe4eda718b17052743a8c)
>
> View Diff 
>

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-08-03 Thread Adam B 


> On July 27, 2015, 11:36 p.m., Adam B wrote:
> > Great first patch. Thanks for updating FrameworkInfo on reregistration with 
> > the master too!
> > A handful of nits in my first pass. I'll take another look once you've 
> > simplified the tests with Kapil's suggestions.
> 
> Niklas Nielsen wrote:
> Any updates here? :)

Looks like @neilc or somebody resolved some of these issues, but I don't see a 
new patch revision with the changes. Neil?


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/#review93242
---


On July 27, 2015, 6:25 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36867/
> ---
> 
> (Updated July 27, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2841
> https://issues.apache.org/jira/browse/MESOS-2841
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is intended to support frameworks that want to offer capabilities to the
> rest of the cluster (e.g., storage or some arbitrary third-party service). We
> want processes running in the cluster to be able to discover these 
> capabilities;
> however, we don't want to commit to a fixed set of capabilities or how those
> capabilities should be represented. Hence, this commit represents this
> information using freeform key-value pairs, similar to the labels mechanism
> already in use elsewhere.
> 
> Jira: MESOS-2841
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
>   src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 
>   src/master/master.hpp 2c924addfb4c52d3048ee6ded13ce638145cc93f 
>   src/tests/fault_tolerance_tests.cpp 
> 7b977f5e8195d9f42b21f36eb36fb156471caa20 
>   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
> 
> Diff: https://reviews.apache.org/r/36867/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-08-03 Thread Niklas Nielsen 


> On July 27, 2015, 11:36 p.m., Adam B wrote:
> > Great first patch. Thanks for updating FrameworkInfo on reregistration with 
> > the master too!
> > A handful of nits in my first pass. I'll take another look once you've 
> > simplified the tests with Kapil's suggestions.

Any updates here? :)


- Niklas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/#review93242
---


On July 27, 2015, 6:25 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36867/
> ---
> 
> (Updated July 27, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2841
> https://issues.apache.org/jira/browse/MESOS-2841
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is intended to support frameworks that want to offer capabilities to the
> rest of the cluster (e.g., storage or some arbitrary third-party service). We
> want processes running in the cluster to be able to discover these 
> capabilities;
> however, we don't want to commit to a fixed set of capabilities or how those
> capabilities should be represented. Hence, this commit represents this
> information using freeform key-value pairs, similar to the labels mechanism
> already in use elsewhere.
> 
> Jira: MESOS-2841
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
>   src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 
>   src/master/master.hpp 2c924addfb4c52d3048ee6ded13ce638145cc93f 
>   src/tests/fault_tolerance_tests.cpp 
> 7b977f5e8195d9f42b21f36eb36fb156471caa20 
>   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
> 
> Diff: https://reviews.apache.org/r/36867/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-07-28 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/#review93294
---



src/master/http.cpp (line 242)


We should move this statement inside the `if` block. That way, if the 
labels field is completely missing, nothing will show up in state.json. 
However, if labels field is there, but no actual labels in it, it would show up 
as an empty array. You can then move the `array` declaration inside the `if` 
block as well.


- Kapil Arya


On July 27, 2015, 9:25 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36867/
> ---
> 
> (Updated July 27, 2015, 9:25 p.m.)
> 
> 
> Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2841
> https://issues.apache.org/jira/browse/MESOS-2841
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is intended to support frameworks that want to offer capabilities to the
> rest of the cluster (e.g., storage or some arbitrary third-party service). We
> want processes running in the cluster to be able to discover these 
> capabilities;
> however, we don't want to commit to a fixed set of capabilities or how those
> capabilities should be represented. Hence, this commit represents this
> information using freeform key-value pairs, similar to the labels mechanism
> already in use elsewhere.
> 
> Jira: MESOS-2841
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
>   src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 
>   src/master/master.hpp 2c924addfb4c52d3048ee6ded13ce638145cc93f 
>   src/tests/fault_tolerance_tests.cpp 
> 7b977f5e8195d9f42b21f36eb36fb156471caa20 
>   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
> 
> Diff: https://reviews.apache.org/r/36867/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-07-27 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/#review93242
---


Great first patch. Thanks for updating FrameworkInfo on reregistration with the 
master too!
A handful of nits in my first pass. I'll take another look once you've 
simplified the tests with Kapil's suggestions.


src/master/http.cpp (line 234)


You shouldn't need the `mesos::` since you're nested inside 
`mesos::internal::master`.

Nit: We don't usually use `const` for temporaries like this. Mostly for 
parameters, string constants, and other `const&`'s, like iterators.



src/master/master.hpp (line 1361)


Nit: We actually limit comments to a 70 char limit.
See http://mesos.apache.org/documentation/latest/mesos-c++-style-guide/



src/tests/master_tests.cpp (line 3551)


Nit: Double blank lines between top-level functions/classes, please.



src/tests/master_tests.cpp (line 3559)


Unused. Remove.



src/tests/master_tests.cpp (line 3595)


Nit: Only indent 2 spaces after wrapping on `=`.


- Adam B


On July 27, 2015, 6:25 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36867/
> ---
> 
> (Updated July 27, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2841
> https://issues.apache.org/jira/browse/MESOS-2841
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is intended to support frameworks that want to offer capabilities to the
> rest of the cluster (e.g., storage or some arbitrary third-party service). We
> want processes running in the cluster to be able to discover these 
> capabilities;
> however, we don't want to commit to a fixed set of capabilities or how those
> capabilities should be represented. Hence, this commit represents this
> information using freeform key-value pairs, similar to the labels mechanism
> already in use elsewhere.
> 
> Jira: MESOS-2841
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
>   src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 
>   src/master/master.hpp 2c924addfb4c52d3048ee6ded13ce638145cc93f 
>   src/tests/fault_tolerance_tests.cpp 
> 7b977f5e8195d9f42b21f36eb36fb156471caa20 
>   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
> 
> Diff: https://reviews.apache.org/r/36867/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-07-27 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/#review93225
---


Ni


src/tests/fault_tolerance_tests.cpp (lines 1841 - 1844)


You should be able to replace these lines with:
` framework1.mutable_labels()->add_labels()->CopyFrom(createLabel("foo", 
"bar"));`



src/tests/fault_tolerance_tests.cpp (lines 1876 - 1879)


Same as above.



src/tests/fault_tolerance_tests.cpp (lines 1951 - 1958)


This block can be replaced with:
```
 EXPECT_EQ(
 JSON::Value(JSON::Protobuf(createLabel("foo", "bar"))),
 labelsObject.values[0]); 
```



src/tests/master_tests.cpp (lines 3567 - 3577)


ditto.



src/tests/master_tests.cpp (lines 3607 - 3640)


Same as above.


Neil, could you update the code to reflect some of the recent changes regarding 
labels? You can find the example in MasterTest.TaskLabels test in 
master_tests.cpp.

- Kapil Arya


On July 27, 2015, 9:25 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36867/
> ---
> 
> (Updated July 27, 2015, 9:25 p.m.)
> 
> 
> Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2841
> https://issues.apache.org/jira/browse/MESOS-2841
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is intended to support frameworks that want to offer capabilities to the
> rest of the cluster (e.g., storage or some arbitrary third-party service). We
> want processes running in the cluster to be able to discover these 
> capabilities;
> however, we don't want to commit to a fixed set of capabilities or how those
> capabilities should be represented. Hence, this commit represents this
> information using freeform key-value pairs, similar to the labels mechanism
> already in use elsewhere.
> 
> Jira: MESOS-2841
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
>   src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 
>   src/master/master.hpp 2c924addfb4c52d3048ee6ded13ce638145cc93f 
>   src/tests/fault_tolerance_tests.cpp 
> 7b977f5e8195d9f42b21f36eb36fb156471caa20 
>   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
> 
> Diff: https://reviews.apache.org/r/36867/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-07-27 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/#review93224
---


Patch looks great!

Reviews applied: [36867]

All tests passed.

- Mesos ReviewBot


On July 28, 2015, 1:25 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36867/
> ---
> 
> (Updated July 28, 2015, 1:25 a.m.)
> 
> 
> Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2841
> https://issues.apache.org/jira/browse/MESOS-2841
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is intended to support frameworks that want to offer capabilities to the
> rest of the cluster (e.g., storage or some arbitrary third-party service). We
> want processes running in the cluster to be able to discover these 
> capabilities;
> however, we don't want to commit to a fixed set of capabilities or how those
> capabilities should be represented. Hence, this commit represents this
> information using freeform key-value pairs, similar to the labels mechanism
> already in use elsewhere.
> 
> Jira: MESOS-2841
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
>   src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 
>   src/master/master.hpp 2c924addfb4c52d3048ee6ded13ce638145cc93f 
>   src/tests/fault_tolerance_tests.cpp 
> 7b977f5e8195d9f42b21f36eb36fb156471caa20 
>   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
> 
> Diff: https://reviews.apache.org/r/36867/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-07-27 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/
---

(Updated July 28, 2015, 1:25 a.m.)


Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.


Bugs: MESOS-2841
https://issues.apache.org/jira/browse/MESOS-2841


Repository: mesos


Description (updated)
---

This is intended to support frameworks that want to offer capabilities to the
rest of the cluster (e.g., storage or some arbitrary third-party service). We
want processes running in the cluster to be able to discover these capabilities;
however, we don't want to commit to a fixed set of capabilities or how those
capabilities should be represented. Hence, this commit represents this
information using freeform key-value pairs, similar to the labels mechanism
already in use elsewhere.

Jira: MESOS-2841


Diffs
-

  include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
  src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 
  src/master/master.hpp 2c924addfb4c52d3048ee6ded13ce638145cc93f 
  src/tests/fault_tolerance_tests.cpp 7b977f5e8195d9f42b21f36eb36fb156471caa20 
  src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 

Diff: https://reviews.apache.org/r/36867/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-07-27 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/
---

(Updated July 28, 2015, 1:25 a.m.)


Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.


Changes
---

Fixed merge conflict, updated with test case for scheduler failover.


Bugs: MESOS-2841
https://issues.apache.org/jira/browse/MESOS-2841


Repository: mesos


Description
---

This is intended to support frameworks that want to offer capabilities to the
rest of the cluster (e.g., storage or some arbitrary third-party service). We
want processes running in the cluster to be able to discover these capabilities;
however, we don't want to commit to a fixed set of capabilities or how those
capabilities should be represented. Hence, this commit represents this
information using freeform key-value pairs, similar to the labels mechanism
already in use elsewhere.

Note that this doesn't include a test for the scheduler failover case: I noticed
that a basically equivalent test case is in-progress for MESOS-2880
(https://reviews.apache.org/r/35797/), so I figured that once 2880 is merged, it
will be easy to update that test to check that labels are propagated correctly.

Jira: MESOS-2841


Diffs (updated)
-

  include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
  src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 
  src/master/master.hpp 2c924addfb4c52d3048ee6ded13ce638145cc93f 
  src/tests/fault_tolerance_tests.cpp 7b977f5e8195d9f42b21f36eb36fb156471caa20 
  src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 

Diff: https://reviews.apache.org/r/36867/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-07-27 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/#review93207
---


Bad patch!

Reviews applied: [36867]

Failed command: ./support/apply-review.sh -n -r 36867

Error:
 2015-07-28 00:55:40 URL:https://reviews.apache.org/r/36867/diff/raw/ 
[5396/5396] -> "36867.patch" [1]
error: patch failed: src/master/master.hpp:1411
error: src/master/master.hpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On July 28, 2015, 12:04 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36867/
> ---
> 
> (Updated July 28, 2015, 12:04 a.m.)
> 
> 
> Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2841
> https://issues.apache.org/jira/browse/MESOS-2841
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is intended to support frameworks that want to offer capabilities to the
> rest of the cluster (e.g., storage or some arbitrary third-party service). We
> want processes running in the cluster to be able to discover these 
> capabilities;
> however, we don't want to commit to a fixed set of capabilities or how those
> capabilities should be represented. Hence, this commit represents this
> information using freeform key-value pairs, similar to the labels mechanism
> already in use elsewhere.
> 
> Note that this doesn't include a test for the scheduler failover case: I 
> noticed
> that a basically equivalent test case is in-progress for MESOS-2880
> (https://reviews.apache.org/r/35797/), so I figured that once 2880 is merged, 
> it
> will be easy to update that test to check that labels are propagated 
> correctly.
> 
> Jira: MESOS-2841
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
>   src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 
>   src/master/master.hpp 9f27f8baa10221f7e951eb6074dbbfc87ec77f13 
>   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
> 
> Diff: https://reviews.apache.org/r/36867/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>