Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/#review93472 --- Patch looks great! Reviews applied: [36909] All tests passed. - Mesos ReviewBot On July 29, 2015, 1:56 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/ --- (Updated July 29, 2015, 1:56 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-3168 https://issues.apache.org/jira/browse/MESOS-3168 Repository: mesos Description --- Call parent SetUp() and TearDown() in MesosZooKeeperTest. Diffs - src/tests/mesos.hpp 192067d90aec2a114091e413e92e1ced10225afc Diff: https://reviews.apache.org/r/36909/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.
On July 29, 2015, 5:43 p.m., Vinod Kone wrote: Aah. Good catch. Thank you! You are welcome. :-) - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/#review93482 --- On July 29, 2015, 1:56 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/ --- (Updated July 29, 2015, 1:56 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-3168 https://issues.apache.org/jira/browse/MESOS-3168 Repository: mesos Description --- Call parent SetUp() and TearDown() in MesosZooKeeperTest. Diffs - src/tests/mesos.hpp 192067d90aec2a114091e413e92e1ced10225afc Diff: https://reviews.apache.org/r/36909/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/#review93509 --- src/tests/mesos.hpp (line 317) https://reviews.apache.org/r/36909/#comment147904 Shouldn't it come after network shutdown? https://reviews.apache.org/r/36920/ - Alexander Rukletsov On July 29, 2015, 1:56 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/ --- (Updated July 29, 2015, 1:56 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-3168 https://issues.apache.org/jira/browse/MESOS-3168 Repository: mesos Description --- Call parent SetUp() and TearDown() in MesosZooKeeperTest. Diffs - src/tests/mesos.hpp 192067d90aec2a114091e413e92e1ced10225afc Diff: https://reviews.apache.org/r/36909/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/#review93482 --- Ship it! Aah. Good catch. Thank you! - Vinod Kone On July 29, 2015, 1:56 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/ --- (Updated July 29, 2015, 1:56 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-3168 https://issues.apache.org/jira/browse/MESOS-3168 Repository: mesos Description --- Call parent SetUp() and TearDown() in MesosZooKeeperTest. Diffs - src/tests/mesos.hpp 192067d90aec2a114091e413e92e1ced10225afc Diff: https://reviews.apache.org/r/36909/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.
On July 29, 2015, 8:40 p.m., Alexander Rukletsov wrote: src/tests/mesos.hpp, line 317 https://reviews.apache.org/r/36909/diff/3/?file=1024461#file1024461line317 Shouldn't it come after network shutdown? https://reviews.apache.org/r/36920/ sorry, my fault - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/#review93509 --- On July 29, 2015, 1:56 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/ --- (Updated July 29, 2015, 1:56 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-3168 https://issues.apache.org/jira/browse/MESOS-3168 Repository: mesos Description --- Call parent SetUp() and TearDown() in MesosZooKeeperTest. Diffs - src/tests/mesos.hpp 192067d90aec2a114091e413e92e1ced10225afc Diff: https://reviews.apache.org/r/36909/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/ --- (Updated July 29, 2015, 1:56 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-3168 https://issues.apache.org/jira/browse/MESOS-3168 Repository: mesos Description --- Call parent SetUp() and TearDown() in MesosZooKeeperTest. Diffs - src/tests/mesos.hpp 192067d90aec2a114091e413e92e1ced10225afc Diff: https://reviews.apache.org/r/36909/diff/ Testing (updated) --- make check Thanks, haosdent huang
Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/ --- (Updated July 29, 2015, 1:53 p.m.) Review request for mesos. Summary (updated) - Call parent SetUp() and TearDown() in MesosZooKeeperTest. Repository: mesos Description (updated) --- Call parent SetUp() and TearDown() in MesosZooKeeperTest. Diffs (updated) - src/tests/mesos.hpp 192067d90aec2a114091e413e92e1ced10225afc Diff: https://reviews.apache.org/r/36909/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36909: Call parent SetUp() and TearDown() in MesosZooKeeperTest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36909/ --- (Updated July 29, 2015, 1:53 p.m.) Review request for mesos. Bugs: MESOS-3168 https://issues.apache.org/jira/browse/MESOS-3168 Repository: mesos Description --- Call parent SetUp() and TearDown() in MesosZooKeeperTest. Diffs - src/tests/mesos.hpp 192067d90aec2a114091e413e92e1ced10225afc Diff: https://reviews.apache.org/r/36909/diff/ Testing --- Thanks, haosdent huang
