Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.

2015-08-12 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37237/#review95194
---

Ship it!


Ship It!

- Timothy Chen


On Aug. 8, 2015, 12:32 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37237/
> ---
> 
> (Updated Aug. 8, 2015, 12:32 a.m.)
> 
> 
> Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, 
> Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2794
> https://issues.apache.org/jira/browse/MESOS-2794
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a few MesosContainerizer filesystem tests to test the linux filesystem 
> isolator.
> 
> This adds the tests for https://reviews.apache.org/r/37236/
> 
> 
> Diffs
> -
> 
>   src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 
>   src/tests/containerizer/filesystem_isolator_tests.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37237/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.

2015-08-12 Thread Jie Yu 


> On Aug. 12, 2015, 6:16 p.m., Jiang Yan Xu wrote:
> > src/tests/containerizer/filesystem_isolator_tests.cpp, line 157
> > 
> >
> > So this relies on the launch not failing to indicate it has 
> > successfully pivoted?
> > 
> > Ideally there is something to prove it's indeed in the new rootfs.

I used [ ! -d 'os::getcwd()' ] instead.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37237/#review95025
---


On Aug. 8, 2015, 12:32 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37237/
> ---
> 
> (Updated Aug. 8, 2015, 12:32 a.m.)
> 
> 
> Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, 
> Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2794
> https://issues.apache.org/jira/browse/MESOS-2794
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a few MesosContainerizer filesystem tests to test the linux filesystem 
> isolator.
> 
> This adds the tests for https://reviews.apache.org/r/37236/
> 
> 
> Diffs
> -
> 
>   src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 
>   src/tests/containerizer/filesystem_isolator_tests.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37237/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.

2015-08-12 Thread Jie Yu 


> On Aug. 12, 2015, 6:16 p.m., Jiang Yan Xu wrote:
> > src/tests/containerizer/provisioner.hpp, line 34
> > 
> >
> > Should this be called MockProvisioner? I think we use TestXYZ to 'XYZ 
> > that faciliates tests' and MockXYZ for 'Fake XYZ implemented by GMock'. 
> > e.g., MockSlave.

We use MockXX if it's a pure mock. In this case, the test provisioner has real 
behavior (takes a rootfs and return that by default).


> On Aug. 12, 2015, 6:16 p.m., Jiang Yan Xu wrote:
> > src/tests/containerizer/provisioner.hpp, lines 46-47
> > 
> >
> > Does this not cause the issue mpark 
> > [mentioned](http://mail-archives.apache.org/mod_mbox/mesos-dev/201507.mbox/%3ccal3vcqqrcwbblf3u2fdhu1myohqgqjub9ul3zjn+oqxx0on...@mail.gmail.com%3E)?
> > 
> > May have to put them in tests themselves.

No, it won't. This is from gmock (not gtest).

We follow this pattern in many of our test harnesses (e.g., TestLauncher).


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37237/#review95025
---


On Aug. 8, 2015, 12:32 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37237/
> ---
> 
> (Updated Aug. 8, 2015, 12:32 a.m.)
> 
> 
> Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, 
> Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2794
> https://issues.apache.org/jira/browse/MESOS-2794
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a few MesosContainerizer filesystem tests to test the linux filesystem 
> isolator.
> 
> This adds the tests for https://reviews.apache.org/r/37236/
> 
> 
> Diffs
> -
> 
>   src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 
>   src/tests/containerizer/filesystem_isolator_tests.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37237/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37237/#review95025
---

Ship it!



src/tests/containerizer/filesystem_isolator_tests.cpp (line 157)


So this relies on the launch not failing to indicate it has successfully 
pivoted?

Ideally there is something to prove it's indeed in the new rootfs.



src/tests/containerizer/provisioner.hpp (line 34)


Should this be called MockProvisioner? I think we use TestXYZ to 'XYZ that 
faciliates tests' and MockXYZ for 'Fake XYZ implemented by GMock'. e.g., 
MockSlave.



src/tests/containerizer/provisioner.hpp (lines 46 - 47)


Does this not cause the issue mpark 
[mentioned](http://mail-archives.apache.org/mod_mbox/mesos-dev/201507.mbox/%3ccal3vcqqrcwbblf3u2fdhu1myohqgqjub9ul3zjn+oqxx0on...@mail.gmail.com%3E)?

May have to put them in tests themselves.


- Jiang Yan Xu


On Aug. 7, 2015, 5:32 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37237/
> ---
> 
> (Updated Aug. 7, 2015, 5:32 p.m.)
> 
> 
> Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, 
> Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2794
> https://issues.apache.org/jira/browse/MESOS-2794
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a few MesosContainerizer filesystem tests to test the linux filesystem 
> isolator.
> 
> This adds the tests for https://reviews.apache.org/r/37236/
> 
> 
> Diffs
> -
> 
>   src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 
>   src/tests/containerizer/filesystem_isolator_tests.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37237/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.

2015-08-07 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37237/#review94611
---


Patch looks great!

Reviews applied: [36929, 36930, 36954, 36956, 37054, 37055, 37091, 37105, 
37142, 37159, 37194, 37236, 37237]

All tests passed.

- Mesos ReviewBot


On Aug. 8, 2015, 12:32 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37237/
> ---
> 
> (Updated Aug. 8, 2015, 12:32 a.m.)
> 
> 
> Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, 
> Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2794
> https://issues.apache.org/jira/browse/MESOS-2794
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a few MesosContainerizer filesystem tests to test the linux filesystem 
> isolator.
> 
> This adds the tests for https://reviews.apache.org/r/37236/
> 
> 
> Diffs
> -
> 
>   src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 
>   src/tests/containerizer/filesystem_isolator_tests.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37237/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.

2015-08-07 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37237/
---

(Updated Aug. 8, 2015, 12:32 a.m.)


Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, 
Vinod Kone, and Jiang Yan Xu.


Changes
---

Added a missing header to the makefile.


Bugs: MESOS-2794
https://issues.apache.org/jira/browse/MESOS-2794


Repository: mesos


Description
---

Added a few MesosContainerizer filesystem tests to test the linux filesystem 
isolator.

This adds the tests for https://reviews.apache.org/r/37236/


Diffs (updated)
-

  src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 
  src/tests/containerizer/filesystem_isolator_tests.cpp PRE-CREATION 
  src/tests/containerizer/provisioner.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37237/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.

2015-08-07 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37237/
---

(Updated Aug. 7, 2015, 11:30 p.m.)


Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, 
Vinod Kone, and Jiang Yan Xu.


Changes
---

Moved the tests to a new file and added a few comments.


Bugs: MESOS-2794
https://issues.apache.org/jira/browse/MESOS-2794


Repository: mesos


Description
---

Added a few MesosContainerizer filesystem tests to test the linux filesystem 
isolator.

This adds the tests for https://reviews.apache.org/r/37236/


Diffs (updated)
-

  src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 
  src/tests/containerizer/filesystem_isolator_tests.cpp PRE-CREATION 
  src/tests/containerizer/provisioner.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37237/diff/


Testing
---

sudo make check


Thanks,

Jie Yu