Re: Review Request 41156: Employed a better macro in tests, cleaned up formatting.

2015-12-10 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41156/#review109742
---

Ship it!


Ship It!

- Michael Park


On Dec. 9, 2015, 11:36 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41156/
> ---
> 
> (Updated Dec. 9, 2015, 11:36 p.m.)
> 
> 
> Review request for mesos, Michael Park, Neil Conway, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced all instances of `AWAIT_EXPECT_EQ({true|false}, ...)` with more 
> appropriate `AWAIT_EXPECT_{TRUE|FALSE}(...)`. Also wrapped typenames in 
> backticks in "authorization_tests.cpp".
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp 32beeea3584f093bcac24e0c160235de0e3abb28 
>   src/tests/group_tests.cpp 9db6162dae0a2657e12f4e99334f9cab65d14e9a 
> 
> Diff: https://reviews.apache.org/r/41156/diff/
> 
> 
> Testing
> ---
> 
> `GTEST_FILTER="*AuthorizationTest*:*GroupTest*" make check -j7` on Mac OS 
> 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 41156: Employed a better macro in tests, cleaned up formatting.

2015-12-09 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41156/#review109661
---


Bad patch!

Reviews applied: [41156]

Failed command: ./support/apply-review.sh -n -r 41156

Error:
 2015-12-10 01:55:11 URL:https://reviews.apache.org/r/41156/diff/raw/ 
[14423/14423] -> "41156.patch" [1]
error: patch failed: src/tests/authorization_tests.cpp:390
error: src/tests/authorization_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Dec. 9, 2015, 11:36 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41156/
> ---
> 
> (Updated Dec. 9, 2015, 11:36 p.m.)
> 
> 
> Review request for mesos, Michael Park, Neil Conway, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced all instances of `AWAIT_EXPECT_EQ({true|false}, ...)` with more 
> appropriate `AWAIT_EXPECT_{TRUE|FALSE}(...)`. Also wrapped typenames in 
> backticks in "authorization_tests.cpp".
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp 32beeea3584f093bcac24e0c160235de0e3abb28 
>   src/tests/group_tests.cpp 9db6162dae0a2657e12f4e99334f9cab65d14e9a 
> 
> Diff: https://reviews.apache.org/r/41156/diff/
> 
> 
> Testing
> ---
> 
> `GTEST_FILTER="*AuthorizationTest*:*GroupTest*" make check -j7` on Mac OS 
> 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 41156: Employed a better macro in tests, cleaned up formatting.

2015-12-09 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41156/
---

(Updated Dec. 9, 2015, 11:36 p.m.)


Review request for mesos, Michael Park, Neil Conway, and Till Toenshoff.


Changes
---

Expanded the scope of the patch, updated summary and description, +MPark.


Summary (updated)
-

Employed a better macro in tests, cleaned up formatting.


Repository: mesos


Description (updated)
---

Replaced all instances of `AWAIT_EXPECT_EQ({true|false}, ...)` with more 
appropriate `AWAIT_EXPECT_{TRUE|FALSE}(...)`. Also wrapped typenames in 
backticks in "authorization_tests.cpp".


Diffs (updated)
-

  src/tests/authorization_tests.cpp 32beeea3584f093bcac24e0c160235de0e3abb28 
  src/tests/group_tests.cpp 9db6162dae0a2657e12f4e99334f9cab65d14e9a 

Diff: https://reviews.apache.org/r/41156/diff/


Testing (updated)
---

`GTEST_FILTER="*AuthorizationTest*:*GroupTest*" make check -j7` on Mac OS 
10.10.4


Thanks,

Alexander Rukletsov