Re: Review Request 42130: WIP: Added tests for `ALLOCATION_SLACK` helper functions.

2016-01-12 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42130/#review113969
---


Patch looks great!

Reviews applied: [40375, 41334, 41333, 40529, 41772, 40339, 40632, 41847, 
41791, 41848, 41246, 41248, 41250, 41254, 40379, 41850, 41855, 41856, 41857, 
41858, 41859, 42127, 42130]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 12, 2016, 6:28 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42130/
> ---
> 
> (Updated Jan. 12, 2016, 6:28 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jian Qiu.
> 
> 
> Bugs: MESOS-3897
> https://issues.apache.org/jira/browse/MESOS-3897
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for `ALLOCATION_SLACK` helper functions.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.hpp 576dcb8b7e27d1905425aa0f7cb319c19c17c15c 
>   src/tests/oversubscription_tests.cpp 
> 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
> 
> Diff: https://reviews.apache.org/r/42130/diff/
> 
> 
> Testing
> ---
> 
> make
> make check GTEST_FILTER="OversubscriptionTest.*"
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 42130: WIP: Added tests for `ALLOCATION_SLACK` helper functions.

2016-01-11 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42130/
---

(Updated Jan. 12, 2016, 2:28 p.m.)


Review request for mesos, Guangya Liu and Jian Qiu.


Changes
---

Add test for `getEvictableExecutors`


Bugs: MESOS-3897
https://issues.apache.org/jira/browse/MESOS-3897


Repository: mesos


Description
---

Added tests for `ALLOCATION_SLACK` helper functions.


Diffs (updated)
-

  src/tests/cluster.hpp 576dcb8b7e27d1905425aa0f7cb319c19c17c15c 
  src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 

Diff: https://reviews.apache.org/r/42130/diff/


Testing (updated)
---

make
make check GTEST_FILTER="OversubscriptionTest.*"


Thanks,

Klaus Ma

Re: Review Request 42130: WIP: Added tests for `ALLOCATION_SLACK` helper functions.

2016-01-11 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42130/#review113760
---


Patch looks great!

Reviews applied: [40375, 41334, 41333, 40529, 41772, 40339, 40632, 41847, 
41791, 41848, 41246, 41248, 41250, 41254, 40379, 41850, 41855, 41856, 41857, 
41858, 41859, 42127, 42130]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 11, 2016, 7:52 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42130/
> ---
> 
> (Updated Jan. 11, 2016, 7:52 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jian Qiu.
> 
> 
> Bugs: MESOS-3897
> https://issues.apache.org/jira/browse/MESOS-3897
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for `ALLOCATION_SLACK` helper functions.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.hpp 576dcb8b7e27d1905425aa0f7cb319c19c17c15c 
>   src/tests/oversubscription_tests.cpp 
> 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
> 
> Diff: https://reviews.apache.org/r/42130/diff/
> 
> 
> Testing
> ---
> 
> make
> make check GTEST_FILTER="OversubscriptionTest.GetAllocationSlackHelpers"
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 42130: WIP: Added tests for `ALLOCATION_SLACK` helper functions.

2016-01-11 Thread Jian Qiu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42130/#review113709
---



src/tests/oversubscription_tests.cpp (line 1301)


Is this necessary?



src/tests/oversubscription_tests.cpp (line 1365)


sleep 1000 shoule be enough?



src/tests/oversubscription_tests.cpp (line 1374)


Do you need this? it needs an estimator, but it seems that you have not 
started slave with an estimator. And I don't think estimator is necessary in 
this test?


- Jian Qiu


On 一月 11, 2016, 7:52 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42130/
> ---
> 
> (Updated 一月 11, 2016, 7:52 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jian Qiu.
> 
> 
> Bugs: MESOS-3897
> https://issues.apache.org/jira/browse/MESOS-3897
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for `ALLOCATION_SLACK` helper functions.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.hpp 576dcb8b7e27d1905425aa0f7cb319c19c17c15c 
>   src/tests/oversubscription_tests.cpp 
> 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
> 
> Diff: https://reviews.apache.org/r/42130/diff/
> 
> 
> Testing
> ---
> 
> make
> make check GTEST_FILTER="OversubscriptionTest.GetAllocationSlackHelpers"
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 42130: WIP: Added tests for `ALLOCATION_SLACK` helper functions.

2016-01-10 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42130/
---

(Updated Jan. 11, 2016, 3:52 p.m.)


Review request for mesos, Guangya Liu and Jian Qiu.


Changes
---

Add reviewers.


Bugs: MESOS-3897
https://issues.apache.org/jira/browse/MESOS-3897


Repository: mesos


Description
---

Added tests for `ALLOCATION_SLACK` helper functions.


Diffs
-

  src/tests/cluster.hpp 576dcb8b7e27d1905425aa0f7cb319c19c17c15c 
  src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 

Diff: https://reviews.apache.org/r/42130/diff/


Testing (updated)
---

make
make check GTEST_FILTER="OversubscriptionTest.GetAllocationSlackHelpers"


Thanks,

Klaus Ma