Re: Review Request 42936: Edited flag help strings for style.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42936/#review116982
---


Fix it, then Ship it!





src/master/main.cpp (line 126)


s/this/This/



src/master/main.cpp (line 132)


No need to explicitly specify the default?



src/slave/flags.cpp (line 66)


backticks around `filepath` like you did below for `--modules`.



src/slave/flags.cpp (line 156)


no back ticks around `rack:2`?



src/slave/flags.cpp (line 542)


why is this a backtick?



src/slave/main.cpp (line 99)


s/this/This/



src/slave/main.cpp (line 105)


no need for "(default: 5050).


- Vinod Kone


On Jan. 29, 2016, 5:34 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42936/
> ---
> 
> (Updated Jan. 29, 2016, 5:34 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4298
> https://issues.apache.org/jira/browse/MESOS-4298
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited flag help strings for style.
> 
> Backticks were inserted where appropriate. This not only matches the 
> convention in the comments within our code, helps to enable the automatic 
> generation of markdown-formatted documentation from these help strings.
> 
> 
> Diffs
> -
> 
>   src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d 
>   src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd 
>   src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae 
>   src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
>   src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 
> 
> Diff: https://reviews.apache.org/r/42936/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42936: Edited flag help strings for style.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42936/
---

(Updated Jan. 29, 2016, 7:42 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Added missing default values, addressed comments.


Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298


Repository: mesos


Description
---

Edited flag help strings for style.

Backticks were inserted where appropriate. This not only matches the convention 
in the comments within our code, helps to enable the automatic generation of 
markdown-formatted documentation from these help strings.


Diffs (updated)
-

  src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d 
  src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd 
  src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae 
  src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
  src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 

Diff: https://reviews.apache.org/r/42936/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 42936: Edited flag help strings for style.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42936/
---

(Updated Jan. 29, 2016, 8:02 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Removed unnecessary defaults.


Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298


Repository: mesos


Description
---

Edited flag help strings for style.

Backticks were inserted where appropriate. This not only matches the convention 
in the comments within our code, helps to enable the automatic generation of 
markdown-formatted documentation from these help strings.


Diffs (updated)
-

  src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d 
  src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd 
  src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae 
  src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
  src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 

Diff: https://reviews.apache.org/r/42936/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 42936: Edited flag help strings for style.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42936/
---

(Updated Jan. 29, 2016, 8:51 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298


Repository: mesos


Description
---

Edited flag help strings for style.

Backticks were inserted where appropriate. This not only matches the convention 
in the comments within our code, helps to enable the automatic generation of 
markdown-formatted documentation from these help strings.


Diffs (updated)
-

  src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d 
  src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd 
  src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae 
  src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
  src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 

Diff: https://reviews.apache.org/r/42936/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 42936: Edited flag help strings for style.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42936/
---

(Updated Jan. 29, 2016, 9:09 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298


Repository: mesos


Description
---

Edited flag help strings for style.

Backticks were inserted where appropriate. This not only matches the convention 
in the comments within our code, helps to enable the automatic generation of 
markdown-formatted documentation from these help strings.


Diffs (updated)
-

  src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d 
  src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd 
  src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae 
  src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
  src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 

Diff: https://reviews.apache.org/r/42936/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 42936: Edited flag help strings for style.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42936/#review116916
---



Patch looks great!

Reviews applied: [42936]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 29, 2016, 5:34 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42936/
> ---
> 
> (Updated Jan. 29, 2016, 5:34 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4298
> https://issues.apache.org/jira/browse/MESOS-4298
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited flag help strings for style.
> 
> Backticks were inserted where appropriate. This not only matches the 
> convention in the comments within our code, helps to enable the automatic 
> generation of markdown-formatted documentation from these help strings.
> 
> 
> Diffs
> -
> 
>   src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d 
>   src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd 
>   src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae 
>   src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
>   src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 
> 
> Diff: https://reviews.apache.org/r/42936/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42936: Edited flag help strings for style.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42936/#review116886
---



Bad patch!

Reviews applied: [42936]

Failed command: ./support/apply-review.sh -n -r 42936

Error:
 ..
2016-01-29 03:38:55 URL:https://reviews.apache.org/r/42936/diff/raw/ 
[41767/41767] -> "42936.patch" [1]
src/slave/flags.cpp:134:  Lines should be <= 80 characters long  
[whitespace/line_length] [2]
Total errors found: 1
Checking 5 files

Full log: https://builds.apache.org/job/mesos-reviewbot/11108/console

- Mesos ReviewBot


On Jan. 29, 2016, 2:17 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42936/
> ---
> 
> (Updated Jan. 29, 2016, 2:17 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4298
> https://issues.apache.org/jira/browse/MESOS-4298
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited flag help strings for style.
> 
> Backticks were inserted where appropriate. This not only matches the 
> convention in the comments within our code, helps to enable the automatic 
> generation of markdown-formatted documentation from these help strings.
> 
> 
> Diffs
> -
> 
>   src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d 
>   src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd 
>   src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae 
>   src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
>   src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 
> 
> Diff: https://reviews.apache.org/r/42936/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42936: Edited flag help strings for style.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42936/
---

(Updated Jan. 29, 2016, 4:30 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Fixed line length.


Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298


Repository: mesos


Description
---

Edited flag help strings for style.

Backticks were inserted where appropriate. This not only matches the convention 
in the comments within our code, helps to enable the automatic generation of 
markdown-formatted documentation from these help strings.


Diffs (updated)
-

  src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d 
  src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd 
  src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae 
  src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
  src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 

Diff: https://reviews.apache.org/r/42936/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 42936: Edited flag help strings for style.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42936/#review116899
---


Fix it, then Ship it!





src/master/flags.cpp (line 144)


Move "By" to the next line.


- Klaus Ma


On Jan. 29, 2016, 12:30 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42936/
> ---
> 
> (Updated Jan. 29, 2016, 12:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4298
> https://issues.apache.org/jira/browse/MESOS-4298
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited flag help strings for style.
> 
> Backticks were inserted where appropriate. This not only matches the 
> convention in the comments within our code, helps to enable the automatic 
> generation of markdown-formatted documentation from these help strings.
> 
> 
> Diffs
> -
> 
>   src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d 
>   src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd 
>   src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae 
>   src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
>   src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 
> 
> Diff: https://reviews.apache.org/r/42936/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 42936: Edited flag help strings for style.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42936/
---

(Updated Jan. 29, 2016, 5:30 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298


Repository: mesos


Description
---

Edited flag help strings for style.

Backticks were inserted where appropriate. This not only matches the convention 
in the comments within our code, helps to enable the automatic generation of 
markdown-formatted documentation from these help strings.


Diffs (updated)
-

  src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d 
  src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd 
  src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae 
  src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
  src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 

Diff: https://reviews.apache.org/r/42936/diff/


Testing
---

`make check`


Thanks,

Greg Mann

Re: Review Request 42936: Edited flag help strings for style.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42936/
---

(Updated Jan. 29, 2016, 5:34 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298


Repository: mesos


Description
---

Edited flag help strings for style.

Backticks were inserted where appropriate. This not only matches the convention 
in the comments within our code, helps to enable the automatic generation of 
markdown-formatted documentation from these help strings.


Diffs (updated)
-

  src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d 
  src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd 
  src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae 
  src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
  src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 

Diff: https://reviews.apache.org/r/42936/diff/


Testing
---

`make check`


Thanks,

Greg Mann