Re: Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

2016-02-04 Thread Jiang Yan Xu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43165/#review117841
---


Ship it!




Ship It!

- Jiang Yan Xu


On Feb. 3, 2016, 4:17 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43165/
> ---
> 
> (Updated Feb. 3, 2016, 4:17 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4592
> https://issues.apache.org/jira/browse/MESOS-4592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Document LIBPROCESS_THREAD_COUNT.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 
> 
> Diff: https://reviews.apache.org/r/43165/diff/
> 
> 
> Testing
> ---
> 
> Source inspection.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

2016-02-03 Thread James Peach 


> On Feb. 4, 2016, 3:18 a.m., Guangya Liu wrote:
> > docs/configuration.md, line 1680
> > 
> >
> > s/overridden/overwritten ?

No, "overridden" is correct here.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43165/#review117759
---


On Feb. 4, 2016, 12:17 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43165/
> ---
> 
> (Updated Feb. 4, 2016, 12:17 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4592
> https://issues.apache.org/jira/browse/MESOS-4592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Document LIBPROCESS_THREAD_COUNT.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 
> 
> Diff: https://reviews.apache.org/r/43165/diff/
> 
> 
> Testing
> ---
> 
> Source inspection.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

2016-02-03 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43165/#review117759
---




docs/configuration.md (line 1680)


s/overridden/overwritten ?


- Guangya Liu


On Feb. 4, 2016, 12:17 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43165/
> ---
> 
> (Updated Feb. 4, 2016, 12:17 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4592
> https://issues.apache.org/jira/browse/MESOS-4592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Document LIBPROCESS_THREAD_COUNT.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 
> 
> Diff: https://reviews.apache.org/r/43165/diff/
> 
> 
> Testing
> ---
> 
> Source inspection.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

2016-02-03 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43165/#review117745
---



Patch looks great!

Reviews applied: [43149, 43165]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 4, 2016, 12:17 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43165/
> ---
> 
> (Updated Feb. 4, 2016, 12:17 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4592
> https://issues.apache.org/jira/browse/MESOS-4592
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Document LIBPROCESS_THREAD_COUNT.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 
> 
> Diff: https://reviews.apache.org/r/43165/diff/
> 
> 
> Testing
> ---
> 
> Source inspection.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 43165: Document LIBPROCESS_THREAD_COUNT.

2016-02-03 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43165/
---

(Updated Feb. 4, 2016, 12:17 a.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4592
https://issues.apache.org/jira/browse/MESOS-4592


Repository: mesos


Description
---

Document LIBPROCESS_THREAD_COUNT.


Diffs
-

  docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 

Diff: https://reviews.apache.org/r/43165/diff/


Testing
---

Source inspection.


Thanks,

James Peach