Re: Review Request 43302: Libprocess: Introduced Hooks and Options for Subprocess.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43302/#review118215
---




3rdparty/libprocess/include/process/subprocess.hpp (line 160)


Why we not use `const` instead of `constexpr` here?


- haosdent huang


On Feb. 7, 2016, 1:57 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43302/
> ---
> 
> (Updated Feb. 7, 2016, 1:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> bb50cc3070245a294fa16efe44f14ae893bc5518 
>   3rdparty/libprocess/src/subprocess.cpp 
> ff477e37a9619c780bddd5a8e629fa981b729715 
> 
> Diff: https://reviews.apache.org/r/43302/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43302: Libprocess: Introduced Hooks and Options for Subprocess.

[Joris Van Remoortere]

> On Feb. 8, 2016, 11:13 a.m., haosdent huang wrote:
> > 3rdparty/libprocess/include/process/subprocess.hpp, line 160
> > 
> >
> > Why we not use `const` instead of `constexpr` here?

Because a parameter to a template specialization must be a `constexpr`.


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43302/#review118215
---


On Feb. 7, 2016, 1:57 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43302/
> ---
> 
> (Updated Feb. 7, 2016, 1:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> bb50cc3070245a294fa16efe44f14ae893bc5518 
>   3rdparty/libprocess/src/subprocess.cpp 
> ff477e37a9619c780bddd5a8e629fa981b729715 
> 
> Diff: https://reviews.apache.org/r/43302/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 43302: Libprocess: Introduced Hooks and Options for Subprocess.

[haosdent huang]

> On Feb. 8, 2016, 11:13 a.m., haosdent huang wrote:
> > 3rdparty/libprocess/include/process/subprocess.hpp, line 160
> > 
> >
> > Why we not use `const` instead of `constexpr` here?
> 
> Joris Van Remoortere wrote:
> Because a parameter to a template specialization must be a `constexpr`.

got it, thank you very much for your explanation.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43302/#review118215
---


On Feb. 7, 2016, 1:57 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43302/
> ---
> 
> (Updated Feb. 7, 2016, 1:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> bb50cc3070245a294fa16efe44f14ae893bc5518 
>   3rdparty/libprocess/src/subprocess.cpp 
> ff477e37a9619c780bddd5a8e629fa981b729715 
> 
> Diff: https://reviews.apache.org/r/43302/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>