Re: Review Request 43822: Updated `/slaves` master endpoint to use jsonify.

2016-02-27 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43822/#review121115
---


Ship it!





src/master/http.cpp (line 1228)


Committed with the `const` qualifier preserved.


- Michael Park


On Feb. 28, 2016, 12:15 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43822/
> ---
> 
> (Updated Feb. 28, 2016, 12:15 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `/slaves` master endpoint to use jsonify.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829 
> 
> Diff: https://reviews.apache.org/r/43822/diff/
> 
> 
> Testing
> ---
> 
> make check. Also verified that this endpoint is covered by the unit tests.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 43822: Updated `/slaves` master endpoint to use jsonify.

2016-02-27 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43822/
---

(Updated Feb. 28, 2016, 12:15 a.m.)


Review request for mesos and Michael Park.


Changes
---

Rebase.


Repository: mesos


Description
---

Updated `/slaves` master endpoint to use jsonify.


Diffs (updated)
-

  src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829 

Diff: https://reviews.apache.org/r/43822/diff/


Testing
---

make check. Also verified that this endpoint is covered by the unit tests.


Thanks,

Neil Conway

Re: Review Request 43822: Updated `/slaves` master endpoint to use jsonify.

2016-02-23 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43822/
---

(Updated Feb. 23, 2016, 10:29 p.m.)


Review request for mesos and Michael Park.


Changes
---

Rebase.


Repository: mesos


Description
---

Updated `/slaves` master endpoint to use jsonify.


Diffs (updated)
-

  src/master/http.cpp 939fab21a2240de7214ef809a194ffb3837a9f1b 

Diff: https://reviews.apache.org/r/43822/diff/


Testing
---

make check. Also verified that this endpoint is covered by the unit tests.


Thanks,

Neil Conway

Re: Review Request 43822: Updated `/slaves` master endpoint to use jsonify.

2016-02-23 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43822/#review120291
---


Ship it!




Ship It!

- Klaus Ma


On Feb. 22, 2016, 3:12 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43822/
> ---
> 
> (Updated Feb. 22, 2016, 3:12 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `/slaves` master endpoint to use jsonify.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 
> 
> Diff: https://reviews.apache.org/r/43822/diff/
> 
> 
> Testing
> ---
> 
> make check. Also verified that this endpoint is covered by the unit tests.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>