Re: Review Request 44084: Windows: Forked os::rename().

2016-04-08 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44084/#review127930
---


Ship it!




Ship It!

- Michael Park


On April 7, 2016, 10:15 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44084/
> ---
> 
> (Updated April 7, 2016, 10:15 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked os::rename().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rename.hpp 
> 7b2215208bcaa5613426d8ede9cab21d1a084631 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/44084/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44084: Windows: Forked os::rename().

2016-04-07 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44084/
---

(Updated April 7, 2016, 10:15 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Forked os::rename().


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
7bd4bfbc2ec5922879dcefddc12137336b11be52 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rename.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rename.hpp 
7b2215208bcaa5613426d8ede9cab21d1a084631 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 

Diff: https://reviews.apache.org/r/44084/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 44084: Windows: Forked os::rename().

2016-04-06 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44084/#review127502
---




3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (lines 211 - 
256)


Same as https://reviews.apache.org/r/45015/, I thought we concluded that 
actions such as `os::mkdir` and `os::touch` should be `ASSERT_*`, and the 
things that are being actually being tested here, i.e. `os::exists` should be 
`EXPECT_*`.


- Michael Park


On March 24, 2016, 2:59 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44084/
> ---
> 
> (Updated March 24, 2016, 2:59 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked os::rename().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rename.hpp 
> 7b2215208bcaa5613426d8ede9cab21d1a084631 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/44084/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44084: Windows: Forked os::rename().

2016-03-25 Thread Yi Sun 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44084/#review125451
---


Ship it!




Ship It!

- Yi Sun


On March 24, 2016, 2:59 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44084/
> ---
> 
> (Updated March 24, 2016, 2:59 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked os::rename().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rename.hpp 
> 7b2215208bcaa5613426d8ede9cab21d1a084631 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/44084/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44084: Windows: Forked os::rename().

2016-03-24 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44084/
---

(Updated March 24, 2016, 2:59 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Forked os::rename().


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
7bd4bfbc2ec5922879dcefddc12137336b11be52 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rename.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rename.hpp 
7b2215208bcaa5613426d8ede9cab21d1a084631 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 

Diff: https://reviews.apache.org/r/44084/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 44084: Windows: Forked os::rename().

2016-03-21 Thread Michael Park 


> On March 21, 2016, 7:24 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 222
> > 
> >
> > ```
> > ASSERT_EQ(message, file3Contents.get());
> > ```

Actually, these should be `EXPECT_*` please. Here and below.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44084/#review124623
---


On March 17, 2016, 11:59 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44084/
> ---
> 
> (Updated March 17, 2016, 11:59 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked os::rename().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rename.hpp 
> 7b2215208bcaa5613426d8ede9cab21d1a084631 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/44084/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44084: Windows: Forked os::rename().

2016-03-21 Thread Michael Park 


> On March 21, 2016, 7:24 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 234
> > 
> >
> > ```
> > ASSERT_TRUE(0u, file2Contents.get());
> > ```

oops. `s/ASSERT_TRUE/ASSERT_EQ/`


> On March 21, 2016, 7:24 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 238
> > 
> >
> > ```
> > ASSERT_TRUE(1u, allFiles.get().size());
> > ```

oops. `s/ASSERT_TRUE/ASSERT_EQ/`


> On March 21, 2016, 7:24 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 248
> > 
> >
> > ```
> > ASSERT_TRUE(1u, allFiles.get().size());
> > ```

oops. `s/ASSERT_TRUE/ASSERT_EQ/`


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44084/#review124623
---


On March 17, 2016, 11:59 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44084/
> ---
> 
> (Updated March 17, 2016, 11:59 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked os::rename().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rename.hpp 
> 7b2215208bcaa5613426d8ede9cab21d1a084631 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/44084/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 44084: Windows: Forked os::rename().

2016-03-21 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44084/#review124623
---




3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp (lines 
45 - 46)


```
return WindowsError(
"`os::rename` failed to move file '" + from + "' to '" + to + "'");
```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 192)


Add newline.



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 213)


```
ASSERT_EQ(2u, allFiles.get().size());
```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 216)


```
s/that was in `file`/\that was in `file1`/
```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 217)


"has gone down"? shouldn't this be: that the count of files in the 
directory has not changed..?



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 222)


```
ASSERT_EQ(message, file3Contents.get());
```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 226)


```
ASSERT_EQ(2u, allFiles.get().size());
```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 229)


`s/cound/count/`



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 234)


```
ASSERT_TRUE(0u, file2Contents.get());
```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 238)


```
ASSERT_TRUE(1u, allFiles.get().size());
```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 248)


```
ASSERT_TRUE(1u, allFiles.get().size());
```


- Michael Park


On March 17, 2016, 11:59 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44084/
> ---
> 
> (Updated March 17, 2016, 11:59 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked os::rename().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rename.hpp 
> 7b2215208bcaa5613426d8ede9cab21d1a084631 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 
> 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 
> 
> Diff: https://reviews.apache.org/r/44084/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>