Re: Review Request 46936: Documented the agent endpoint '/flags'.

2016-05-09 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46936/#review132274
---


Ship it!




I'll resolve outstading issues and commit this for you.

- Alexander Rukletsov


On May 3, 2016, 2:36 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46936/
> ---
> 
> (Updated May 3, 2016, 2:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Neil 
> Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/slave/flags.md b2740e6a4ce4bb8c25de07071bafbf174adf9137 
>   src/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5 
> 
> Diff: https://reviews.apache.org/r/46936/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 46936: Documented the agent endpoint '/flags'.

2016-05-09 Thread Alexander Rukletsov 


> On May 5, 2016, 4:15 p.m., Neil Conway wrote:
> > src/slave/http.cpp, lines 356-357
> > 
> >
> > +1, although I'd say "The current principal should be ..."

I'm ESL, but for me "current" in this context sounds like a principal which is 
stored or cached by Mesos, and hence "current" to the context. But we are 
talking about the principal from the request, which may be observed by Mesos 
for the first time. Maybe we can find a better word, e.g. provided, specified, 
or "request principal"?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46936/#review131848
---


On May 3, 2016, 2:36 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46936/
> ---
> 
> (Updated May 3, 2016, 2:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Neil 
> Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/slave/flags.md b2740e6a4ce4bb8c25de07071bafbf174adf9137 
>   src/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5 
> 
> Diff: https://reviews.apache.org/r/46936/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 46936: Documented the agent endpoint '/flags'.

2016-05-05 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46936/#review131848
---




docs/endpoints/slave/flags.md (line 15)


This change should probably be removed.



src/slave/http.cpp (lines 356 - 357)


+1, although I'd say "The current principal should be ..."


- Neil Conway


On May 3, 2016, 2:36 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46936/
> ---
> 
> (Updated May 3, 2016, 2:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Neil 
> Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/slave/flags.md b2740e6a4ce4bb8c25de07071bafbf174adf9137 
>   src/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5 
> 
> Diff: https://reviews.apache.org/r/46936/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 46936: Documented the agent endpoint '/flags'.

2016-05-04 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46936/#review131739
---




src/slave/http.cpp (lines 356 - 357)


How about something like: "The principal should be authorized to query this 
endpoint"?


- Alexander Rukletsov


On May 3, 2016, 2:36 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46936/
> ---
> 
> (Updated May 3, 2016, 2:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Neil 
> Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/slave/flags.md b2740e6a4ce4bb8c25de07071bafbf174adf9137 
>   src/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5 
> 
> Diff: https://reviews.apache.org/r/46936/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 46936: Documented the agent endpoint '/flags'.

2016-05-03 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46936/#review131519
---



Patch looks great!

Reviews applied: [46935, 46936]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 3, 2016, 2:36 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46936/
> ---
> 
> (Updated May 3, 2016, 2:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Neil 
> Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/slave/flags.md b2740e6a4ce4bb8c25de07071bafbf174adf9137 
>   src/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5 
> 
> Diff: https://reviews.apache.org/r/46936/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>