Re: Review Request 47743: Supported private registry per-container in unified containerizer.
> On June 12, 2016, 1:05 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [47743, 47742, 45952, 48605, 48604, 48570, 45951, 47808, > > 47807, 47806, 45950, 45949] > > > > Failed command: ./support/apply-review.sh -n -r 47807 > > > > Error: > > 2016-06-12 20:05:27 URL:https://reviews.apache.org/r/47807/diff/raw/ > > [2067/2067] -> "47807.patch" [1] > > error: patch failed: include/mesos/docker/spec.hpp:76 > > error: include/mesos/docker/spec.hpp: patch does not apply > > > > Full log: https://builds.apache.org/job/mesos-reviewbot/13720/console Should be ok after discarding two un-used dependencies. - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47743/#review137202 --- On June 12, 2016, 12:11 p.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47743/ > --- > > (Updated June 12, 2016, 12:11 p.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Repository: mesos > > > Description > --- > > Supported private registry per-container in unified containerizer. > > > Diffs > - > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 6545a6d29cb91d6cf8919c7796c283084178e499 > src/uri/fetchers/docker.cpp ab8f5e05758b7de2573605c81ac80e656bb1db24 > src/uri/schemes/docker.hpp 68dbf3ffb20c59c7af9558f5ed0bb5706d8aa057 > > Diff: https://reviews.apache.org/r/47743/diff/ > > > Testing > --- > > make check > > Tested by mesos-execute. > > > Thanks, > > Gilbert Song > >
Re: Review Request 47743: Supported private registry per-container in unified containerizer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47743/#review137202 --- Bad patch! Reviews applied: [47743, 47742, 45952, 48605, 48604, 48570, 45951, 47808, 47807, 47806, 45950, 45949] Failed command: ./support/apply-review.sh -n -r 47807 Error: 2016-06-12 20:05:27 URL:https://reviews.apache.org/r/47807/diff/raw/ [2067/2067] -> "47807.patch" [1] error: patch failed: include/mesos/docker/spec.hpp:76 error: include/mesos/docker/spec.hpp: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/13720/console - Mesos ReviewBot On June 12, 2016, 7:11 p.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47743/ > --- > > (Updated June 12, 2016, 7:11 p.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Repository: mesos > > > Description > --- > > Supported private registry per-container in unified containerizer. > > > Diffs > - > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 6545a6d29cb91d6cf8919c7796c283084178e499 > src/uri/fetchers/docker.cpp ab8f5e05758b7de2573605c81ac80e656bb1db24 > src/uri/schemes/docker.hpp 68dbf3ffb20c59c7af9558f5ed0bb5706d8aa057 > > Diff: https://reviews.apache.org/r/47743/diff/ > > > Testing > --- > > make check > > Tested by mesos-execute. > > > Thanks, > > Gilbert Song > >
Re: Review Request 47743: Supported private registry per-container in unified containerizer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47743/ --- (Updated June 12, 2016, 12:11 p.m.) Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos Description --- Supported private registry per-container in unified containerizer. Diffs (updated) - src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 6545a6d29cb91d6cf8919c7796c283084178e499 src/uri/fetchers/docker.cpp ab8f5e05758b7de2573605c81ac80e656bb1db24 src/uri/schemes/docker.hpp 68dbf3ffb20c59c7af9558f5ed0bb5706d8aa057 Diff: https://reviews.apache.org/r/47743/diff/ Testing --- make check Tested by mesos-execute. Thanks, Gilbert Song
Re: Review Request 47743: Supported private registry per-container in unified containerizer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47743/#review137094 --- Bad patch! Reviews applied: [47743, 47742, 45952, 48570, 45951, 47808, 47807, 47806, 45950, 45949] Failed command: ./support/apply-review.sh -n -r 47807 Error: 2016-06-11 00:45:02 URL:https://reviews.apache.org/r/47807/diff/raw/ [2067/2067] -> "47807.patch" [1] error: patch failed: include/mesos/docker/spec.hpp:76 error: include/mesos/docker/spec.hpp: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/13680/console - Mesos ReviewBot On June 11, 2016, 12:42 a.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47743/ > --- > > (Updated June 11, 2016, 12:42 a.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Repository: mesos > > > Description > --- > > Supported private registry per-container in unified containerizer. > > > Diffs > - > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 6545a6d29cb91d6cf8919c7796c283084178e499 > src/uri/fetchers/docker.cpp ab8f5e05758b7de2573605c81ac80e656bb1db24 > src/uri/schemes/docker.hpp 68dbf3ffb20c59c7af9558f5ed0bb5706d8aa057 > > Diff: https://reviews.apache.org/r/47743/diff/ > > > Testing > --- > > make check > > Tested by mesos-execute. > > > Thanks, > > Gilbert Song > >
Re: Review Request 47743: Supported private registry per-container in unified containerizer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47743/ --- (Updated June 10, 2016, 5:42 p.m.) Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos Description --- Supported private registry per-container in unified containerizer. Diffs (updated) - src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 6545a6d29cb91d6cf8919c7796c283084178e499 src/uri/fetchers/docker.cpp ab8f5e05758b7de2573605c81ac80e656bb1db24 src/uri/schemes/docker.hpp 68dbf3ffb20c59c7af9558f5ed0bb5706d8aa057 Diff: https://reviews.apache.org/r/47743/diff/ Testing --- make check Tested by mesos-execute. Thanks, Gilbert Song
