Re: Review Request 48056: Windows: Added build and run instructions.

2016-06-22 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48056/
---

(Updated June 22, 2016, 7:10 a.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
Van Remoortere, and Michael Park.


Repository: mesos


Description
---

Windows: Added build and run instructions.


Diffs (updated)
-

  docs/getting-started.md 04d74c12bd86277ee95f9c6418f55900843746a4 

Diff: https://reviews.apache.org/r/48056/diff/


Testing
---


Thanks,

Daniel Pravat

Re: Review Request 48056: Windows: Added build and run instructions.

2016-06-20 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48056/#review138724
---


Fix it, then Ship it!




Managed to build on Windows 8, but we can keep the prerequisite version 10+.

After inspecting the website-rendered version, there are a couple things we can 
massage to make the instructions look better.


docs/getting-started.md (line 29)


s/sources/source/



docs/getting-started.md (lines 174 - 176)


Change these links to use `[text](href)` syntax.

Also, can you change these to a numbered list? i.e.

1. Install VS
2. Install CMake
3. Install Patch



docs/getting-started.md (lines 178 - 180)


These notes can be interleaved with the appropriate downloads above.  (i.e. 
the user should do installations in order)



docs/getting-started.md (line 182)


Add `(Posix)` here (assuming `Windows != Posix` is general knowledge).  We 
don't want to follow these steps on Windows.



docs/getting-started.md (lines 204 - 205)


Add a note about bootstrap here:
```
# If you are developing on Windows, we recommend running the bootstrap.
# This requires administrator privileges.
$ ./bootstrap.bat
```



docs/getting-started.md (lines 219 - 221)


Add a note that the "PreferredToolArchitecture" can be set system-wide via 
Control Panel.

I would also put this text block above the `msbuild ...` line.


- Joseph Wu


On June 20, 2016, 3:25 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48056/
> ---
> 
> (Updated June 20, 2016, 3:25 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
> Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added build and run instructions.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 8c72e5ec1263adb8792c8c49ede50bbf649e1ef3 
> 
> Diff: https://reviews.apache.org/r/48056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 48056: Windows: Added build and run instructions.

2016-06-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48056/#review138708
---



Bad review!

Reviews applied: [48056]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On June 20, 2016, 10:25 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48056/
> ---
> 
> (Updated June 20, 2016, 10:25 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
> Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added build and run instructions.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 8c72e5ec1263adb8792c8c49ede50bbf649e1ef3 
> 
> Diff: https://reviews.apache.org/r/48056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 48056: Windows: Added build and run instructions.

2016-06-20 Thread Daniel Pravat 


> On June 18, 2016, 2:18 a.m., Joseph Wu wrote:
> > docs/getting-started.md, lines 175-176
> > 
> >
> > Are there links to more general download pages?
> > 
> > It seems odd to have very specific versions here.  Presumably an 
> > older/newer cmake or gnu patch would suffice.

This are the latest versions. We haven't tested with anything else.


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48056/#review138369
---


On June 20, 2016, 10:25 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48056/
> ---
> 
> (Updated June 20, 2016, 10:25 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
> Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added build and run instructions.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 8c72e5ec1263adb8792c8c49ede50bbf649e1ef3 
> 
> Diff: https://reviews.apache.org/r/48056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 48056: Windows: Added build and run instructions.

2016-06-20 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48056/
---

(Updated June 20, 2016, 10:25 p.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
Van Remoortere, and Michael Park.


Repository: mesos


Description
---

Windows: Added build and run instructions.


Diffs (updated)
-

  docs/getting-started.md 8c72e5ec1263adb8792c8c49ede50bbf649e1ef3 

Diff: https://reviews.apache.org/r/48056/diff/


Testing
---


Thanks,

Daniel Pravat

Re: Review Request 48056: Windows: Added build and run instructions.

2016-06-20 Thread Daniel Pravat 


> On June 19, 2016, 11:20 p.m., Joseph Wu wrote:
> > Possibly missing some steps related to OpenSSL.  Here's what I got while 
> > building the curl dependency (for example):
> > 
> > ```
> > 1>  -- Could NOT find OpenSSL, try to set the path to OpenSSL root folder 
> > in the system variable OPENSSL_ROOT_DIR (missing:  OPENSSL_LIBRARIES 
> > OPENSSL_INCLUDE_DIR)
> > 1>  CMake Warning at CMakeLists.txt:462 (find_package):
> > 1>By not providing "FindLibSSH2.cmake" in CMAKE_MODULE_PATH this 
> > project has
> > 1>asked CMake to find a package configuration file provided by 
> > "LibSSH2", but
> > 1>CMake did not find one.
> > 1>
> > 1>Could not find a package configuration file provided by "LibSSH2" 
> > with any
> > 1>of the following names:
> > 1>
> > 1>  LibSSH2Config.cmake
> > 1>  libssh2-config.cmake
> > 1>
> > 1>Add the installation prefix of "LibSSH2" to CMAKE_PREFIX_PATH or set
> > 1>"LibSSH2_DIR" to a directory containing one of the above files.  If
> > 1>"LibSSH2" provides a separate development package or SDK, be sure it 
> > has
> > 1>been installed.
> > 1>
> > 1>
> > 1>  CMake Error at CMake/OtherTests.cmake:86 (message):
> > 1>Unable to link function recv
> > 1>  Call Stack (most recent call first):
> > 1>CMakeLists.txt:988 (include)
> > 1>
> > 1>
> > 1>  -- Configuring incomplete, errors occurred!
> > ```

OpenSSL is not used at this time.


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48056/#review138485
---


On June 15, 2016, 6:19 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48056/
> ---
> 
> (Updated June 15, 2016, 6:19 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
> Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added build and run instructions.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 8c72e5ec1263adb8792c8c49ede50bbf649e1ef3 
> 
> Diff: https://reviews.apache.org/r/48056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 48056: Windows: Added build and run instructions.

2016-06-20 Thread Daniel Pravat 


> On June 19, 2016, 11:20 p.m., Joseph Wu wrote:
> > docs/getting-started.md, line 215
> > 
> >
> > s/-DENABLE_LIB_EVENT/-DENABLE_LIBEVENT/
> > 
> > Looks like we also need to specify:
> > `cmake -G "Visual Studio 14 2015 Win64" ..`

Thank you!


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48056/#review138485
---


On June 15, 2016, 6:19 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48056/
> ---
> 
> (Updated June 15, 2016, 6:19 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
> Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added build and run instructions.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 8c72e5ec1263adb8792c8c49ede50bbf649e1ef3 
> 
> Diff: https://reviews.apache.org/r/48056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 48056: Windows: Added build and run instructions.

2016-06-19 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48056/#review138485
---



Possibly missing some steps related to OpenSSL.  Here's what I got while 
building the curl dependency (for example):

```
1>  -- Could NOT find OpenSSL, try to set the path to OpenSSL root folder in 
the system variable OPENSSL_ROOT_DIR (missing:  OPENSSL_LIBRARIES 
OPENSSL_INCLUDE_DIR)
1>  CMake Warning at CMakeLists.txt:462 (find_package):
1>By not providing "FindLibSSH2.cmake" in CMAKE_MODULE_PATH this project has
1>asked CMake to find a package configuration file provided by "LibSSH2", 
but
1>CMake did not find one.
1>
1>Could not find a package configuration file provided by "LibSSH2" with any
1>of the following names:
1>
1>  LibSSH2Config.cmake
1>  libssh2-config.cmake
1>
1>Add the installation prefix of "LibSSH2" to CMAKE_PREFIX_PATH or set
1>"LibSSH2_DIR" to a directory containing one of the above files.  If
1>"LibSSH2" provides a separate development package or SDK, be sure it has
1>been installed.
1>
1>
1>  CMake Error at CMake/OtherTests.cmake:86 (message):
1>Unable to link function recv
1>  Call Stack (most recent call first):
1>CMakeLists.txt:988 (include)
1>
1>
1>  -- Configuring incomplete, errors occurred!
```


docs/getting-started.md (line 207)


Add a note here:

This can be found by opening VS2015 and looking under the "tools" menu for 
"Visual Studio Command Prompt".



docs/getting-started.md (line 215)


s/-DENABLE_LIB_EVENT/-DENABLE_LIBEVENT/

Looks like we also need to specify:
`cmake -G "Visual Studio 14 2015 Win64" ..`



docs/getting-started.md (line 227)


Space at the beginning, period at the end.



docs/getting-started.md (line 230)


Minor nits (spacing, capitalization, period).


- Joseph Wu


On June 15, 2016, 11:19 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48056/
> ---
> 
> (Updated June 15, 2016, 11:19 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
> Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added build and run instructions.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 8c72e5ec1263adb8792c8c49ede50bbf649e1ef3 
> 
> Diff: https://reviews.apache.org/r/48056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 48056: Windows: Added build and run instructions.

2016-06-17 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48056/#review138377
---



Bad review!

Reviews applied: [48056]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On June 15, 2016, 6:19 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48056/
> ---
> 
> (Updated June 15, 2016, 6:19 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
> Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added build and run instructions.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 8c72e5ec1263adb8792c8c49ede50bbf649e1ef3 
> 
> Diff: https://reviews.apache.org/r/48056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 48056: Windows: Added build and run instructions.

2016-06-17 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48056/#review138369
---



I'll give this a shot on Win8 (the only Windows version I have handy).  If all 
goes well, maybe we can bump the requirements down a version :)


docs/getting-started.md (lines 175 - 176)


Are there links to more general download pages?

It seems odd to have very specific versions here.  Presumably an 
older/newer cmake or gnu patch would suffice.


- Joseph Wu


On June 15, 2016, 11:19 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48056/
> ---
> 
> (Updated June 15, 2016, 11:19 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
> Van Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added build and run instructions.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 8c72e5ec1263adb8792c8c49ede50bbf649e1ef3 
> 
> Diff: https://reviews.apache.org/r/48056/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 48056: Windows: Added build and run instructions.

2016-06-15 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48056/
---

(Updated June 15, 2016, 6:19 p.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris 
Van Remoortere, and Michael Park.


Repository: mesos


Description
---

Windows: Added build and run instructions.


Diffs (updated)
-

  docs/getting-started.md 8c72e5ec1263adb8792c8c49ede50bbf649e1ef3 

Diff: https://reviews.apache.org/r/48056/diff/


Testing
---


Thanks,

Daniel Pravat