Re: Review Request 49839: Removed the network isolator specific check in netlink socket method.
> On July 11, 2016, 2:10 p.m., Qian Zhang wrote: > > So the main purposal of this patch is to remove the dependency (e.g., > > `nl_has_capability()`) of higher version of libnl from `routing::socket()` > > which can then work with lower version of libnl, right? Yeah. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49839/#review141688 --- On July 8, 2016, 11:57 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49839/ > --- > > (Updated July 8, 2016, 11:57 p.m.) > > > Review request for mesos, Avinash sridharan and Qian Zhang. > > > Repository: mesos > > > Description > --- > > This check has been performed in the port mapping isolator as well in > the corresponding tests. > > > Diffs > - > > src/linux/routing/internal.hpp 939634637d13497e77f4a8c3d4257eb98c92fa3f > > Diff: https://reviews.apache.org/r/49839/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
Re: Review Request 49839: Removed the network isolator specific check in netlink socket method.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49839/#review141702 --- Ship it! Ship It! - Avinash sridharan On July 8, 2016, 11:57 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49839/ > --- > > (Updated July 8, 2016, 11:57 p.m.) > > > Review request for mesos, Avinash sridharan and Qian Zhang. > > > Repository: mesos > > > Description > --- > > This check has been performed in the port mapping isolator as well in > the corresponding tests. > > > Diffs > - > > src/linux/routing/internal.hpp 939634637d13497e77f4a8c3d4257eb98c92fa3f > > Diff: https://reviews.apache.org/r/49839/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
Re: Review Request 49839: Removed the network isolator specific check in netlink socket method.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49839/#review141688 --- Ship it! So the main purposal of this patch is to remove the dependency (e.g., `nl_has_capability()`) of higher version of libnl from `routing::socket()` which can then work with lower version of libnl, right? - Qian Zhang On July 9, 2016, 7:57 a.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49839/ > --- > > (Updated July 9, 2016, 7:57 a.m.) > > > Review request for mesos, Avinash sridharan and Qian Zhang. > > > Repository: mesos > > > Description > --- > > This check has been performed in the port mapping isolator as well in > the corresponding tests. > > > Diffs > - > > src/linux/routing/internal.hpp 939634637d13497e77f4a8c3d4257eb98c92fa3f > > Diff: https://reviews.apache.org/r/49839/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
