Re: Review Request 50128: Overloaded the << operator for 'Docker::Device'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 十一月 7, 2016, 1:55 p.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Summary (updated) - Overloaded the << operator for 'Docker::Device'. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description (updated) --- This patch overloaded the << operator for 'Docker::Device'. With such overload, we can just run the global `stringify()` function to turn 'Docker::Device' into a string. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e Diff: https://reviews.apache.org/r/50128/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50128: Overloaded the << operator for 'Docker::Device'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 十一月 7, 2016, 2:03 p.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This patch overloaded the << operator for 'Docker::Device'. With such overload, we can just run the global `stringify()` function to turn 'Docker::Device' into a string. Diffs - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e Diff: https://reviews.apache.org/r/50128/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50128: Overloaded the << operator for 'Docker::Device'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated Nov. 10, 2016, 8:13 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description --- This patch overloaded the << operator for 'Docker::Device'. With such overload, we can just run the global `stringify()` function to turn 'Docker::Device' into a string. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e Diff: https://reviews.apache.org/r/50128/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50128: Overloaded the << operator for `Docker::Device`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated Nov. 16, 2016, 3:25 a.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull. Summary (updated) - Overloaded the << operator for `Docker::Device`. Bugs: MESOS-5795 https://issues.apache.org/jira/browse/MESOS-5795 Repository: mesos Description (updated) --- This patch overloaded the `<<` operator for `Docker::Device`. With such overload, we can just run the global `stringify()` function to turn `Docker::Device` into a string. Diffs (updated) - src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e Diff: https://reviews.apache.org/r/50128/diff/ Testing --- make check Thanks, Yubo Li
Re: Review Request 50128: Overloaded the << operator for `Docker::Device`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review167469 --- Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Nov. 16, 2016, 3:25 a.m., Yubo Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50128/ > --- > > (Updated Nov. 16, 2016, 3:25 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > --- > > This patch overloaded the `<<` operator for `Docker::Device`. > With such overload, we can just run the global `stringify()` > function to turn `Docker::Device` into a string. > > > Diffs > - > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e > > > Diff: https://reviews.apache.org/r/50128/diff/24/ > > > Testing > --- > > make check > > > Thanks, > > Yubo Li > >
