Re: Review Request 50637: Added id to the libprocess Sequence constructor.

2016-08-03 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50637/#review144606
---


Ship it!




Ship It!

- Alexander Rukletsov


On Aug. 2, 2016, 1:42 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50637/
> ---
> 
> (Updated Aug. 2, 2016, 1:42 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5917
> https://issues.apache.org/jira/browse/MESOS-5917
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Sequence IDs used to follow the following schema; "(1)", "(2)", etc.
> This made it very hard to match the output from logging or the
> "__processes__" endpoint to them.
> 
> This change makes it possible to give sequence processes a
> distinguishable ID.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/sequence.hpp 
> 78ccdb95422d0f7e12f1d66b4456c4f0014f4ffe 
> 
> Diff: https://reviews.apache.org/r/50637/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>



Re: Review Request 50637: Added id to the libprocess Sequence constructor.

2016-08-02 Thread Gastón Kleiman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50637/
---

(Updated Aug. 2, 2016, 1:42 p.m.)


Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-5917
https://issues.apache.org/jira/browse/MESOS-5917


Repository: mesos


Description
---

Sequence IDs used to follow the following schema; "(1)", "(2)", etc.
This made it very hard to match the output from logging or the
"__processes__" endpoint to them.

This change makes it possible to give sequence processes a
distinguishable ID.


Diffs (updated)
-

  3rdparty/libprocess/include/process/sequence.hpp 
78ccdb95422d0f7e12f1d66b4456c4f0014f4ffe 

Diff: https://reviews.apache.org/r/50637/diff/


Testing
---

make check


Thanks,

Gastón Kleiman



Re: Review Request 50637: Added id to the libprocess Sequence constructor.

2016-08-02 Thread Gastón Kleiman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50637/
---

(Updated Aug. 2, 2016, 1:29 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Rebased.


Bugs: MESOS-5917
https://issues.apache.org/jira/browse/MESOS-5917


Repository: mesos


Description
---

Sequence IDs used to follow the following schema; "(1)", "(2)", etc.
This made it very hard to match the output from logging or the
"__processes__" endpoint to them.

This change makes it possible to give sequence processes a
distinguishable ID.


Diffs (updated)
-

  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
497f6107567ef47c16a0c906238bc7dfdcf84701 
  3rdparty/libprocess/include/process/sequence.hpp 
78ccdb95422d0f7e12f1d66b4456c4f0014f4ffe 
  CHANGELOG f720f0ec36825ec2c51a1e682fd25ed1a7224052 
  include/mesos/resources.hpp 829f39d7c1af3eb4e2efd97e01f87acf7c854bb4 
  include/mesos/v1/resources.hpp f3c5f315c3701e37aeb8fd468ee288829461338e 
  src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
  src/cli/CMakeLists.txt c0120cd7f4ef8dc275edbd5cb1a4a6e23952ec63 
  src/common/resources.cpp 309b17626d33bc6b4df07f002b0eea4f4803b3e5 
  src/local/CMakeLists.txt 643a6cf653d91b8a606ac83b126dfd2245fa49bd 
  src/master/validation.cpp f8343768f3dc803e6bd7f4253c77d9fef82408e5 
  src/slave/CMakeLists.txt 33120ace79bce449329a7cc4b7ef264d2867fc13 
  src/slave/cmake/SlaveConfigure.cmake b339239761a5de321d65b92376dae69c339bee5c 
  src/slave/containerizer/containerizer.cpp 
ba3b3f62fe0cf755fdbebf52350d9069cb2efca8 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
8814299e5c1efa857cdc78759f422a2e4e94e9b0 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
c304e2a896d1d8ae085914c0fd7e6326fd68ad2d 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
d10c424b48cb2ff974c49f91dd75805859ec39ef 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
0a85935550e36c9142d845465cfa70a1634a647a 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
ed7366aeeed6646b74f2087fd00449c70dd16e82 
  src/slave/containerizer/mesos/isolators/gpu/volume.cpp 
478e106cdaa025af92117f14be91ec9e1c70425b 
  src/slave/containerizer/mesos/launch.cpp 
e1cf9d5226ca4b4b33d8f9d9efb968be35d4ec4d 
  src/tests/CMakeLists.txt 1ea8b2102753ae294bd75706ffaf08308e928acd 
  src/tests/cmake/MesosTestsConfigure.cmake 
361032082c3a5f76b949dc7981f75b53e02d84f5 
  src/tests/containerizer/CMakeLists.txt 
2c52e43a9deee90fa32693731d6ebedb5201bb1f 
  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
fea1f9f0a03373692ef2a6dd2bc5722dc6f46d5b 
  src/tests/hierarchical_allocator_tests.cpp 
cbed333f497016fe2811f755028796012b41db77 
  src/tests/mesos.hpp 9174a3810d0da34b99dc257e9c77f83107fdd9f5 
  src/tests/resources_tests.cpp 54eaabd7639d310dffbceee1af0f18c901c39865 
  src/v1/resources.cpp 3f67e32519600a22f07a66ebfe05a7b647cb2c61 

Diff: https://reviews.apache.org/r/50637/diff/


Testing
---

make check


Thanks,

Gastón Kleiman



Re: Review Request 50637: Added id to the libprocess Sequence constructor.

2016-07-31 Thread Gastón Kleiman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50637/
---

(Updated July 31, 2016, 11:13 a.m.)


Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-5917
https://issues.apache.org/jira/browse/MESOS-5917


Repository: mesos


Description
---

Sequence IDs used to follow the following schema; "(1)", "(2)", etc.
This made it very hard to match the output from logging or the
"__processes__" endpoint to them.

This change makes it possible to give sequence processes a
distinguishable ID.


Diffs
-

  3rdparty/libprocess/include/process/sequence.hpp 
78ccdb95422d0f7e12f1d66b4456c4f0014f4ffe 

Diff: https://reviews.apache.org/r/50637/diff/


Testing
---

make check


Thanks,

Gastón Kleiman