Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-13 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/
---

(Updated Oct. 13, 2016, 6:37 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-6283
https://issues.apache.org/jira/browse/MESOS-6283


Repository: mesos


Description
---

For the task launched by default-executor, its sandbox directory is
'executor_directory/tasks/task_id/'. This patch generates the
corresponding sandbox directory in Web UI for the task according to its
executor type.


Diffs (updated)
-

  src/webui/master/static/agent_executor.html 
8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
  src/webui/master/static/framework.html 
bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
  src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
  src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
  src/webui/master/static/js/controllers.js 
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 

Diff: https://reviews.apache.org/r/52471/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-12 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/
---

(Updated Oct. 12, 2016, 5:18 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-6283
https://issues.apache.org/jira/browse/MESOS-6283


Repository: mesos


Description
---

For the task launched by default-executor, its sandbox directory is
'executor_directory/tasks/task_id/'. This patch generates the
corresponding sandbox directory in Web UI for the task according to its
executor type.


Diffs (updated)
-

  src/webui/master/static/agent_executor.html 
8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
  src/webui/master/static/framework.html 
bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
  src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
  src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
  src/webui/master/static/js/controllers.js 
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 

Diff: https://reviews.apache.org/r/52471/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-12 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/
---

(Updated Oct. 12, 2016, 9:32 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-6283
https://issues.apache.org/jira/browse/MESOS-6283


Repository: mesos


Description
---

For the task launched by default-executor, its sandbox directory is
'executor_directory/tasks/task_id/'. This patch generates the
corresponding sandbox directory in Web UI for the task according to its
executor type.


Diffs (updated)
-

  src/webui/master/static/agent_executor.html 
8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
  src/webui/master/static/framework.html 
bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
  src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
  src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
  src/webui/master/static/js/controllers.js 
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 

Diff: https://reviews.apache.org/r/52471/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-12 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/
---

(Updated Oct. 12, 2016, 9:29 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-6283
https://issues.apache.org/jira/browse/MESOS-6283


Repository: mesos


Description
---

For the task launched by default-executor, its sandbox directory is
'executor_directory/tasks/task_id/'. This patch generates the
corresponding sandbox directory in Web UI for the task according to its
executor type.


Diffs (updated)
-

  src/webui/master/static/agent_executor.html 
8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
  src/webui/master/static/framework.html 
bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
  src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
  src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
  src/webui/master/static/js/controllers.js 
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 

Diff: https://reviews.apache.org/r/52471/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-11 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/
---

(Updated Oct. 11, 2016, 6:07 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-6283
https://issues.apache.org/jira/browse/MESOS-6283


Repository: mesos


Description
---

For the task launched by default-executor, its sandbox directory is
'executor_directory/tasks/task_id/'. This patch generates the
corresponding sandbox directory in Web UI for the task according to its
executor type.


Diffs (updated)
-

  src/webui/master/static/agent_executor.html 
8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
  src/webui/master/static/framework.html 
bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
  src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
  src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
  src/webui/master/static/js/controllers.js 
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 

Diff: https://reviews.apache.org/r/52471/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/#review151926
---



Patch looks great!

Reviews applied: [52470, 52520, 52471]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 8, 2016, 12:20 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52471/
> ---
> 
> (Updated Oct. 8, 2016, 12:20 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6283
> https://issues.apache.org/jira/browse/MESOS-6283
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the task launched by default-executor, its sandbox directory is
> 'executor_directory/tasks/task_id/'. This patch generates the
> corresponding sandbox directory in Web UI for the task according to its
> executor type.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent_executor.html 
> 8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
>   src/webui/master/static/framework.html 
> bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
>   src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
>   src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
>   src/webui/master/static/js/controllers.js 
> 29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 
> 
> Diff: https://reviews.apache.org/r/52471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-08 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/
---

(Updated Oct. 8, 2016, 12:20 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-6283
https://issues.apache.org/jira/browse/MESOS-6283


Repository: mesos


Description
---

For the task launched by default-executor, its sandbox directory is
'executor_directory/tasks/task_id/'. This patch generates the
corresponding sandbox directory in Web UI for the task according to its
executor type.


Diffs (updated)
-

  src/webui/master/static/agent_executor.html 
8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
  src/webui/master/static/framework.html 
bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
  src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
  src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
  src/webui/master/static/js/controllers.js 
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 

Diff: https://reviews.apache.org/r/52471/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-08 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/
---

(Updated Oct. 8, 2016, 6:11 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

address @vinodkone's comments.


Bugs: MESOS-6283
https://issues.apache.org/jira/browse/MESOS-6283


Repository: mesos


Description
---

For the task launched by default-executor, its sandbox directory is
'executor_directory/tasks/task_id/'. This patch generates the
corresponding sandbox directory in Web UI for the task according to its
executor type.


Diffs (updated)
-

  src/webui/master/static/agent_executor.html 
8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
  src/webui/master/static/framework.html 
bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
  src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
  src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
  src/webui/master/static/js/controllers.js 
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 

Diff: https://reviews.apache.org/r/52471/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-08 Thread haosdent huang 


> On Oct. 7, 2016, 7:33 p.m., Vinod Kone wrote:
> > src/webui/master/static/js/controllers.js, line 58
> > 
> >
> > s/===/==/ ?

In javascript, we prefer `===` instead of `==`, because `==` may true when they 
are not different.

```
grep -c ' === ' src/webui/master/static/js/controllers.js
12

grep -c ' == ' src/webui/master/static/js/controllers.js
1
```


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/#review151854
---


On Oct. 7, 2016, 6:09 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52471/
> ---
> 
> (Updated Oct. 7, 2016, 6:09 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6283
> https://issues.apache.org/jira/browse/MESOS-6283
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the task launched by default-executor, its sandbox directory is
> 'executor_directory/tasks/task_id/'. This patch generates the
> corresponding sandbox directory in Web UI for the task according to its
> executor type.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent_executor.html 
> 8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
>   src/webui/master/static/framework.html 
> bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
>   src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
>   src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
>   src/webui/master/static/js/controllers.js 
> 29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 
> 
> Diff: https://reviews.apache.org/r/52471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-07 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/#review151854
---


Fix it, then Ship it!





src/webui/master/static/js/app.js (line 43)


s/AgentSandbox/AgentTaskAndExecutor/



src/webui/master/static/js/app.js (line 45)


s/AgentSandbox/AgentTaskAndExecutor/



src/webui/master/static/js/controllers.js (line 58)


s/===/==/ ?



src/webui/master/static/js/controllers.js (line 745)


s/task or the executor/executor or the task respectively/


- Vinod Kone


On Oct. 7, 2016, 6:09 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52471/
> ---
> 
> (Updated Oct. 7, 2016, 6:09 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6283
> https://issues.apache.org/jira/browse/MESOS-6283
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the task launched by default-executor, its sandbox directory is
> 'executor_directory/tasks/task_id/'. This patch generates the
> corresponding sandbox directory in Web UI for the task according to its
> executor type.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent_executor.html 
> 8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
>   src/webui/master/static/framework.html 
> bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
>   src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
>   src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
>   src/webui/master/static/js/controllers.js 
> 29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 
> 
> Diff: https://reviews.apache.org/r/52471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-07 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/
---

(Updated Oct. 7, 2016, 6:09 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-6283
https://issues.apache.org/jira/browse/MESOS-6283


Repository: mesos


Description
---

For the task launched by default-executor, its sandbox directory is
'executor_directory/tasks/task_id/'. This patch generates the
corresponding sandbox directory in Web UI for the task according to its
executor type.


Diffs (updated)
-

  src/webui/master/static/agent_executor.html 
8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
  src/webui/master/static/framework.html 
bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
  src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
  src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
  src/webui/master/static/js/controllers.js 
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 

Diff: https://reviews.apache.org/r/52471/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-04 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/#review151458
---



Patch looks great!

Reviews applied: [52470, 52520, 52471]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 4, 2016, 6:02 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52471/
> ---
> 
> (Updated Oct. 4, 2016, 6:02 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6283
> https://issues.apache.org/jira/browse/MESOS-6283
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the task launched by default-executor, its sandbox directory is
> 'executor_directory/tasks/task_id/'. This patch generates the
> corresponding sandbox directory in Web UI for the task according to its
> executor type.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent_executor.html 
> 8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
>   src/webui/master/static/framework.html 
> bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
>   src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
>   src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
>   src/webui/master/static/js/controllers.js 
> 29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 
> 
> Diff: https://reviews.apache.org/r/52471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-04 Thread haosdent huang 


> On Oct. 3, 2016, 10:35 p.m., Vinod Kone wrote:
> > src/webui/master/static/js/app.js, line 42
> > 
> >
> > Is this backwards compatible? What if some one is depending on this 
> > path to exist? Morever, I think it's worthwhile for people to have access 
> > to executor sandbox through the WebUI.
> > 
> > Maybe we should keep AgetExecutorRerouteCtrl and add a new 
> > AgentTaskRerouterCtrl.
> 
> haosdent huang wrote:
> Hi, @vinod Thanks for your reviews!
> 
> > Is this backwards compatible?
> 
> Yes, it is backwards compatible. Suppose user uses the old version 
> javascript, here it could not find the type of the executor, so it would 
> enter the directory of the executor. And if user uses the new version 
> javascript, it would enter correspoding directory according to the type of 
> the executor.
> 
> > What if some one is depending on this path to exist?
> 
> All the dependencies on this url have been updated. We only use this to 
> enter the sandbox of the task. For executor, we use `executor.directory` 
> directly instead of use `AgetExecutorRerouteCtrl`.
> 
> > Morever, I think it's worthwhile for people to have access to executor 
> sandbox through the WebUI.
> 
> Currently we need to access the sandbox of the executor in 
> `agent_executor.html`. And in that page, we use `executor.directory` which 
> get from the `/state` of the agent and avoid to use the reroute trick here.
> 
> > Maybe we should keep AgetExecutorRerouteCtrl and add a new 
> AgentTaskRerouterCtrl.
> 
> Because `AgetExecutorRerouteCtrl` is not used anymore, I prefer to remove 
> it. However, if we plan to show executors in `home.html`, keep 
> `AgetExecutorRerouteCtrl` would be useful so that we don't need to add it 
> back at that time.
> 
> Vinod Kone wrote:
> What I meant by "someone depending on the path" is whether someother 
> service/tool (outside of the WebUI javascript) is using the path. For example 
> Aurora or Marathon or DC/OS.

Good point! Let me keep the old one.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/#review151236
---


On Oct. 4, 2016, 6:02 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52471/
> ---
> 
> (Updated Oct. 4, 2016, 6:02 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6283
> https://issues.apache.org/jira/browse/MESOS-6283
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the task launched by default-executor, its sandbox directory is
> 'executor_directory/tasks/task_id/'. This patch generates the
> corresponding sandbox directory in Web UI for the task according to its
> executor type.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent_executor.html 
> 8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
>   src/webui/master/static/framework.html 
> bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
>   src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
>   src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
>   src/webui/master/static/js/controllers.js 
> 29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 
> 
> Diff: https://reviews.apache.org/r/52471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-04 Thread Vinod Kone 


> On Oct. 3, 2016, 10:35 p.m., Vinod Kone wrote:
> > src/webui/master/static/js/app.js, line 42
> > 
> >
> > Is this backwards compatible? What if some one is depending on this 
> > path to exist? Morever, I think it's worthwhile for people to have access 
> > to executor sandbox through the WebUI.
> > 
> > Maybe we should keep AgetExecutorRerouteCtrl and add a new 
> > AgentTaskRerouterCtrl.
> 
> haosdent huang wrote:
> Hi, @vinod Thanks for your reviews!
> 
> > Is this backwards compatible?
> 
> Yes, it is backwards compatible. Suppose user uses the old version 
> javascript, here it could not find the type of the executor, so it would 
> enter the directory of the executor. And if user uses the new version 
> javascript, it would enter correspoding directory according to the type of 
> the executor.
> 
> > What if some one is depending on this path to exist?
> 
> All the dependencies on this url have been updated. We only use this to 
> enter the sandbox of the task. For executor, we use `executor.directory` 
> directly instead of use `AgetExecutorRerouteCtrl`.
> 
> > Morever, I think it's worthwhile for people to have access to executor 
> sandbox through the WebUI.
> 
> Currently we need to access the sandbox of the executor in 
> `agent_executor.html`. And in that page, we use `executor.directory` which 
> get from the `/state` of the agent and avoid to use the reroute trick here.
> 
> > Maybe we should keep AgetExecutorRerouteCtrl and add a new 
> AgentTaskRerouterCtrl.
> 
> Because `AgetExecutorRerouteCtrl` is not used anymore, I prefer to remove 
> it. However, if we plan to show executors in `home.html`, keep 
> `AgetExecutorRerouteCtrl` would be useful so that we don't need to add it 
> back at that time.

What I meant by "someone depending on the path" is whether someother 
service/tool (outside of the WebUI javascript) is using the path. For example 
Aurora or Marathon or DC/OS.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/#review151236
---


On Oct. 4, 2016, 6:02 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52471/
> ---
> 
> (Updated Oct. 4, 2016, 6:02 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6283
> https://issues.apache.org/jira/browse/MESOS-6283
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the task launched by default-executor, its sandbox directory is
> 'executor_directory/tasks/task_id/'. This patch generates the
> corresponding sandbox directory in Web UI for the task according to its
> executor type.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent_executor.html 
> 8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
>   src/webui/master/static/framework.html 
> bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
>   src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
>   src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
>   src/webui/master/static/js/controllers.js 
> 29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 
> 
> Diff: https://reviews.apache.org/r/52471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-04 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/
---

(Updated Oct. 4, 2016, 6:02 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Fix @vinodkone's comments.


Bugs: MESOS-6283
https://issues.apache.org/jira/browse/MESOS-6283


Repository: mesos


Description (updated)
---

For the task launched by default-executor, its sandbox directory is
'executor_directory/tasks/task_id/'. This patch generates the
corresponding sandbox directory in Web UI for the task according to its
executor type.


Diffs (updated)
-

  src/webui/master/static/agent_executor.html 
8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
  src/webui/master/static/framework.html 
bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
  src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
  src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
  src/webui/master/static/js/controllers.js 
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 

Diff: https://reviews.apache.org/r/52471/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-03 Thread haosdent huang 


> On Oct. 3, 2016, 10:35 p.m., Vinod Kone wrote:
> > src/webui/master/static/js/app.js, line 42
> > 
> >
> > Is this backwards compatible? What if some one is depending on this 
> > path to exist? Morever, I think it's worthwhile for people to have access 
> > to executor sandbox through the WebUI.
> > 
> > Maybe we should keep AgetExecutorRerouteCtrl and add a new 
> > AgentTaskRerouterCtrl.

Hi, @vinod Thanks for your reviews!

> Is this backwards compatible?

Yes, it is backwards compatible. Suppose user uses the old version javascript, 
here it could not find the type of the executor, so it would enter the 
directory of the executor. And if user uses the new version javascript, it 
would enter correspoding directory according to the type of the executor.

> What if some one is depending on this path to exist?

All the dependencies on this url have been updated. We only use this to enter 
the sandbox of the task. For executor, we use `executor.directory` directly 
instead of use `AgetExecutorRerouteCtrl`.

> Morever, I think it's worthwhile for people to have access to executor 
> sandbox through the WebUI.

Currently we need to access the sandbox of the executor in 
`agent_executor.html`. And in that page, we use `executor.directory` which get 
from the `/state` of the agent and avoid to use the reroute trick here.

> Maybe we should keep AgetExecutorRerouteCtrl and add a new 
> AgentTaskRerouterCtrl.

Because `AgetExecutorRerouteCtrl` is not used anymore, I prefer to remove it. 
However, if we plan to show executors in `home.html`, keep 
`AgetExecutorRerouteCtrl` would be useful so that we don't need to add it back 
at that time.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/#review151236
---


On Oct. 3, 2016, 2:56 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52471/
> ---
> 
> (Updated Oct. 3, 2016, 2:56 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6283
> https://issues.apache.org/jira/browse/MESOS-6283
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the task launched by default-executor, its sandbox directory is
> 'executor_directory/tasks/task_id/'. This patch adds a type to the
> state endpoints of agent and generates the corresponding sandbox
> directory for the task according to its executor type in Web UI.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp 538330a4c780fbc2dfcdfb31537b0e75f368e3e0 
>   src/slave/http.cpp bdafe1db9f1b22ac0761f5119e73f87b531c6a3c 
>   src/webui/master/static/agent_executor.html 
> 8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
>   src/webui/master/static/framework.html 
> bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
>   src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
>   src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
>   src/webui/master/static/js/controllers.js 
> 29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 
> 
> Diff: https://reviews.apache.org/r/52471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-03 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/#review151245
---



Patch looks great!

Reviews applied: [52470, 52471]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 3, 2016, 2:56 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52471/
> ---
> 
> (Updated Oct. 3, 2016, 2:56 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6283
> https://issues.apache.org/jira/browse/MESOS-6283
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the task launched by default-executor, its sandbox directory is
> 'executor_directory/tasks/task_id/'. This patch adds a type to the
> state endpoints of agent and generates the corresponding sandbox
> directory for the task according to its executor type in Web UI.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp 538330a4c780fbc2dfcdfb31537b0e75f368e3e0 
>   src/slave/http.cpp bdafe1db9f1b22ac0761f5119e73f87b531c6a3c 
>   src/webui/master/static/agent_executor.html 
> 8b83ed5acc2ecd56f20b1571878ec9f6794efbd2 
>   src/webui/master/static/framework.html 
> bc3c56adf22030e6cd1dcd8a2c945d44ff79aa4b 
>   src/webui/master/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7 
>   src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7 
>   src/webui/master/static/js/controllers.js 
> 29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 
> 
> Diff: https://reviews.apache.org/r/52471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>