Re: Review Request 52765: Populated `recovered_slaves` in `/state` and `/slaves` endpoints.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52765/#review160199
---


Ship it!




Ship It!

- Anand Mazumdar


On Dec. 14, 2016, 4:48 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52765/
> ---
> 
> (Updated Dec. 14, 2016, 4:48 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.
> 
> 
> Bugs: MESOS-6177
> https://issues.apache.org/jira/browse/MESOS-6177
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Populated `recovered_slaves` in `/state` and `/slaves` endpoints.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp d52806dcf8e4d64ebb98e191a01408c0fcae17ac 
>   src/tests/master_tests.cpp b3b5630899082a69119d2cccb6460766d1352963 
> 
> Diff: https://reviews.apache.org/r/52765/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 52765: Populated `recovered_slaves` in `/state` and `/slaves` endpoints.

[Zhitao Li]

> On Dec. 12, 2016, 10:11 p.m., Anand Mazumdar wrote:
> > src/master/http.cpp, line 158
> > 
> >
> > Any reason for not adding `port` here?

It was never added in the past. I will add it in this patch.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52765/#review158902
---


On Dec. 14, 2016, 4:48 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52765/
> ---
> 
> (Updated Dec. 14, 2016, 4:48 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.
> 
> 
> Bugs: MESOS-6177
> https://issues.apache.org/jira/browse/MESOS-6177
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Populated `recovered_slaves` in `/state` and `/slaves` endpoints.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp d52806dcf8e4d64ebb98e191a01408c0fcae17ac 
>   src/tests/master_tests.cpp b3b5630899082a69119d2cccb6460766d1352963 
> 
> Diff: https://reviews.apache.org/r/52765/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 52765: Populated `recovered_slaves` in `/state` and `/slaves` endpoints.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52765/
---

(Updated Dec. 14, 2016, 4:48 a.m.)


Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.


Changes
---

- Skip resources since it may not reflect checkpointed resources;
- Add port;
- comment fix.


Bugs: MESOS-6177
https://issues.apache.org/jira/browse/MESOS-6177


Repository: mesos


Description
---

Populated `recovered_slaves` in `/state` and `/slaves` endpoints.


Diffs (updated)
-

  src/master/http.cpp d52806dcf8e4d64ebb98e191a01408c0fcae17ac 
  src/tests/master_tests.cpp b3b5630899082a69119d2cccb6460766d1352963 

Diff: https://reviews.apache.org/r/52765/diff/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 52765: Populated `recovered_slaves` in `/state` and `/slaves` endpoints.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52765/#review159082
---




src/master/http.cpp (line 160)


One thing I just noticed here is that the `resources` may not reflect the 
actual resources state of the slave, due to checkpointed dynamic reservation 
etc.

I'm proposing to drop this field from responses in `recovered_slaves`, to 
avoid confusion.

What do you think?


- Zhitao Li


On Nov. 2, 2016, 4:42 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52765/
> ---
> 
> (Updated Nov. 2, 2016, 4:42 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.
> 
> 
> Bugs: MESOS-6177
> https://issues.apache.org/jira/browse/MESOS-6177
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Populated `recovered_slaves` in `/state` and `/slaves` endpoints.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 2f275f6c78b92e13bd7d38043b581b5a3555ee40 
>   src/tests/master_tests.cpp ce42a106e8c671c9eaddb85d45153f31e0b9a488 
> 
> Diff: https://reviews.apache.org/r/52765/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 52765: Populated `recovered_slaves` in `/state` and `/slaves` endpoints.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52765/#review158902
---



Sorry for the delay on this.

As per our offline discussion, can you also make the `Summary&` helper 
use the new writer overload you added in a separate patch?


src/master/http.cpp (line 158)


Any reason for not adding `port` here?



src/master/http.cpp (line 2309)


Let's keep the same comment here as you have on L2688 later


- Anand Mazumdar


On Nov. 2, 2016, 4:42 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52765/
> ---
> 
> (Updated Nov. 2, 2016, 4:42 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.
> 
> 
> Bugs: MESOS-6177
> https://issues.apache.org/jira/browse/MESOS-6177
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Populated `recovered_slaves` in `/state` and `/slaves` endpoints.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 2f275f6c78b92e13bd7d38043b581b5a3555ee40 
>   src/tests/master_tests.cpp ce42a106e8c671c9eaddb85d45153f31e0b9a488 
> 
> Diff: https://reviews.apache.org/r/52765/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 52765: Populated `recovered_slaves` in `/state` and `/slaves` endpoints.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52765/
---

(Updated Nov. 2, 2016, 4:42 p.m.)


Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.


Changes
---

Fix broken test by this change.


Bugs: MESOS-6177
https://issues.apache.org/jira/browse/MESOS-6177


Repository: mesos


Description
---

Populated `recovered_slaves` in `/state` and `/slaves` endpoints.


Diffs (updated)
-

  src/master/http.cpp 2f275f6c78b92e13bd7d38043b581b5a3555ee40 
  src/tests/master_tests.cpp ce42a106e8c671c9eaddb85d45153f31e0b9a488 

Diff: https://reviews.apache.org/r/52765/diff/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 52765: Populated `recovered_slaves` in `/state` and `/slaves` endpoints.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52765/
---

(Updated Nov. 1, 2016, 6:40 p.m.)


Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.


Bugs: MESOS-6177
https://issues.apache.org/jira/browse/MESOS-6177


Repository: mesos


Description
---

Populated `recovered_slaves` in `/state` and `/slaves` endpoints.


Diffs (updated)
-

  src/master/http.cpp 2f275f6c78b92e13bd7d38043b581b5a3555ee40 

Diff: https://reviews.apache.org/r/52765/diff/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 52765: Populated `recovered_slaves` in `/state` and `/slaves` endpoints.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52765/#review154424
---




src/master/http.cpp (line 2241)


"registered in this master"
"recovered from the registry"



src/master/http.cpp (line 2687)


Can we make this comment symmetric with the comment on 2680? ("Model all of 
the recovered slaves.")


- Neil Conway


On Nov. 1, 2016, 5:29 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52765/
> ---
> 
> (Updated Nov. 1, 2016, 5:29 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.
> 
> 
> Bugs: MESOS-6177
> https://issues.apache.org/jira/browse/MESOS-6177
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Populated `recovered_slaves` in `/state` and `/slaves` endpoints.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 2f275f6c78b92e13bd7d38043b581b5a3555ee40 
> 
> Diff: https://reviews.apache.org/r/52765/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 52765: Populated `recovered_slaves` in `/state` and `/slaves` endpoints.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52765/
---

(Updated Nov. 1, 2016, 5:29 p.m.)


Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.


Changes
---

Add to `/slaves` endpoint too.


Summary (updated)
-

Populated `recovered_slaves` in `/state` and `/slaves` endpoints.


Bugs: MESOS-6177
https://issues.apache.org/jira/browse/MESOS-6177


Repository: mesos


Description (updated)
---

Populated `recovered_slaves` in `/state` and `/slaves` endpoints.


Diffs (updated)
-

  src/master/http.cpp 2f275f6c78b92e13bd7d38043b581b5a3555ee40 

Diff: https://reviews.apache.org/r/52765/diff/


Testing
---


Thanks,

Zhitao Li