Re: Review Request 53053: Divided utils.hpp to utils.hpp and utils.cpp.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53053/
---

(Updated Nov. 1, 2016, 2:08 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-6360
https://issues.apache.org/jira/browse/MESOS-6360


Repository: mesos


Description
---

Divided utils.hpp to utils.hpp and utils.cpp.


Diffs (updated)
-

  src/Makefile.am c2f9e442182110d0b450d4824600a4a791f8cf27 
  src/slave/containerizer/mesos/utils.hpp 
178ebf3effac824e4788d7282795c18dc1cb5265 
  src/slave/containerizer/mesos/utils.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/53053/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 53053: Divided utils.hpp to utils.hpp and utils.cpp.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53053/#review154049
---


Ship it!




Ship It!

- Jie Yu


On Oct. 25, 2016, 3:43 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53053/
> ---
> 
> (Updated Oct. 25, 2016, 3:43 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6360
> https://issues.apache.org/jira/browse/MESOS-6360
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Divided utils.hpp to utils.hpp and utils.cpp.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 769e998d80fde17bcb1ee6c5091ce13a1ad16137 
>   src/slave/containerizer/mesos/utils.hpp 
> 178ebf3effac824e4788d7282795c18dc1cb5265 
>   src/slave/containerizer/mesos/utils.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53053/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 53053: Divided utils.hpp to utils.hpp and utils.cpp.

[Qian Zhang]

> On Oct. 24, 2016, 11:25 a.m., Avinash sridharan wrote:
> > src/slave/containerizer/mesos/utils.cpp, lines 25-38
> > 
> >
> > Any specific reason this change is part of this patch? We should 
> > probably have a separate patch for this change. Don't think it has anything 
> > to do with with whiteout conversion.
> > 
> > Also, don't think we support nested containers on anything other than 
> > linux at this point

Agree, I have separated it.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53053/#review153655
---


On Oct. 25, 2016, 11:43 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53053/
> ---
> 
> (Updated Oct. 25, 2016, 11:43 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6360
> https://issues.apache.org/jira/browse/MESOS-6360
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Divided utils.hpp to utils.hpp and utils.cpp.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 769e998d80fde17bcb1ee6c5091ce13a1ad16137 
>   src/slave/containerizer/mesos/utils.hpp 
> 178ebf3effac824e4788d7282795c18dc1cb5265 
>   src/slave/containerizer/mesos/utils.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53053/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 53053: Divided utils.hpp to utils.hpp and utils.cpp.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53053/
---

(Updated Oct. 25, 2016, 11:43 a.m.)


Review request for mesos and Jie Yu.


Summary (updated)
-

Divided utils.hpp to utils.hpp and utils.cpp.


Bugs: MESOS-6360
https://issues.apache.org/jira/browse/MESOS-6360


Repository: mesos


Description (updated)
---

Divided utils.hpp to utils.hpp and utils.cpp.


Diffs (updated)
-

  src/Makefile.am 769e998d80fde17bcb1ee6c5091ce13a1ad16137 
  src/slave/containerizer/mesos/utils.hpp 
178ebf3effac824e4788d7282795c18dc1cb5265 
  src/slave/containerizer/mesos/utils.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/53053/diff/


Testing
---

make check


Thanks,

Qian Zhang