Re: Review Request 53606: Added `linux/seccomp` isolator.

2017-03-01 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53606/#review167493
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 25, 2016, 2:47 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53606/
> ---
> 
> (Updated Nov. 25, 2016, 2:47 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-6581
> https://issues.apache.org/jira/browse/MESOS-6581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `linux/seccomp` isolator.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am dd1626d177b38a6613f18f32bb0668abbb5100e0 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 9b33495d9babc3ee489a8712fe1977746c41043f 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/launch.hpp 
> 155e3c5a27b8c710971ee4b508600d3b5589a2e0 
>   src/slave/containerizer/mesos/launch.cpp 
> 320e42748adbabf09f77cb4f5951e2a7ea58fe64 
> 
> 
> Diff: https://reviews.apache.org/r/53606/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 53606: Added `linux/seccomp` isolator.

2016-11-28 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53606/#review157073
---




src/Makefile.am (line 1069)


Put it after

```
slave/containerizer/mesos/isolators/linux/capabilities.cpp
```



src/Makefile.am (line 1109)


Put it after 

```
slave/containerizer/mesos/isolators/linux/capabilities.hpp
```

and fix the indent here.



src/slave/containerizer/mesos/isolators/linux/seccomp.cpp (line 40)


For `TODO` items, the format is 

```
// TODO(jira_user): Message (The limit of line length is 72).
```

The following `TODO` items have these Nits:

* Miss `:`.
* Miss `.`.



src/slave/containerizer/mesos/isolators/linux/seccomp.cpp (line 46)


Ditto.



src/slave/containerizer/mesos/isolators/linux/seccomp.cpp (line 57)


Ditto.


- haosdent huang


On Nov. 25, 2016, 2:47 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53606/
> ---
> 
> (Updated Nov. 25, 2016, 2:47 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-6581
> https://issues.apache.org/jira/browse/MESOS-6581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `linux/seccomp` isolator.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am dd1626d177b38a6613f18f32bb0668abbb5100e0 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 9b33495d9babc3ee489a8712fe1977746c41043f 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/linux/seccomp.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/launch.hpp 
> 155e3c5a27b8c710971ee4b508600d3b5589a2e0 
>   src/slave/containerizer/mesos/launch.cpp 
> 320e42748adbabf09f77cb4f5951e2a7ea58fe64 
> 
> Diff: https://reviews.apache.org/r/53606/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 53606: Added `linux/seccomp` isolator.

2016-11-25 Thread Jay Guo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53606/
---

(Updated Nov. 25, 2016, 2:47 p.m.)


Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.


Changes
---

rebase


Bugs: MESOS-6581
https://issues.apache.org/jira/browse/MESOS-6581


Repository: mesos


Description
---

Added `linux/seccomp` isolator.


Diffs (updated)
-

  src/Makefile.am dd1626d177b38a6613f18f32bb0668abbb5100e0 
  src/slave/containerizer/mesos/containerizer.cpp 
9b33495d9babc3ee489a8712fe1977746c41043f 
  src/slave/containerizer/mesos/isolators/linux/seccomp.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/linux/seccomp.cpp PRE-CREATION 
  src/slave/containerizer/mesos/launch.hpp 
155e3c5a27b8c710971ee4b508600d3b5589a2e0 
  src/slave/containerizer/mesos/launch.cpp 
320e42748adbabf09f77cb4f5951e2a7ea58fe64 

Diff: https://reviews.apache.org/r/53606/diff/


Testing
---


Thanks,

Jay Guo