Re: Review Request 53954: Made Zk error message more accurate.

2016-11-24 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53954/#review156833
---


Fix it, then Ship it!




I'll fix the outstanding issue and will commit it for you.


src/zookeeper/group.cpp (line 608)


This one as well


- Alexander Rukletsov


On Nov. 23, 2016, 4:32 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53954/
> ---
> 
> (Updated Nov. 23, 2016, 4:32 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If Zk node creation fails, we should report the full Zk path that we
> tried to create.
> 
> 
> Diffs
> -
> 
>   src/zookeeper/group.cpp 1df4b54883d451fe36f132af45f2f7c77f3f221b 
> 
> Diff: https://reviews.apache.org/r/53954/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 53954: Made Zk error message more accurate.

2016-11-23 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53954/#review156806
---



Patch looks great!

Reviews applied: [53954]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 23, 2016, 4:32 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53954/
> ---
> 
> (Updated Nov. 23, 2016, 4:32 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If Zk node creation fails, we should report the full Zk path that we
> tried to create.
> 
> 
> Diffs
> -
> 
>   src/zookeeper/group.cpp 1df4b54883d451fe36f132af45f2f7c77f3f221b 
> 
> Diff: https://reviews.apache.org/r/53954/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 53954: Made Zk error message more accurate.

2016-11-23 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53954/
---

(Updated Nov. 23, 2016, 4:32 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Constified more block-local variables, per review suggestion.


Repository: mesos


Description
---

If Zk node creation fails, we should report the full Zk path that we
tried to create.


Diffs (updated)
-

  src/zookeeper/group.cpp 1df4b54883d451fe36f132af45f2f7c77f3f221b 

Diff: https://reviews.apache.org/r/53954/diff/


Testing
---

`make check`


Thanks,

Neil Conway

Re: Review Request 53954: Made Zk error message more accurate.

2016-11-23 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53954/#review156748
---


Ship it!





src/zookeeper/group.cpp (line 604)


I would prepend that with `const`. On the other side, there are more local 
variables in this scope that are `const` in nature but are not marked so.

Please feel free to `const`-annotate all vars in this scope to stay locally 
consistent.


- Alexander Rukletsov


On Nov. 23, 2016, 4:03 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53954/
> ---
> 
> (Updated Nov. 23, 2016, 4:03 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If Zk node creation fails, we should report the full Zk path that we
> tried to create.
> 
> 
> Diffs
> -
> 
>   src/zookeeper/group.cpp 1df4b54883d451fe36f132af45f2f7c77f3f221b 
> 
> Diff: https://reviews.apache.org/r/53954/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>