Re: Review Request 53995: Added API handler for ATTACH_CONTAINER_OUTPUT.

2016-11-28 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53995/
---

(Updated Nov. 29, 2016, 6:11 a.m.)


Review request for mesos, Anand Mazumdar and Benjamin Mahler.


Changes
---

anand's. NNFR.


Bugs: MESOS-6473
https://issues.apache.org/jira/browse/MESOS-6473


Repository: mesos


Description
---

Added API handler for ATTACH_CONTAINER_OUTPUT.


Diffs (updated)
-

  src/internal/evolve.hpp e8b03c9f04b8a835f35ce7cb6cc44e3ecd799422 
  src/internal/evolve.cpp 23a515c0aa8c31e0789fab84830dae32574604bc 
  src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f 
  src/slave/slave.hpp 0cc105418bf4e35b604ebe412048237814e495fb 
  src/slave/validation.cpp b3d8bcd0f0855d2a0a96821900d996ba86e11578 
  src/tests/api_tests.cpp 8889e7807ecead736eaac3910332e86d594e8cec 

Diff: https://reviews.apache.org/r/53995/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 53995: Added API handler for ATTACH_CONTAINER_OUTPUT.

2016-11-28 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53995/#review157204
---


Fix it, then Ship it!





src/slave/http.cpp (line 2175)


argument by reference: `Future&`



src/tests/api_tests.cpp (line 31)


Remove this include?


- Anand Mazumdar


On Nov. 29, 2016, 5:38 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53995/
> ---
> 
> (Updated Nov. 29, 2016, 5:38 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6473
> https://issues.apache.org/jira/browse/MESOS-6473
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added API handler for ATTACH_CONTAINER_OUTPUT.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp e8b03c9f04b8a835f35ce7cb6cc44e3ecd799422 
>   src/internal/evolve.cpp 23a515c0aa8c31e0789fab84830dae32574604bc 
>   src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f 
>   src/slave/slave.hpp 0cc105418bf4e35b604ebe412048237814e495fb 
>   src/slave/validation.cpp b3d8bcd0f0855d2a0a96821900d996ba86e11578 
>   src/tests/api_tests.cpp 8889e7807ecead736eaac3910332e86d594e8cec 
> 
> Diff: https://reviews.apache.org/r/53995/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 53995: Added API handler for ATTACH_CONTAINER_OUTPUT.

2016-11-28 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53995/
---

(Updated Nov. 29, 2016, 5:38 a.m.)


Review request for mesos, Anand Mazumdar and Benjamin Mahler.


Changes
---

anand's comments. thanks for the thorough review!

also, fixed the content type of the response.


Bugs: MESOS-6473
https://issues.apache.org/jira/browse/MESOS-6473


Repository: mesos


Description
---

Added API handler for ATTACH_CONTAINER_OUTPUT.


Diffs (updated)
-

  src/internal/evolve.hpp e8b03c9f04b8a835f35ce7cb6cc44e3ecd799422 
  src/internal/evolve.cpp 23a515c0aa8c31e0789fab84830dae32574604bc 
  src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f 
  src/slave/slave.hpp 0cc105418bf4e35b604ebe412048237814e495fb 
  src/slave/validation.cpp b3d8bcd0f0855d2a0a96821900d996ba86e11578 
  src/tests/api_tests.cpp 8889e7807ecead736eaac3910332e86d594e8cec 

Diff: https://reviews.apache.org/r/53995/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 53995: Added API handler for ATTACH_CONTAINER_OUTPUT.

2016-11-28 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53995/#review157190
---



Patch looks great!

Reviews applied: [54048, 54093, 54039, 53994, 54049, 53995]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 28, 2016, 10:50 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53995/
> ---
> 
> (Updated Nov. 28, 2016, 10:50 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6473
> https://issues.apache.org/jira/browse/MESOS-6473
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added API handler for ATTACH_CONTAINER_OUTPUT.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp e8b03c9f04b8a835f35ce7cb6cc44e3ecd799422 
>   src/internal/evolve.cpp 23a515c0aa8c31e0789fab84830dae32574604bc 
>   src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f 
>   src/slave/slave.hpp 0cc105418bf4e35b604ebe412048237814e495fb 
>   src/slave/validation.cpp b3d8bcd0f0855d2a0a96821900d996ba86e11578 
>   src/tests/api_tests.cpp 8889e7807ecead736eaac3910332e86d594e8cec 
>   src/tests/containerizer/mock_containerizer.hpp 
> 7a30b8307b93b7bf549efb52d72367f652d0d95a 
> 
> Diff: https://reviews.apache.org/r/53995/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 53995: Added API handler for ATTACH_CONTAINER_OUTPUT.

2016-11-28 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53995/
---

(Updated Nov. 28, 2016, 10:50 p.m.)


Review request for mesos, Anand Mazumdar and Benjamin Mahler.


Changes
---

updated the diff per changs in the dependent reviews.


Bugs: MESOS-6473
https://issues.apache.org/jira/browse/MESOS-6473


Repository: mesos


Description
---

Added API handler for ATTACH_CONTAINER_OUTPUT.


Diffs (updated)
-

  src/internal/evolve.hpp e8b03c9f04b8a835f35ce7cb6cc44e3ecd799422 
  src/internal/evolve.cpp 23a515c0aa8c31e0789fab84830dae32574604bc 
  src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f 
  src/slave/slave.hpp 0cc105418bf4e35b604ebe412048237814e495fb 
  src/slave/validation.cpp b3d8bcd0f0855d2a0a96821900d996ba86e11578 
  src/tests/api_tests.cpp 8889e7807ecead736eaac3910332e86d594e8cec 
  src/tests/containerizer/mock_containerizer.hpp 
7a30b8307b93b7bf549efb52d72367f652d0d95a 

Diff: https://reviews.apache.org/r/53995/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 53995: Added API handler for ATTACH_CONTAINER_OUTPUT.

2016-11-26 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53995/#review156954
---



Patch looks great!

Reviews applied: [54048, 54093, 54039, 53994, 54049, 53995]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 26, 2016, 5:43 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53995/
> ---
> 
> (Updated Nov. 26, 2016, 5:43 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6473
> https://issues.apache.org/jira/browse/MESOS-6473
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added API handler for ATTACH_CONTAINER_OUTPUT.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp e8b03c9f04b8a835f35ce7cb6cc44e3ecd799422 
>   src/internal/evolve.cpp 23a515c0aa8c31e0789fab84830dae32574604bc 
>   src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f 
>   src/slave/slave.hpp 0cc105418bf4e35b604ebe412048237814e495fb 
>   src/slave/validation.cpp b3d8bcd0f0855d2a0a96821900d996ba86e11578 
>   src/tests/api_tests.cpp 8889e7807ecead736eaac3910332e86d594e8cec 
>   src/tests/containerizer/mock_containerizer.hpp 
> 7a30b8307b93b7bf549efb52d72367f652d0d95a 
> 
> Diff: https://reviews.apache.org/r/53995/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 53995: Added API handler for ATTACH_CONTAINER_OUTPUT.

2016-11-26 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53995/
---

(Updated Nov. 26, 2016, 5:43 p.m.)


Review request for mesos, Anand Mazumdar and Benjamin Mahler.


Bugs: MESOS-6473
https://issues.apache.org/jira/browse/MESOS-6473


Repository: mesos


Description
---

Added API handler for ATTACH_CONTAINER_OUTPUT.


Diffs (updated)
-

  src/internal/evolve.hpp e8b03c9f04b8a835f35ce7cb6cc44e3ecd799422 
  src/internal/evolve.cpp 23a515c0aa8c31e0789fab84830dae32574604bc 
  src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f 
  src/slave/slave.hpp 0cc105418bf4e35b604ebe412048237814e495fb 
  src/slave/validation.cpp b3d8bcd0f0855d2a0a96821900d996ba86e11578 
  src/tests/api_tests.cpp 8889e7807ecead736eaac3910332e86d594e8cec 
  src/tests/containerizer/mock_containerizer.hpp 
7a30b8307b93b7bf549efb52d72367f652d0d95a 

Diff: https://reviews.apache.org/r/53995/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 53995: Added API handler for ATTACH_CONTAINER_OUTPUT.

2016-11-23 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53995/
---

(Updated Nov. 23, 2016, 11:55 p.m.)


Review request for mesos, Anand Mazumdar and Benjamin Mahler.


Changes
---

rebased.


Bugs: MESOS-6473
https://issues.apache.org/jira/browse/MESOS-6473


Repository: mesos


Description
---

Added API handler for ATTACH_CONTAINER_OUTPUT.


Diffs (updated)
-

  src/internal/evolve.hpp e8b03c9f04b8a835f35ce7cb6cc44e3ecd799422 
  src/internal/evolve.cpp 23a515c0aa8c31e0789fab84830dae32574604bc 
  src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f 
  src/slave/slave.hpp 0cc105418bf4e35b604ebe412048237814e495fb 
  src/slave/validation.cpp b3d8bcd0f0855d2a0a96821900d996ba86e11578 
  src/tests/api_tests.cpp 8889e7807ecead736eaac3910332e86d594e8cec 
  src/tests/containerizer/mock_containerizer.hpp 
7a30b8307b93b7bf549efb52d72367f652d0d95a 

Diff: https://reviews.apache.org/r/53995/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 53995: Added API handler for ATTACH_CONTAINER_OUTPUT.

2016-11-22 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53995/#review156655
---



Patch looks great!

Reviews applied: [53994, 53995]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 22, 2016, 6:45 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53995/
> ---
> 
> (Updated Nov. 22, 2016, 6:45 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6473
> https://issues.apache.org/jira/browse/MESOS-6473
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added API handler for ATTACH_CONTAINER_OUTPUT.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f 
>   src/slave/slave.hpp 0cc105418bf4e35b604ebe412048237814e495fb 
>   src/slave/validation.cpp b3d8bcd0f0855d2a0a96821900d996ba86e11578 
>   src/tests/api_tests.cpp 8889e7807ecead736eaac3910332e86d594e8cec 
> 
> Diff: https://reviews.apache.org/r/53995/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>