Re: Review Request 54100: Removed two disabled shared filesystem isolator tests.

2016-11-28 Thread Kevin Klues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54100/#review157163
---


Ship it!




Ship It!

- Kevin Klues


On Nov. 27, 2016, 7:48 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54100/
> ---
> 
> (Updated Nov. 27, 2016, 7:48 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Kevin Klues.
> 
> 
> Bugs: MESOS-6648
> https://issues.apache.org/jira/browse/MESOS-6648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Shared filesystem isolator has been deprecated for a while, and those
> two tests are disabled all the time. This patch removes them.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 9766aaf144722b18d88f694ff37ffd53974cb60d 
> 
> Diff: https://reviews.apache.org/r/54100/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Re: Review Request 54100: Removed two disabled shared filesystem isolator tests.

2016-11-28 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54100/#review157081
---


Ship it!




Should we remove the shared filesystem isolator this time? (a deprecation cycle 
passed already).

- Gilbert Song


On Nov. 26, 2016, 11:48 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54100/
> ---
> 
> (Updated Nov. 26, 2016, 11:48 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Kevin Klues.
> 
> 
> Bugs: MESOS-6648
> https://issues.apache.org/jira/browse/MESOS-6648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Shared filesystem isolator has been deprecated for a while, and those
> two tests are disabled all the time. This patch removes them.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 9766aaf144722b18d88f694ff37ffd53974cb60d 
> 
> Diff: https://reviews.apache.org/r/54100/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>