Re: Review Request 55900: Improved style in `HealthChecker`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/#review164311 --- Ship it! Ship It! - haosdent huang On Feb. 2, 2017, 4:54 p.m., Gastón Kleiman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55900/ > --- > > (Updated Feb. 2, 2017, 4:54 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repository: mesos > > > Description > --- > > Marked `_taskPid` in the constructor as const, to be consistent with the > other parameters. > > > Diffs > - > > src/checks/health_checker.hpp 95da1ff7dd6b222a93076633eb3757ec9aa43cf6 > src/checks/health_checker.cpp 58380dc18896f659aa9c4fb4bb567a55bba97f6b > > Diff: https://reviews.apache.org/r/55900/diff/ > > > Testing > --- > > `make check` (macOS and Linux) > > > Thanks, > > Gastón Kleiman > >
Re: Review Request 55900: Improved style in `HealthChecker`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/ --- (Updated Feb. 2, 2017, 4:54 p.m.) Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone. Changes --- Rebased. Bugs: MESOS-6280 https://issues.apache.org/jira/browse/MESOS-6280 Repository: mesos Description --- Marked `_taskPid` in the constructor as const, to be consistent with the other parameters. Diffs (updated) - src/checks/health_checker.hpp 95da1ff7dd6b222a93076633eb3757ec9aa43cf6 src/checks/health_checker.cpp 58380dc18896f659aa9c4fb4bb567a55bba97f6b Diff: https://reviews.apache.org/r/55900/diff/ Testing --- `make check` (macOS and Linux) Thanks, Gastón Kleiman
Re: Review Request 55900: Improved style in `HealthChecker`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/#review163348 --- Ship it! Ship It! - Vinod Kone On Jan. 25, 2017, 6:15 p.m., Gastón Kleiman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55900/ > --- > > (Updated Jan. 25, 2017, 6:15 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repository: mesos > > > Description > --- > > Marked `_taskPid` in the constructor as const, to be consistent with the > other parameters. > > > Diffs > - > > src/checks/health_checker.hpp 6e558f2061a9e31157c47d31cb64b3a8568aace3 > src/checks/health_checker.cpp 50aa2858e807b27bbab58a3618f5200cfe4eca9e > > Diff: https://reviews.apache.org/r/55900/diff/ > > > Testing > --- > > `make check` (macOS and Linux) > > > Thanks, > > Gastón Kleiman > >
Re: Review Request 55900: Improved style in `HealthChecker`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/#review163250 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 25, 2017, 6:15 p.m., Gastón Kleiman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55900/ > --- > > (Updated Jan. 25, 2017, 6:15 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repository: mesos > > > Description > --- > > Marked `_taskPid` in the constructor as const, to be consistent with the > other parameters. > > > Diffs > - > > src/checks/health_checker.hpp 6e558f2061a9e31157c47d31cb64b3a8568aace3 > src/checks/health_checker.cpp 50aa2858e807b27bbab58a3618f5200cfe4eca9e > > Diff: https://reviews.apache.org/r/55900/diff/ > > > Testing > --- > > `make check` (macOS and Linux) > > > Thanks, > > Gastón Kleiman > >
Re: Review Request 55900: Improved style in `HealthChecker`.
> On Jan. 25, 2017, 6:09 p.m., haosdent huang wrote: > > I remember we have special reason to use `Option` here instead of `const > > Option&` in previous patches. @alex may remember that, or I > > missunderstanding something here? > > Gastón Kleiman wrote: > The parameter was introduced here: https://reviews.apache.org/r/51379/ > > I don't see this topic discussed in the review, so I'll let @alexr chime > in to see if he remembers something =). I don't remember anything specific. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/#review162982 --- On Jan. 25, 2017, 6:15 p.m., Gastón Kleiman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55900/ > --- > > (Updated Jan. 25, 2017, 6:15 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repository: mesos > > > Description > --- > > Marked `_taskPid` in the constructor as const, to be consistent with the > other parameters. > > > Diffs > - > > src/checks/health_checker.hpp 6e558f2061a9e31157c47d31cb64b3a8568aace3 > src/checks/health_checker.cpp 50aa2858e807b27bbab58a3618f5200cfe4eca9e > > Diff: https://reviews.apache.org/r/55900/diff/ > > > Testing > --- > > `make check` (macOS and Linux) > > > Thanks, > > Gastón Kleiman > >
Re: Review Request 55900: Improved style in `HealthChecker`.
> On Jan. 25, 2017, 6:09 p.m., haosdent huang wrote: > > I remember we have special reason to use `Option` here instead of `const > > Option&` in previous patches. @alex may remember that, or I > > missunderstanding something here? The parameter was introduced here: https://reviews.apache.org/r/51379/ I don't see this topic discussed in the review, so I'll let @alexr chime in to see if he remembers something =). - Gastón --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/#review162982 --- On Jan. 25, 2017, 6:15 p.m., Gastón Kleiman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55900/ > --- > > (Updated Jan. 25, 2017, 6:15 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repository: mesos > > > Description > --- > > Marked `_taskPid` in the constructor as const, to be consistent with the > other parameters. > > > Diffs > - > > src/checks/health_checker.hpp 6e558f2061a9e31157c47d31cb64b3a8568aace3 > src/checks/health_checker.cpp 50aa2858e807b27bbab58a3618f5200cfe4eca9e > > Diff: https://reviews.apache.org/r/55900/diff/ > > > Testing > --- > > `make check` (macOS and Linux) > > > Thanks, > > Gastón Kleiman > >
Re: Review Request 55900: Improved style in `HealthChecker`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/ --- (Updated Jan. 25, 2017, 6:15 p.m.) Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone. Bugs: MESOS-6280 https://issues.apache.org/jira/browse/MESOS-6280 Repository: mesos Description --- Marked `_taskPid` in the constructor as const, to be consistent with the other parameters. Diffs - src/checks/health_checker.hpp 6e558f2061a9e31157c47d31cb64b3a8568aace3 src/checks/health_checker.cpp 50aa2858e807b27bbab58a3618f5200cfe4eca9e Diff: https://reviews.apache.org/r/55900/diff/ Testing --- `make check` (macOS and Linux) Thanks, Gastón Kleiman
Re: Review Request 55900: Improved style in `HealthChecker`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/#review162982 --- I remember we have special reason to use `Option` here instead of `const Option&` in previous patches. @alex may remember that, or I missunderstanding something here? - haosdent huang On Jan. 25, 2017, 12:24 a.m., Gastón Kleiman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55900/ > --- > > (Updated Jan. 25, 2017, 12:24 a.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repository: mesos > > > Description > --- > > Marked `_taskPid` in the constructor as const, to be consistent with the > other parameters. > > > Diffs > - > > src/checks/health_checker.hpp 6e558f2061a9e31157c47d31cb64b3a8568aace3 > src/checks/health_checker.cpp 50aa2858e807b27bbab58a3618f5200cfe4eca9e > > Diff: https://reviews.apache.org/r/55900/diff/ > > > Testing > --- > > `make check` (macOS and Linux) > > > Thanks, > > Gastón Kleiman > >
