Re: Review Request 55943: Moved agent capabilities from SlaveInfo to (re-)registerSlaveMessage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55943/#review163156 --- Ship it! Ship It! - Benjamin Mahler On Jan. 26, 2017, 11:11 a.m., Jay Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55943/ > --- > > (Updated Jan. 26, 2017, 11:11 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > We want agents to be able to upgrade to support new capabilities after > reregistration, however we don't support udpating SlaveInfo yet. This > patch moves agent capabilities protobuf message from SlaveInfo to the > (re-)registerSlaveMessage so that capabilities are communicated through > the agent registration and re-registration. > > > Diffs > - > > include/mesos/mesos.proto 044b7e697f77c9e2cefb938bda4307d328b33766 > include/mesos/v1/mesos.proto 7706de89d91926aedb10e4c882dffcf050f03bb1 > src/messages/messages.proto 7cbac56099689ffc378d83bae3a16abb49b50dd9 > > Diff: https://reviews.apache.org/r/55943/diff/ > > > Testing > --- > > > Thanks, > > Jay Guo > >
Re: Review Request 55943: Moved agent capabilities from SlaveInfo to (re-)registerSlaveMessage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55943/ --- (Updated Jan. 26, 2017, 7:11 p.m.) Review request for mesos and Benjamin Mahler. Changes --- rebase Repository: mesos Description --- We want agents to be able to upgrade to support new capabilities after reregistration, however we don't support udpating SlaveInfo yet. This patch moves agent capabilities protobuf message from SlaveInfo to the (re-)registerSlaveMessage so that capabilities are communicated through the agent registration and re-registration. Diffs (updated) - include/mesos/mesos.proto 044b7e697f77c9e2cefb938bda4307d328b33766 include/mesos/v1/mesos.proto 7706de89d91926aedb10e4c882dffcf050f03bb1 src/messages/messages.proto 7cbac56099689ffc378d83bae3a16abb49b50dd9 Diff: https://reviews.apache.org/r/55943/diff/ Testing --- Thanks, Jay Guo
Re: Review Request 55943: Moved agent capabilities from SlaveInfo to (re-)registerSlaveMessage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55943/ --- (Updated Jan. 26, 2017, 12:39 p.m.) Review request for mesos and Benjamin Mahler. Changes --- Left `Capability` in `SlaveInfo` rather than creating `AgentCapability`. Repository: mesos Description --- We want agents to be able to upgrade to support new capabilities after reregistration, however we don't support udpating SlaveInfo yet. This patch moves agent capabilities protobuf message from SlaveInfo to the (re-)registerSlaveMessage so that capabilities are communicated through the agent registration and re-registration. Diffs (updated) - include/mesos/mesos.proto 044b7e697f77c9e2cefb938bda4307d328b33766 include/mesos/v1/mesos.proto 7706de89d91926aedb10e4c882dffcf050f03bb1 src/messages/messages.proto 7cbac56099689ffc378d83bae3a16abb49b50dd9 Diff: https://reviews.apache.org/r/55943/diff/ Testing --- Thanks, Jay Guo