Re: Review Request 55944: Modified agent capabilities struct to reflect protobuf changes.

2017-01-26 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55944/#review163159
---


Ship it!





src/master/master.hpp (lines 243 - 247)


It's a little odd that master was touched in this patch, should we put this 
in your next patch?


- Benjamin Mahler


On Jan. 26, 2017, 11:46 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55944/
> ---
> 
> (Updated Jan. 26, 2017, 11:46 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As agent capabilities are moved from SlaveInfo into Registration
> messages, this patch modifies the data structure to reflect that
> change.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp cb1b82d93919edf910bfbece8ef1a33cade9dc8b 
>   src/master/master.cpp 2432ed4844dcf52f26ef5b4132d5ad429d1b4317 
>   src/tests/protobuf_utils_tests.cpp 39604e99d684b018adfcb7d6adf1826a0cf1e22c 
> 
> Diff: https://reviews.apache.org/r/55944/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 55944: Modified agent capabilities struct to reflect protobuf changes.

2017-01-26 Thread Jay Guo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55944/
---

(Updated Jan. 26, 2017, 7:46 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

rebase


Repository: mesos


Description
---

As agent capabilities are moved from SlaveInfo into Registration
messages, this patch modifies the data structure to reflect that
change.


Diffs (updated)
-

  src/master/master.hpp cb1b82d93919edf910bfbece8ef1a33cade9dc8b 
  src/master/master.cpp 2432ed4844dcf52f26ef5b4132d5ad429d1b4317 
  src/tests/protobuf_utils_tests.cpp 39604e99d684b018adfcb7d6adf1826a0cf1e22c 

Diff: https://reviews.apache.org/r/55944/diff/


Testing
---


Thanks,

Jay Guo

Re: Review Request 55944: Modified agent capabilities struct to reflect protobuf changes.

2017-01-25 Thread Jay Guo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55944/
---

(Updated Jan. 26, 2017, 12:40 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Left `Capability` in `SlaveInfo` rather than creating `AgentCapability`.


Repository: mesos


Description
---

As agent capabilities are moved from SlaveInfo into Registration
messages, this patch modifies the data structure to reflect that
change.


Diffs (updated)
-

  src/common/protobuf_utils.hpp faa7e2a759fd2b1ce5def662679f573ec6fefd28 
  src/master/master.hpp cb1b82d93919edf910bfbece8ef1a33cade9dc8b 
  src/master/master.cpp 2432ed4844dcf52f26ef5b4132d5ad429d1b4317 
  src/tests/protobuf_utils_tests.cpp 39604e99d684b018adfcb7d6adf1826a0cf1e22c 

Diff: https://reviews.apache.org/r/55944/diff/


Testing
---


Thanks,

Jay Guo