Re: Review Request 57788: Changed allocator to skip allocation on weight and quota changes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57788/ --- (Updated April 11, 2017, 9:58 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and Michael Park. Changes --- Rebase? Repository: mesos Description --- Changing weight or quota will no longer trigger a batch allocation. Since the allocator does not rebalance currently offered resources to reflect changes to weight or quota, doing a batch allocation is not useful; instead, the updated quota/weight values will be reflected on the next allocation. Diffs (updated) - src/master/allocator/mesos/hierarchical.cpp 051f749dd5921a322ca930a042c31814616d38f9 src/tests/hierarchical_allocator_tests.cpp 33e7b455f8664858eb4f03727b076a10c80cd6e0 Diff: https://reviews.apache.org/r/57788/diff/3/ Changes: https://reviews.apache.org/r/57788/diff/2-3/ Testing --- `make check` Thanks, Neil Conway
Re: Review Request 57788: Changed allocator to skip allocation on weight and quota changes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57788/#review171538 --- Ship it! Ship It! - Adam B On March 22, 2017, 11:36 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57788/ > --- > > (Updated March 22, 2017, 11:36 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Bannier, > Benjamin Mahler, and Michael Park. > > > Repository: mesos > > > Description > --- > > Changing weight or quota will no longer trigger a batch allocation. > Since the allocator does not rebalance currently offered resources to > reflect changes to weight or quota, doing a batch allocation is not > useful; instead, the updated quota/weight values will be reflected on > the next allocation. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.cpp > 8d54a8cca1bb478f4437f68c5e14f66a9f9bb9e9 > src/tests/hierarchical_allocator_tests.cpp > e343dc37bd7136f0f6dd5dbc22a25cabe715038d > > > Diff: https://reviews.apache.org/r/57788/diff/2/ > > > Testing > --- > > `make check` > > > Thanks, > > Neil Conway > >
Re: Review Request 57788: Changed allocator to skip allocation on weight and quota changes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57788/#review170501 --- Ship it! Ship It! - Michael Park On March 22, 2017, 11:36 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57788/ > --- > > (Updated March 22, 2017, 11:36 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Bannier, > Benjamin Mahler, and Michael Park. > > > Repository: mesos > > > Description > --- > > Changing weight or quota will no longer trigger a batch allocation. > Since the allocator does not rebalance currently offered resources to > reflect changes to weight or quota, doing a batch allocation is not > useful; instead, the updated quota/weight values will be reflected on > the next allocation. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.cpp > 8d54a8cca1bb478f4437f68c5e14f66a9f9bb9e9 > src/tests/hierarchical_allocator_tests.cpp > e343dc37bd7136f0f6dd5dbc22a25cabe715038d > > > Diff: https://reviews.apache.org/r/57788/diff/2/ > > > Testing > --- > > `make check` > > > Thanks, > > Neil Conway > >
