Re: Review Request 58907: Refactored Docker containerizer launch path per interface changes.

2017-05-10 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58907/
---

(Updated May 10, 2017, 11:33 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Fix order of arguments in `Docker::Container::Create(...)`


Bugs: MESOS-7449
https://issues.apache.org/jira/browse/MESOS-7449


Repository: mesos


Description
---

This continues the containerizer interface change that replaced
most "Infos" (Task, Executor, Command, Container) with a single
`ContainerConfig` and combined the nested/non-nested container
launch paths.

Notably, this commit also changes the fields stored in the Docker
containerizer to match the new interface.  The somewhat ambiguously
named `directory` field has been renamed to `containerWorkDir`.
And the copy of `Slave::flags` in each container has been removed
because it is not used.


Diffs (updated)
-

  src/slave/containerizer/docker.hpp 44efa44586455df416fc9cdc51c92bd9027f24c3 
  src/slave/containerizer/docker.cpp 2480f595bee032ea399d642653d618472db0b7a7 


Diff: https://reviews.apache.org/r/58907/diff/2/

Changes: https://reviews.apache.org/r/58907/diff/1-2/


Testing
---

See last patch in chain.


Thanks,

Joseph Wu

Re: Review Request 58907: Refactored Docker containerizer launch path per interface changes.

2017-05-11 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58907/#review174653
---


Fix it, then Ship it!





src/slave/containerizer/docker.hpp
Lines 353-367 (original), 329 (patched)


Why remove the CHECK and the comment here?


- Jie Yu


On May 10, 2017, 6:33 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58907/
> ---
> 
> (Updated May 10, 2017, 6:33 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7449
> https://issues.apache.org/jira/browse/MESOS-7449
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This continues the containerizer interface change that replaced
> most "Infos" (Task, Executor, Command, Container) with a single
> `ContainerConfig` and combined the nested/non-nested container
> launch paths.
> 
> Notably, this commit also changes the fields stored in the Docker
> containerizer to match the new interface.  The somewhat ambiguously
> named `directory` field has been renamed to `containerWorkDir`.
> And the copy of `Slave::flags` in each container has been removed
> because it is not used.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 44efa44586455df416fc9cdc51c92bd9027f24c3 
>   src/slave/containerizer/docker.cpp 2480f595bee032ea399d642653d618472db0b7a7 
> 
> 
> Diff: https://reviews.apache.org/r/58907/diff/2/
> 
> 
> Testing
> ---
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 58907: Refactored Docker containerizer launch path per interface changes.

2017-05-19 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58907/
---

(Updated May 19, 2017, 3:15 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase and un-delete a validation check.


Bugs: MESOS-7449
https://issues.apache.org/jira/browse/MESOS-7449


Repository: mesos


Description
---

This continues the containerizer interface change that replaced
most "Infos" (Task, Executor, Command, Container) with a single
`ContainerConfig` and combined the nested/non-nested container
launch paths.

Notably, this commit also changes the fields stored in the Docker
containerizer to match the new interface.  The somewhat ambiguously
named `directory` field has been renamed to `containerWorkDir`.
And the copy of `Slave::flags` in each container has been removed
because it is not used.


Diffs (updated)
-

  src/slave/containerizer/docker.hpp 44efa44586455df416fc9cdc51c92bd9027f24c3 
  src/slave/containerizer/docker.cpp 2480f595bee032ea399d642653d618472db0b7a7 


Diff: https://reviews.apache.org/r/58907/diff/3/

Changes: https://reviews.apache.org/r/58907/diff/2-3/


Testing
---

See last patch in chain.


Thanks,

Joseph Wu