Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

2017-05-10 Thread Chun-Hung Hsiao 


> On May 10, 2017, 6:53 p.m., Chun-Hung Hsiao wrote:
> > src/slave/containerizer/mesos/provisioner/docker/puller.hpp
> > Lines 65 (patched)
> > 
> >
> > Do we need a default value here? It seems that all subclasses need to 
> > declare this virtual function anyway.

Forget about it lol. I made a mistake.


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59013/#review174527
---


On May 10, 2017, 12:47 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59013/
> ---
> 
> (Updated May 10, 2017, 12:47 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented passing Image::Secret Puller::pull().
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
> 344baab5c0365c3fc2dc814887bb2b48082b050f 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> 5bc68d2047a7b3e3fa30315d61073e342ba6affe 
>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
> 6dacdb1403433a37dd31a93d4ff2e37d4685eb87 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
> 62ddb7a332030f3116477408d8b16c19e434c159 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 4341621767a9fa5be2c66e77ef60f0c65dae58ca 
> 
> 
> Diff: https://reviews.apache.org/r/59013/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

2017-05-10 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59013/#review174527
---




src/slave/containerizer/mesos/provisioner/docker/puller.hpp
Lines 65 (patched)


Do we need a default value here? It seems that all subclasses need to 
declare this virtual function anyway.


- Chun-Hung Hsiao


On May 10, 2017, 12:47 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59013/
> ---
> 
> (Updated May 10, 2017, 12:47 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented passing Image::Secret Puller::pull().
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
> 344baab5c0365c3fc2dc814887bb2b48082b050f 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> 5bc68d2047a7b3e3fa30315d61073e342ba6affe 
>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
> 6dacdb1403433a37dd31a93d4ff2e37d4685eb87 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
> 62ddb7a332030f3116477408d8b16c19e434c159 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 4341621767a9fa5be2c66e77ef60f0c65dae58ca 
> 
> 
> Diff: https://reviews.apache.org/r/59013/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

2017-05-10 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59013/#review174507
---


Ship it!




Ship It!

- Chun-Hung Hsiao


On May 10, 2017, 12:47 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59013/
> ---
> 
> (Updated May 10, 2017, 12:47 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented passing Image::Secret Puller::pull().
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
> 344baab5c0365c3fc2dc814887bb2b48082b050f 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> 5bc68d2047a7b3e3fa30315d61073e342ba6affe 
>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
> 6dacdb1403433a37dd31a93d4ff2e37d4685eb87 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
> 62ddb7a332030f3116477408d8b16c19e434c159 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 4341621767a9fa5be2c66e77ef60f0c65dae58ca 
> 
> 
> Diff: https://reviews.apache.org/r/59013/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

2017-05-10 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59013/
---

(Updated May 10, 2017, 5:47 a.m.)


Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
Toenshoff, and Vinod Kone.


Bugs: MESOS-7088
https://issues.apache.org/jira/browse/MESOS-7088


Repository: mesos


Description
---

Implemented passing Image::Secret Puller::pull().


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
344baab5c0365c3fc2dc814887bb2b48082b050f 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
5bc68d2047a7b3e3fa30315d61073e342ba6affe 
  src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
6dacdb1403433a37dd31a93d4ff2e37d4685eb87 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
62ddb7a332030f3116477408d8b16c19e434c159 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2 
  src/tests/containerizer/provisioner_docker_tests.cpp 
4341621767a9fa5be2c66e77ef60f0c65dae58ca 


Diff: https://reviews.apache.org/r/59013/diff/2/

Changes: https://reviews.apache.org/r/59013/diff/1-2/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

2017-05-10 Thread Gilbert Song 


> On May 8, 2017, 5:22 p.m., Vinod Kone wrote:
> > src/slave/containerizer/mesos/provisioner/docker/store.cpp
> > Line 235 (original), 243-244 (patched)
> > 
> >
> > I'm assuming you need `config` here explicitly and cannot get it from 
> > `image` below?

Correct. The `image` below is not the protobuf `Image`. It is the image class 
which returned from `metadata_manager`, indicating whether this image is cached 
or not.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59013/#review174253
---


On May 4, 2017, 4:22 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59013/
> ---
> 
> (Updated May 4, 2017, 4:22 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented passing Image::Secret Puller::pull().
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
> 344baab5c0365c3fc2dc814887bb2b48082b050f 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> 5bc68d2047a7b3e3fa30315d61073e342ba6affe 
>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
> 6dacdb1403433a37dd31a93d4ff2e37d4685eb87 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
> 62ddb7a332030f3116477408d8b16c19e434c159 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 4341621767a9fa5be2c66e77ef60f0c65dae58ca 
> 
> 
> Diff: https://reviews.apache.org/r/59013/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 59013: Implemented passing Image::Secret Puller::pull().

2017-05-08 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59013/#review174253
---


Ship it!





src/slave/containerizer/mesos/provisioner/docker/store.cpp
Line 235 (original), 243-244 (patched)


I'm assuming you need `config` here explicitly and cannot get it from 
`image` below?


- Vinod Kone


On May 4, 2017, 11:22 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59013/
> ---
> 
> (Updated May 4, 2017, 11:22 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
> https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented passing Image::Secret Puller::pull().
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
> 344baab5c0365c3fc2dc814887bb2b48082b050f 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> 5bc68d2047a7b3e3fa30315d61073e342ba6affe 
>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
> 6dacdb1403433a37dd31a93d4ff2e37d4685eb87 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
> 62ddb7a332030f3116477408d8b16c19e434c159 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 4341621767a9fa5be2c66e77ef60f0c65dae58ca 
> 
> 
> Diff: https://reviews.apache.org/r/59013/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>