Re: Review Request 59254: Used loop to implement allocator interval-based allocation.

2017-05-30 Thread Jiang Yan Xu 


> On May 30, 2017, 1:55 p.m., Benjamin Mahler wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Lines 168 (patched)
> > 
> >
> > Can you use a PID rather than a UPID?

Sure. FWIW I copied it from 
https://github.com/apache/mesos/blob/55e7ea5ed788acb0e4f810dd4575a5a4479520d1/src/authentication/http/combined_authenticator.cpp#L275


> On May 30, 2017, 1:55 p.m., Benjamin Mahler wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Lines 176 (patched)
> > 
> >
> > Did you need the explicit return type of the lambda?

I tried not to use it but failed.


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59254/#review176348
---


On May 30, 2017, 11:12 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59254/
> ---
> 
> (Updated May 30, 2017, 11:12 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, James Peach, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This also gets rid of the old "batch" (interval-based) allocation concept 
> because we now
> use the term to describe the grouping of all pending allocation candidates in 
> an allocation run.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 123f97cf495bff0f822838e09df0d88818f04da6 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5511bf6ce8c866c8a8436595f5b3eb1ef81c999f 
> 
> 
> Diff: https://reviews.apache.org/r/59254/diff/3/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 59254: Used loop to implement allocator interval-based allocation.

2017-05-30 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59254/#review176348
---


Ship it!





src/master/allocator/mesos/hierarchical.cpp
Lines 168 (patched)


Can you use a PID rather than a UPID?



src/master/allocator/mesos/hierarchical.cpp
Lines 176 (patched)


Did you need the explicit return type of the lambda?


- Benjamin Mahler


On May 30, 2017, 6:12 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59254/
> ---
> 
> (Updated May 30, 2017, 6:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, James Peach, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This also gets rid of the old "batch" (interval-based) allocation concept 
> because we now
> use the term to describe the grouping of all pending allocation candidates in 
> an allocation run.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 123f97cf495bff0f822838e09df0d88818f04da6 
>   src/master/allocator/mesos/hierarchical.cpp 
> 5511bf6ce8c866c8a8436595f5b3eb1ef81c999f 
> 
> 
> Diff: https://reviews.apache.org/r/59254/diff/3/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 59254: Used loop to implement allocator interval-based allocation.

2017-05-30 Thread Jiang Yan Xu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59254/
---

(Updated May 30, 2017, 11:12 a.m.)


Review request for mesos, Benjamin Mahler, James Peach, and Michael Park.


Repository: mesos


Description
---

This also gets rid of the old "batch" (interval-based) allocation concept 
because we now
use the term to describe the grouping of all pending allocation candidates in 
an allocation run.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
123f97cf495bff0f822838e09df0d88818f04da6 
  src/master/allocator/mesos/hierarchical.cpp 
5511bf6ce8c866c8a8436595f5b3eb1ef81c999f 


Diff: https://reviews.apache.org/r/59254/diff/3/

Changes: https://reviews.apache.org/r/59254/diff/2-3/


Testing
---

make check.


Thanks,

Jiang Yan Xu

Re: Review Request 59254: Used loop to implement allocator interval-based allocation.

2017-05-13 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59254/#review174893
---



Patch looks great!

Reviews applied: [59254]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 13, 2017, 6:06 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59254/
> ---
> 
> (Updated May 13, 2017, 6:06 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This also gets rid of the old "batch" (interval-based) allocation concept 
> because we now
> use the term to describe the grouping of all pending allocation candidates in 
> an allocation run.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 123f97cf495bff0f822838e09df0d88818f04da6 
>   src/master/allocator/mesos/hierarchical.cpp 
> b75ed9a20a9a42f958cebbacd91e5e15b0d21394 
> 
> 
> Diff: https://reviews.apache.org/r/59254/diff/2/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>