Re: Review Request 59302: Simplified master logic for agent re-registration.

2017-05-31 Thread Neil Conway


> On May 30, 2017, 11:44 p.m., Benjamin Mahler wrote:
> > Looking at this patch in isolation, it's hard to see what this 
> > simplifcation has to do with 0.x agents, so the description was a little 
> > confusing for me. Did some previous patches in the chain set us up for 
> > simplifying this? It would be great to have a little more description.

Sorry, I missed this review comment -- but yeah, this change is setup by the 
previous changes to assume that we always have the `FrameworkInfo` for a task 
that the master knows about.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59302/#review176398
---


On May 15, 2017, 11:51 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59302/
> ---
> 
> (Updated May 15, 2017, 11:51 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Now that 0.x agents are not supported, the master logic can be
> simplified somewhat.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad 
> 
> 
> Diff: https://reviews.apache.org/r/59302/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 59302: Simplified master logic for agent re-registration.

2017-05-30 Thread Benjamin Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59302/#review176398
---


Ship it!




Looking at this patch in isolation, it's hard to see what this simplifcation 
has to do with 0.x agents, so the description was a little confusing for me. 
Did some previous patches in the chain set us up for simplifying this? It would 
be great to have a little more description.

- Benjamin Mahler


On May 15, 2017, 11:51 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59302/
> ---
> 
> (Updated May 15, 2017, 11:51 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Now that 0.x agents are not supported, the master logic can be
> simplified somewhat.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad 
> 
> 
> Diff: https://reviews.apache.org/r/59302/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>