Re: Review Request 60149: Added support for `net::IPv4` and `net::IPv6` in `FlagsBase`.

2017-07-05 Thread Benjamin Hindman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60149/#review179688
---


Ship it!




Ship It!

- Benjamin Hindman


On June 29, 2017, 11:23 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60149/
> ---
> 
> (Updated June 29, 2017, 11:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Bugs: MESOS-7488
> https://issues.apache.org/jira/browse/MESOS-7488
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for `net::IPv4` and `net::IPv6` in `FlagsBase`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/parse.hpp 
> 3448c571ece36b8d45bbe1317efc824468fe3466 
> 
> 
> Diff: https://reviews.apache.org/r/60149/diff/3/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>



Re: Review Request 60149: Added support for `net::IPv4` and `net::IPv6` in `FlagsBase`.

2017-06-29 Thread Avinash sridharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60149/
---

(Updated June 29, 2017, 11:23 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added support for `net::IPv4` and `net::IPv6` in `FlagsBase`.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags/parse.hpp 
3448c571ece36b8d45bbe1317efc824468fe3466 


Diff: https://reviews.apache.org/r/60149/diff/3/

Changes: https://reviews.apache.org/r/60149/diff/2-3/


Testing
---

make check.


Thanks,

Avinash sridharan



Re: Review Request 60149: Added support for `net::IPv4` and `net::IPv6` in `FlagsBase`.

2017-06-29 Thread Avinash sridharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60149/
---

(Updated June 29, 2017, 11:16 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added support for `net::IPv4` and `net::IPv6` in `FlagsBase`.


Diffs (updated)
-

  3rdparty/stout/include/stout/flags/parse.hpp 
3448c571ece36b8d45bbe1317efc824468fe3466 


Diff: https://reviews.apache.org/r/60149/diff/2/

Changes: https://reviews.apache.org/r/60149/diff/1-2/


Testing
---

make check.


Thanks,

Avinash sridharan



Re: Review Request 60149: Added support for `net::IPv4` and `net::IPv6` in `FlagsBase`.

2017-06-16 Thread Avinash sridharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60149/
---

(Updated June 16, 2017, 4:41 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Added MESOS-JIRA.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added support for `net::IPv4` and `net::IPv6` in `FlagsBase`.


Diffs
-

  3rdparty/stout/include/stout/flags/parse.hpp 
3448c571ece36b8d45bbe1317efc824468fe3466 


Diff: https://reviews.apache.org/r/60149/diff/1/


Testing
---

make check.


Thanks,

Avinash sridharan