Re: Review Request 62333: Added helper functions for linters using a virtual environment.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62333/#review187174 --- Ship it! Ship It! - Kevin Klues On Sept. 29, 2017, 1:23 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62333/ > --- > > (Updated Sept. 29, 2017, 1:23 p.m.) > > > Review request for mesos, Benjamin Mahler and Kevin Klues. > > > Bugs: MESOS-7924 > https://issues.apache.org/jira/browse/MESOS-7924 > > > Repository: mesos > > > Description > --- > > This is used by the Python linter and > will be used by the Javascript linter. > > > Diffs > - > > support/mesos-style.py 9cd1623c48623e558dcd5b80b4bbf5a2162c57cb > > > Diff: https://reviews.apache.org/r/62333/diff/3/ > > > Testing > --- > > Manual updates of `.py` and `.js` files then test commits to see if the > linters before and afer removing their `.virtualenv` were still working as > expected. > > > Thanks, > > Armand Grillet > >
Re: Review Request 62333: Added helper functions for linters using a virtual environment.
> On Oct. 5, 2017, 1:31 p.m., Kevin Klues wrote: > > Ship It! I made a change locally to remove the `super(Pytlint, self)` calls where unnecessary. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62333/#review187174 --- On Sept. 29, 2017, 1:23 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62333/ > --- > > (Updated Sept. 29, 2017, 1:23 p.m.) > > > Review request for mesos, Benjamin Mahler and Kevin Klues. > > > Bugs: MESOS-7924 > https://issues.apache.org/jira/browse/MESOS-7924 > > > Repository: mesos > > > Description > --- > > This is used by the Python linter and > will be used by the Javascript linter. > > > Diffs > - > > support/mesos-style.py 9cd1623c48623e558dcd5b80b4bbf5a2162c57cb > > > Diff: https://reviews.apache.org/r/62333/diff/3/ > > > Testing > --- > > Manual updates of `.py` and `.js` files then test commits to see if the > linters before and afer removing their `.virtualenv` were still working as > expected. > > > Thanks, > > Armand Grillet > >
Re: Review Request 62333: Added helper functions for linters using a virtual environment.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62333/ --- (Updated Sept. 29, 2017, 1:23 p.m.) Review request for mesos, Benjamin Mahler and Kevin Klues. Changes --- Removed `VirtualenvLinterBase` class. Summary (updated) - Added helper functions for linters using a virtual environment. Bugs: MESOS-7924 https://issues.apache.org/jira/browse/MESOS-7924 Repository: mesos Description --- This is used by the Python linter and will be used by the Javascript linter. Diffs (updated) - support/mesos-style.py 9cd1623c48623e558dcd5b80b4bbf5a2162c57cb Diff: https://reviews.apache.org/r/62333/diff/3/ Changes: https://reviews.apache.org/r/62333/diff/2-3/ Testing --- Manual updates of `.py` and `.js` files then test commits to see if the linters before and afer removing their `.virtualenv` were still working as expected. Thanks, Armand Grillet
