Re: Review Request 63585: Improved support/mesos-style.py structure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63585/#review190712 --- Ship it! Ship It! - Kevin Klues On Nov. 6, 2017, 4:59 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63585/ > --- > > (Updated Nov. 6, 2017, 4:59 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-7924 > https://issues.apache.org/jira/browse/MESOS-7924 > > > Repository: mesos > > > Description > --- > > We have updated the following three things: > > 1. The Python linter now also use the function >`run_command_in_virtualenv` to run. > 2. The methods of LinterBase have been reordered alphabetically. > 3. Some unecessary excluded files have been removed for the JS linter. > > > Diffs > - > > support/mesos-style.py f2888195fec768db8cb6409288e72c7d1eda0f03 > > > Diff: https://reviews.apache.org/r/63585/diff/5/ > > > Testing > --- > > Used the linters after applying this patch. > > > Thanks, > > Armand Grillet > >
Re: Review Request 63585: Improved support/mesos-style.py structure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63585/#review190711 --- Can we update the description to call out exactly the list of changes that we make in this commit? It's not worth breaking apart into separate commits (since it's all related to restructuring), but it would be nice to have a wuick summary list of exactly what's being restructured. - Kevin Klues On Nov. 6, 2017, 4:59 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63585/ > --- > > (Updated Nov. 6, 2017, 4:59 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-7924 > https://issues.apache.org/jira/browse/MESOS-7924 > > > Repository: mesos > > > Description > --- > > The Python linter now also use the function `run_command_in_virtualenv` > to run. The methods of LinterBase have been ordered alphabetically. > > > Diffs > - > > support/mesos-style.py f2888195fec768db8cb6409288e72c7d1eda0f03 > > > Diff: https://reviews.apache.org/r/63585/diff/4/ > > > Testing > --- > > Used the linters after applying this patch. > > > Thanks, > > Armand Grillet > >
Re: Review Request 63585: Improved support/mesos-style.py structure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63585/#review190619 --- PASS: Mesos patch 63585 was successfully built and tested. Reviews applied: `['62214', '63585']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63585 - Mesos Reviewbot Windows On Nov. 6, 2017, 4:59 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63585/ > --- > > (Updated Nov. 6, 2017, 4:59 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-7924 > https://issues.apache.org/jira/browse/MESOS-7924 > > > Repository: mesos > > > Description > --- > > The Python linter now also use the function `run_command_in_virtualenv` > to run. The methods of LinterBase have been ordered alphabetically. > > > Diffs > - > > support/mesos-style.py f2888195fec768db8cb6409288e72c7d1eda0f03 > > > Diff: https://reviews.apache.org/r/63585/diff/3/ > > > Testing > --- > > Used the linters after applying this patch. > > > Thanks, > > Armand Grillet > >
Re: Review Request 63585: Improved support/mesos-style.py structure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63585/#review190272 --- PASS: Mesos patch 63585 was successfully built and tested. Reviews applied: `['63581', '63582', '62214', '63585']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63585 - Mesos Reviewbot Windows On Nov. 6, 2017, 4:59 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63585/ > --- > > (Updated Nov. 6, 2017, 4:59 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-7924 > https://issues.apache.org/jira/browse/MESOS-7924 > > > Repository: mesos > > > Description > --- > > The Python linter now also uses the function `run_command_in_virtualenv`. > The methods of `LinterBase` have been ordered alphabetically. > > > Diffs > - > > support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c > > > Diff: https://reviews.apache.org/r/63585/diff/1/ > > > Testing > --- > > Used the linters after applying this patch. > > > Thanks, > > Armand Grillet > >
Re: Review Request 63585: Improved support/mesos-style.py structure.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63585/#review190210 --- Patch looks great! Reviews applied: [63581, 63582, 62214, 63585] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Nov. 6, 2017, 8:59 a.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63585/ > --- > > (Updated Nov. 6, 2017, 8:59 a.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-7924 > https://issues.apache.org/jira/browse/MESOS-7924 > > > Repository: mesos > > > Description > --- > > The Python linter now also uses the function `run_command_in_virtualenv`. > The methods of `LinterBase` have been ordered alphabetically. > > > Diffs > - > > support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c > > > Diff: https://reviews.apache.org/r/63585/diff/1/ > > > Testing > --- > > Used the linters after applying this patch. > > > Thanks, > > Armand Grillet > >
