Re: Review Request 65315: Moved 'ObjectApproverAll' into a header for use in tests.

2018-01-26 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65315/#review196380
---




src/tests/mesos.hpp
Lines 3177 (patched)


Would `PermissiveObjectApprover` be a better name?


- Gaston Kleiman


On Jan. 24, 2018, 10:05 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65315/
> ---
> 
> (Updated Jan. 24, 2018, 10:05 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.
> 
> 
> Bugs: MESOS-8469
> https://issues.apache.org/jira/browse/MESOS-8469
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved 'ObjectApproverAll' into a header for use in tests.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp a35c68e8645384f6244d17e37cad71373aba6893 
>   src/tests/mesos.cpp d751b2e9c635eb6a5039678de426467176cda908 
> 
> 
> Diff: https://reviews.apache.org/r/65315/diff/1/
> 
> 
> Testing
> ---
> 
> Testing details in the child review.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 65315: Moved 'ObjectApproverAll' into a header for use in tests.

2018-01-24 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65315/#review196150
---



FAIL: Mesos tests failed to build.

Reviews applied: `['65315']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65315

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65315/logs/mesos-tests-build-cmake-stdout.log):

```
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1799): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1814): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1818): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1826): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2363): 
warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _strdup. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2377): 
warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _stricmp. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\seterror.c(189): 
warning C4996: 'strerror': This function or variable may be unsafe. Consider 
using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(236):
 warning C4996: 'strcpy': This function or variable may be unsafe. Consider 
using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(241):
 warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(253):
 warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(278):
 warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _stricmp. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]