Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204276
---


Ship it!




Ship It!

- Joseph Wu


On June 4, 2018, 12:11 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated June 4, 2018, 12:11 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/9/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204274
---



PASS: Mesos patch 67066 was successfully built and tested.

Reviews applied: `['67118', '67064', '67065', '67066']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066

- Mesos Reviewbot Windows


On June 4, 2018, 7:11 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated June 4, 2018, 7:11 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/9/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/
---

(Updated June 4, 2018, 7:11 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.


Changes
---

Updating review for new reviewbot pass


Bugs: MESOS-8064
https://issues.apache.org/jira/browse/MESOS-8064


Repository: mesos


Description
---

Modified the fetcher to use libarchive and added associated tests.


Diffs (updated)
-

  src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
  src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8 


Diff: https://reviews.apache.org/r/67066/diff/9/

Changes: https://reviews.apache.org/r/67066/diff/8-9/


Testing
---

I've built on Windows with CMake and have run all tests, which all pass.
I've also built on Linux with both the autotools build and cmake build and have 
run all tests, which all pass.


Thanks,

John Kordich

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204222
---



Patch looks great!

Reviews applied: [67118, 67064, 67065, 67066]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 1, 2018, 9:58 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated June 1, 2018, 9:58 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/8/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204209
---



PASS: Mesos patch 67066 was successfully built and tested.

Reviews applied: `['67118', '67064', '67065', '67066']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066

- Mesos Reviewbot Windows


On June 1, 2018, 9:58 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated June 1, 2018, 9:58 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/8/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/
---

(Updated June 1, 2018, 9:58 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.


Changes
---

Updating review for another reviewbot pass.


Bugs: MESOS-8064
https://issues.apache.org/jira/browse/MESOS-8064


Repository: mesos


Description
---

Modified the fetcher to use libarchive and added associated tests.


Diffs (updated)
-

  src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
  src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8 


Diff: https://reviews.apache.org/r/67066/diff/8/

Changes: https://reviews.apache.org/r/67066/diff/7-8/


Testing
---

I've built on Windows with CMake and have run all tests, which all pass.
I've also built on Linux with both the autotools build and cmake build and have 
run all tests, which all pass.


Thanks,

John Kordich

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204160
---



Patch looks great!

Reviews applied: [67118, 67064, 67065, 67066]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 30, 2018, 8:30 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated May 30, 2018, 8:30 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/7/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Eric Mumau via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204085
---


Ship it!




- Eric Mumau


On May 30, 2018, 8:30 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated May 30, 2018, 8:30 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/7/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Eric Mumau via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204084
---




src/tests/fetcher_tests.cpp
Line 1015 (original)


Were these tests removed deliberately?


- Eric Mumau


On May 30, 2018, 8:30 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated May 30, 2018, 8:30 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/7/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204083
---



PASS: Mesos patch 67066 was successfully built and tested.

Reviews applied: `['67118', '67064', '67065', '67066']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066

- Mesos Reviewbot Windows


On May 30, 2018, 8:30 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated May 30, 2018, 8:30 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/7/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/
---

(Updated May 30, 2018, 8:30 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.


Changes
---

Updating review for new reviewbot pass.


Bugs: MESOS-8064
https://issues.apache.org/jira/browse/MESOS-8064


Repository: mesos


Description
---

Modified the fetcher to use libarchive and added associated tests.


Diffs (updated)
-

  src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
  src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8 


Diff: https://reviews.apache.org/r/67066/diff/7/

Changes: https://reviews.apache.org/r/67066/diff/6-7/


Testing
---

I've built on Windows with CMake and have run all tests, which all pass.
I've also built on Linux with both the autotools build and cmake build and have 
run all tests, which all pass.


Thanks,

John Kordich

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Joseph Wu]

> On May 29, 2018, 1:38 p.m., John Kordich wrote:
> > I'm not sure why review bot is failing for Linux. Will investigate. Seems 
> > to build just fine for me.

You probably need to add any new stout headers to the Makefile(s).  The 
`distcheck` won't pick up headers automatically.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204009
---


On May 24, 2018, 7:13 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated May 24, 2018, 7:13 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 95359ec84ed631bdd7b4fb5192e03f68cc57ed61 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/6/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204009
---



I'm not sure why review bot is failing for Linux. Will investigate. Seems to 
build just fine for me.

- John Kordich


On May 25, 2018, 2:13 a.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated May 25, 2018, 2:13 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 95359ec84ed631bdd7b4fb5192e03f68cc57ed61 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/6/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review203847
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67118', '67064', '67065', '67066']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (117 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1080 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (37 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (76 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (779 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (803 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (735 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (761 ms total)

[--] Global test environment tear-down
[==] 980 tests from 95 test cases ran. (475662 ms total)
[  PASSED  ] 979 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] 
DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange

 1 FAILED TEST
  YOU HAVE 220 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066/logs/mesos-tests-stderr.log):

```
I0525 04:26:59.690294 20680 master.cpp:10843] Updating the state of task 
113688a8-1b07-47da-9241-29cd2d3676d2 of framework 
0bda877c-83ed-4b85-9da9-f6e5e0cada3c- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0525 04:26:59.690294 23248 slave.cpp:3935] Shutting down framework 0bdI0525 
04:26:59.506305 23164 exec.cpp:162] Version: 1.7.0
I0525 04:26:59.534291  1816 exec.cpp:236] Executor registered on agent 
0bda877c-83ed-4b85-9da9-f6e5e0cada3c-S0
I0525 04:26:59.538275 22836 executor.cpp:178] Received SUBSCRIBED event
I0525 04:26:59.543308 22836 executor.cpp:182] Subscribed executor on 
windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0525 04:26:59.543308 22836 executor.cpp:178] Received LAUNCH event
I0525 04:26:59.548316 22836 executor.cpp:665] Starting task 
113688a8-1b07-47da-9241-29cd2d3676d2
I0525 04:26:59.640307 22836 executor.cpp:485] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0525 04:26:59.660290 22836 executor.cpp:678] Forked command at 18552
I0525 04:26:59.692291 22776 exec.cpp:445] Executor asked to shutdown
I0525 04:26:59.693426 20544 executor.cpp:178] Received SHUTDOWN event
I0525 04:26:59.693426 20544 executor.cpp:781] Shutting down
I0525 04:26:59.693426 20544 executor.cpp:894] Sending SIGTERM to process tree 
at pid 18a877c-83ed-4b85-9da9-f6e5e0cada3c-
I0525 04:26:59.691294 23248 slave.cpp:6656] Shutting down executor 
'113688a8-1b07-47da-9241-29cd2d3676d2' of framework 
0bda877c-83ed-4b85-9da9-f6e5e0cada3c- at executor(1)@192.10.1.5:63974
I0525 04:26:59.692291 20680 master.cpp:10942] Removing task 
113688a8-1b07-47da-9241-29cd2d3676d2 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 0bda877c-83ed-4b85-9da9-f6e5e0cada3c- on 
agent 0bda877c-83ed-4b85-9da9-f6e5e0cada3c-S0 at slave(447)@192.10.1.5:63953 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0525 04:26:59.693426 23248 slave.cpp:929] Agent terminating
W0525 04:26:59.693426 23248 slave.cpp:3931] Ignoring shutdown framework 
0bda877c-83ed-4b85-9da9-f6e5e0cada3c- because it is terminating
I0525 04:26:59.696274 20912 master.cpp:1293] Agent 
0bda877c-83ed-4b85-9da9-f6e5e0cada3c-S0 at slave(447)@192.10.1.5:63953 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0525 04:26:59.696274 20912 master.cpp:3303] Disconnecting agent 
0bda877c-83ed-4b85-9da9-f6e5e0cada3c-S0 at slave(447)@192.10.1.5:63953 
(windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0525 04:26:59.696274 14860 hierarchical.cpp:344] Removed framework 
0bda877c-83ed-4b85-9da9-f6e5e0cada3c-
I0525 04:26:59.696274 20912 master.cpp:3322] Deactivating agent 

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/
---

(Updated May 25, 2018, 2:13 a.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.


Changes
---

Updating patch for a new reviewbot run. Looks like downsizing the xz archive 
helped reviewboard to accept the patch properly.


Bugs: MESOS-8064
https://issues.apache.org/jira/browse/MESOS-8064


Repository: mesos


Description
---

Modified the fetcher to use libarchive and added associated tests.


Diffs (updated)
-

  src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
  src/tests/fetcher_tests.cpp 95359ec84ed631bdd7b4fb5192e03f68cc57ed61 


Diff: https://reviews.apache.org/r/67066/diff/6/

Changes: https://reviews.apache.org/r/67066/diff/5-6/


Testing
---

I've built on Windows with CMake and have run all tests, which all pass.
I've also built on Linux with both the autotools build and cmake build and have 
run all tests, which all pass.


Thanks,

John Kordich

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review203713
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67118', '67064', '67065', '67066']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066

Relevant logs:

- 
[stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066/logs/stout-tests-cmake-stdout.log):

```
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\compress.c(205): 
warning C4244: '=': conversion from '__int64' to 'Int32', possible loss of data 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(997): 
warning C4267: '=': conversion from 'size_t' to 'Int32', possible loss of data 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1056): 
warning C4267: '=': conversion from 'size_t' to 'Int32', possible loss of data 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1191): 
warning C4267: '=': conversion from 'size_t' to 'Int32', possible loss of data 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1417): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1418): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1423): 
warning C4996: 'setmode': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _setmode. See online help for details. 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1425): 
warning C4996: 'fopen': This function or variable may be unsafe. Consider using 
fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1431): 
warning C4996: 'fdopen': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _fdopen. See online help for details. 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\compress.c(205): 
warning C4244: '=': conversion from '__int64' to 'Int32', possible loss of data 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(997): 
warning C4267: '=': conversion from 'size_t' to 'Int32', possible loss of data 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1056): 
warning C4267: '=': conversion from 'size_t' to 'Int32', possible loss of data 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1191): 
warning C4267: '=': conversion from 'size_t' to 'Int32', possible loss of data 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1417): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/
---

(Updated May 23, 2018, 11:03 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.


Changes
---

Updated patch with requested changes.


Bugs: MESOS-8064
https://issues.apache.org/jira/browse/MESOS-8064


Repository: mesos


Description
---

Modified the fetcher to use libarchive and added associated tests.


Diffs (updated)
-

  src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
  src/tests/fetcher_tests.cpp 311be6a36f137819ee91187a16df2b8e61def478 


Diff: https://reviews.apache.org/r/67066/diff/5/

Changes: https://reviews.apache.org/r/67066/diff/4-5/


Testing
---

I've built on Windows with CMake and have run all tests, which all pass.
I've also built on Linux with both the autotools build and cmake build and have 
run all tests, which all pass.


Thanks,

John Kordich

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review203366
---




src/tests/fetcher_tests.cpp
Lines 1023-1026 (original), 1013-1019 (patched)


Should we just delete this part of the tests then, as it's obselete?


- Andrew Schwartzmeyer


On May 15, 2018, 11:30 a.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated May 15, 2018, 11:30 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 311be6a36f137819ee91187a16df2b8e61def478 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/4/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review203157
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67118', '67064', '67065', '67066']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066

Relevant logs:

- 
[stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066/logs/stout-tests-cmake-stdout.log):

```
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\compress.c(205): 
warning C4244: '=': conversion from '__int64' to 'Int32', possible loss of data 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(997): 
warning C4267: '=': conversion from 'size_t' to 'Int32', possible loss of data 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1056): 
warning C4267: '=': conversion from 'size_t' to 'Int32', possible loss of data 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1191): 
warning C4267: '=': conversion from 'size_t' to 'Int32', possible loss of data 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1417): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1418): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1423): 
warning C4996: 'setmode': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _setmode. See online help for details. 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1425): 
warning C4996: 'fopen': This function or variable may be unsafe. Consider using 
fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1431): 
warning C4996: 'fdopen': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _fdopen. See online help for details. 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\compress.c(205): 
warning C4244: '=': conversion from '__int64' to 'Int32', possible loss of data 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(997): 
warning C4267: '=': conversion from 'size_t' to 'Int32', possible loss of data 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1056): 
warning C4267: '=': conversion from 'size_t' to 'Int32', possible loss of data 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1191): 
warning C4267: '=': conversion from 'size_t' to 'Int32', possible loss of data 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6-build\bzip2.vcxproj] 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 d:\dcos\mesos\3rdparty\bzip2-1.0.6\src\bzip2-1.0.6\bzlib.c(1417): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/
---

(Updated May 15, 2018, 6:30 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.


Changes
---

Updating review for another reviewbot pass.


Bugs: MESOS-8064
https://issues.apache.org/jira/browse/MESOS-8064


Repository: mesos


Description
---

Modified the fetcher to use libarchive and added associated tests.


Diffs (updated)
-

  src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
  src/tests/fetcher_tests.cpp 311be6a36f137819ee91187a16df2b8e61def478 


Diff: https://reviews.apache.org/r/67066/diff/4/

Changes: https://reviews.apache.org/r/67066/diff/3-4/


Testing
---

I've built on Windows with CMake and have run all tests, which all pass.
I've also built on Linux with both the autotools build and cmake build and have 
run all tests, which all pass.


Thanks,

John Kordich

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review203083
---



PASS: Mesos patch 67066 was successfully built and tested.

Reviews applied: `['67118', '67064', '67065', '67066']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066

- Mesos Reviewbot Windows


On May 14, 2018, 10:42 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated May 14, 2018, 10:42 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 311be6a36f137819ee91187a16df2b8e61def478 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/3/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/
---

(Updated May 14, 2018, 10:42 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.


Bugs: MESOS-8064
https://issues.apache.org/jira/browse/MESOS-8064


Repository: mesos


Description
---

Modified the fetcher to use libarchive and added associated tests.


Diffs (updated)
-

  src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
  src/tests/fetcher_tests.cpp 311be6a36f137819ee91187a16df2b8e61def478 


Diff: https://reviews.apache.org/r/67066/diff/3/

Changes: https://reviews.apache.org/r/67066/diff/2-3/


Testing
---

I've built on Windows with CMake and have run all tests, which all pass.
I've also built on Linux with both the autotools build and cmake build and have 
run all tests, which all pass.


Thanks,

John Kordich

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review203054
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67064', '67065', '67066']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066

Relevant logs:

- 
[stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066/logs/stout-tests-cmake-stdout.log):

```
 CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/xz-5.2.3.tar.gz' failed 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
 CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
 CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/xz-5.2.3.tar.gz' failed 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
 CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
 CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/xz-5.2.3.tar.gz' failed 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
 CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
 CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/xz-5.2.3.tar.gz' failed 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
 CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]


   "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
target) (1) ->
   "D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj" (default target) (10) ->
 CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/bzip2-1.0.6.tar.gz' failed 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/bzip2-1.0.6.tar.gz' failed 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/bzip2-1.0.6.tar.gz' failed 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/bzip2-1.0.6.tar.gz' failed 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/bzip2-1.0.6.tar.gz' failed 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/bzip2-1.0.6.tar.gz' failed 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
 CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]

39 Warning(s)
24 Error(s)

Time Elapsed 00:03:45.94
```

- 
[libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066/logs/libprocess-tests-cmake-stdout.log):

```
 CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/xz-5.2.3.tar.gz' failed 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
 CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
 CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/xz-5.2.3.tar.gz' failed 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
 CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
 CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/xz-5.2.3.tar.gz' failed 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
 CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
 CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/xz-5.2.3.tar.gz' failed 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
 CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]


   "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" 
(default 

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/
---

(Updated May 14, 2018, 5:13 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.


Changes
---

Fixed patch to include binary files


Bugs: MESOS-8064
https://issues.apache.org/jira/browse/MESOS-8064


Repository: mesos


Description
---

Modified the fetcher to use libarchive and added associated tests.


Diffs (updated)
-

  src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
  src/tests/fetcher_tests.cpp 311be6a36f137819ee91187a16df2b8e61def478 


Diff: https://reviews.apache.org/r/67066/diff/2/

Changes: https://reviews.apache.org/r/67066/diff/1-2/


Testing
---

I've built on Windows with CMake and have run all tests, which all pass.
I've also built on Linux with both the autotools build and cmake build and have 
run all tests, which all pass.


Thanks,

John Kordich

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review202888
---



Bad patch!

Reviews applied: [67066, 67065, 67064]

Failed command: python support/apply-reviews.py -n -r 67064

Error:
2018-05-11 03:45:58 URL:https://reviews.apache.org/r/67064/diff/raw/ 
[25236/25236] -> "67064.patch" [1]
error: missing binary patch data for '3rdparty/bzip2-1.0.6.tar.gz'
error: binary patch does not apply to '3rdparty/bzip2-1.0.6.tar.gz'
error: 3rdparty/bzip2-1.0.6.tar.gz: patch does not apply
error: missing binary patch data for '3rdparty/libarchive-3.3.2.tar.gz'
error: binary patch does not apply to '3rdparty/libarchive-3.3.2.tar.gz'
error: 3rdparty/libarchive-3.3.2.tar.gz: patch does not apply
error: missing binary patch data for '3rdparty/xz-5.2.3.tar.gz'
error: binary patch does not apply to '3rdparty/xz-5.2.3.tar.gz'
error: 3rdparty/xz-5.2.3.tar.gz: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/22427/console

- Mesos Reviewbot


On May 10, 2018, 9:06 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated May 10, 2018, 9:06 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 311be6a36f137819ee91187a16df2b8e61def478 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/1/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review202867
---



FAIL: Failed to apply the dependent review: 67064.

Failed command: `python.exe .\support\apply-reviews.py -n -r 67064`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066

Relevant logs:

- 
[apply-review-67064-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066/logs/apply-review-67064-stdout.log):

```
error: missing binary patch data for '3rdparty/bzip2-1.0.6.tar.gz'
error: binary patch does not apply to '3rdparty/bzip2-1.0.6.tar.gz'
error: 3rdparty/bzip2-1.0.6.tar.gz: patch does not apply
error: missing binary patch data for '3rdparty/libarchive-3.3.2.tar.gz'
error: binary patch does not apply to '3rdparty/libarchive-3.3.2.tar.gz'
error: 3rdparty/libarchive-3.3.2.tar.gz: patch does not apply
error: missing binary patch data for '3rdparty/xz-5.2.3.tar.gz'
error: binary patch does not apply to '3rdparty/xz-5.2.3.tar.gz'
error: 3rdparty/xz-5.2.3.tar.gz: patch does not apply
```

- Mesos Reviewbot Windows


On May 10, 2018, 5:06 p.m., John Kordich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> ---
> 
> (Updated May 10, 2018, 5:06 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, 
> Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modified the fetcher to use libarchive and added associated tests.
> 
> 
> Diffs
> -
> 
>   src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d 
>   src/tests/fetcher_tests.cpp 311be6a36f137819ee91187a16df2b8e61def478 
> 
> 
> Diff: https://reviews.apache.org/r/67066/diff/1/
> 
> 
> Testing
> ---
> 
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and 
> have run all tests, which all pass.
> 
> 
> Thanks,
> 
> John Kordich
> 
>