Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

2018-06-16 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67308/#review204896
---



Patch looks great!

Reviews applied: [67308]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 15, 2018, 8:45 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67308/
> ---
> 
> (Updated June 15, 2018, 8:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin 
> Mahler, Greg Mann, Jie Yu, James Peach, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that while cquery and LSP support many editors, this only
> demonstrates how to setup Emacs. Documentation on Vim setup is
> welcome!
> 
> 
> Diffs
> -
> 
>   docs/cquery.md PRE-CREATION 
>   docs/developer-guide.md 3dbc93ee4225abc54593dda005781d879d2ca8da 
> 
> 
> Diff: https://reviews.apache.org/r/67308/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

2018-06-15 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67308/#review204881
---



PASS: Mesos patch 67308 was successfully built and tested.

Reviews applied: `['67308']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67308

- Mesos Reviewbot Windows


On June 15, 2018, 8:45 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67308/
> ---
> 
> (Updated June 15, 2018, 8:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin 
> Mahler, Greg Mann, Jie Yu, James Peach, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that while cquery and LSP support many editors, this only
> demonstrates how to setup Emacs. Documentation on Vim setup is
> welcome!
> 
> 
> Diffs
> -
> 
>   docs/cquery.md PRE-CREATION 
>   docs/developer-guide.md 3dbc93ee4225abc54593dda005781d879d2ca8da 
> 
> 
> Diff: https://reviews.apache.org/r/67308/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

2018-06-15 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67308/
---

(Updated June 15, 2018, 1:45 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler, 
Greg Mann, Jie Yu, James Peach, Joseph Wu, and Till Toenshoff.


Changes
---

Updated and moved documentation into its own file.


Repository: mesos


Description
---

Note that while cquery and LSP support many editors, this only
demonstrates how to setup Emacs. Documentation on Vim setup is
welcome!


Diffs (updated)
-

  docs/cquery.md PRE-CREATION 
  docs/developer-guide.md 3dbc93ee4225abc54593dda005781d879d2ca8da 


Diff: https://reviews.apache.org/r/67308/diff/2/

Changes: https://reviews.apache.org/r/67308/diff/1-2/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

2018-05-28 Thread Benjamin Bannier 


> On May 25, 2018, 9:35 p.m., Benjamin Bannier wrote:
> > docs/developer-guide.md
> > Lines 128 (patched)
> > 
> >
> > Thanks for capturing this!
> > 
> > As a high level comment, I believe this doc should capture important 
> > information for developing Mesos. Since it already is pretty big I am not 
> > sure this new section is of enough general importance to be included here. 
> > Maybe we could move it to a blog post or additional document linked under 
> > `Further reading` at the bottom instead?
> 
> Andrew Schwartzmeyer wrote:
> > I believe this doc should capture important information for developing 
> Mesos. Since it already is pretty big
> 
> As the sole author of this document so far, I appreciate that!
> 
> > I am not sure this new section is of enough general importance to be 
> included here.
> 
> I respectfully disagree with this. I am quite sure it is of enough 
> general importance, as navigating the Mesos code-base as an incredible chore, 
> and the majority of devs I've spoken with just fall back to inefficient uses 
> of `grep`. Based on the feedback of my cquery demo at the last dev sync, I 
> think this information is wanted, and I don't see a better place than a 
> developer guide.
> 
> How strongly do you feel that we should split this document up?

Imagine being a new contributor to Mesos wanting to know how to write code and 
contribute their patch. They could read `developer-guide.md` for e.g., best 
practices or patterns, `c++-style-guide.md` for how to format their code, and 
`[beginner|advanced]-contribution.md` for how to contribute their code.

Currently all these documents already ask for a lot of reading, even though 
they just contain information which should apply to almost everyone. Ideally a 
contributor should know everything in these guides. This is asking a lot from a 
new contributor, and I think it is important to focus on highly relevant 
information. Documenting less central information is still great, but we should 
avoid overloading documents we would point new contributors to -- we can always 
add these elsewhere.

As an example, I am pretty happy having integrated Mesos' `clang-tidy` with 
vim's `ale` plugin, but I think putting this into a doc new contributors would 
reach out for to make sense of Mesos wouldn't be a great experience for them.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67308/#review203902
---


On May 25, 2018, 4:30 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67308/
> ---
> 
> (Updated May 25, 2018, 4:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin 
> Mahler, Greg Mann, Jie Yu, James Peach, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that while cquery and LSP support many editors, this only
> demonstrates how to setup Emacs. Documentation on Vim setup is
> welcome!
> 
> 
> Diffs
> -
> 
>   docs/developer-guide.md 3dbc93ee4225abc54593dda005781d879d2ca8da 
> 
> 
> Diff: https://reviews.apache.org/r/67308/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

2018-05-25 Thread Andrew Schwartzmeyer 


> On May 25, 2018, 12:35 p.m., Benjamin Bannier wrote:
> > docs/developer-guide.md
> > Lines 128 (patched)
> > 
> >
> > Thanks for capturing this!
> > 
> > As a high level comment, I believe this doc should capture important 
> > information for developing Mesos. Since it already is pretty big I am not 
> > sure this new section is of enough general importance to be included here. 
> > Maybe we could move it to a blog post or additional document linked under 
> > `Further reading` at the bottom instead?

> I believe this doc should capture important information for developing Mesos. 
> Since it already is pretty big

As the sole author of this document so far, I appreciate that!

> I am not sure this new section is of enough general importance to be included 
> here.

I respectfully disagree with this. I am quite sure it is of enough general 
importance, as navigating the Mesos code-base as an incredible chore, and the 
majority of devs I've spoken with just fall back to inefficient uses of `grep`. 
Based on the feedback of my cquery demo at the last dev sync, I think this 
information is wanted, and I don't see a better place than a developer guide.

How strongly do you feel that we should split this document up?


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67308/#review203902
---


On May 24, 2018, 7:30 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67308/
> ---
> 
> (Updated May 24, 2018, 7:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin 
> Mahler, Greg Mann, Jie Yu, James Peach, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that while cquery and LSP support many editors, this only
> demonstrates how to setup Emacs. Documentation on Vim setup is
> welcome!
> 
> 
> Diffs
> -
> 
>   docs/developer-guide.md 3dbc93ee4225abc54593dda005781d879d2ca8da 
> 
> 
> Diff: https://reviews.apache.org/r/67308/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

2018-05-25 Thread Andrew Schwartzmeyer 


> On May 25, 2018, 10:33 a.m., James Peach wrote:
> > docs/developer-guide.md
> > Lines 152 (patched)
> > 
> >
> > "If you need to build cquery from source, the cquery wiki provides a 
> > decent ..."

Oops.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67308/#review203894
---


On May 24, 2018, 7:30 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67308/
> ---
> 
> (Updated May 24, 2018, 7:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin 
> Mahler, Greg Mann, Jie Yu, James Peach, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that while cquery and LSP support many editors, this only
> demonstrates how to setup Emacs. Documentation on Vim setup is
> welcome!
> 
> 
> Diffs
> -
> 
>   docs/developer-guide.md 3dbc93ee4225abc54593dda005781d879d2ca8da 
> 
> 
> Diff: https://reviews.apache.org/r/67308/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

2018-05-25 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67308/#review203902
---




docs/developer-guide.md
Lines 128 (patched)


Thanks for capturing this!

As a high level comment, I believe this doc should capture important 
information for developing Mesos. Since it already is pretty big I am not sure 
this new section is of enough general importance to be included here. Maybe we 
could move it to a blog post or additional document linked under `Further 
reading` at the bottom instead?


- Benjamin Bannier


On May 25, 2018, 4:30 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67308/
> ---
> 
> (Updated May 25, 2018, 4:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin 
> Mahler, Greg Mann, Jie Yu, James Peach, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that while cquery and LSP support many editors, this only
> demonstrates how to setup Emacs. Documentation on Vim setup is
> welcome!
> 
> 
> Diffs
> -
> 
>   docs/developer-guide.md 3dbc93ee4225abc54593dda005781d879d2ca8da 
> 
> 
> Diff: https://reviews.apache.org/r/67308/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

2018-05-25 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67308/#review203894
---


Fix it, then Ship it!





docs/developer-guide.md
Lines 152 (patched)


"If you need to build cquery from source, the cquery wiki provides a decent 
..."


- James Peach


On May 25, 2018, 2:30 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67308/
> ---
> 
> (Updated May 25, 2018, 2:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin 
> Mahler, Greg Mann, Jie Yu, James Peach, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that while cquery and LSP support many editors, this only
> demonstrates how to setup Emacs. Documentation on Vim setup is
> welcome!
> 
> 
> Diffs
> -
> 
>   docs/developer-guide.md 3dbc93ee4225abc54593dda005781d879d2ca8da 
> 
> 
> Diff: https://reviews.apache.org/r/67308/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

2018-05-25 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67308/#review203893
---



Patch looks great!

Reviews applied: [67308]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 25, 2018, 2:30 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67308/
> ---
> 
> (Updated May 25, 2018, 2:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin 
> Mahler, Greg Mann, Jie Yu, James Peach, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that while cquery and LSP support many editors, this only
> demonstrates how to setup Emacs. Documentation on Vim setup is
> welcome!
> 
> 
> Diffs
> -
> 
>   docs/developer-guide.md 3dbc93ee4225abc54593dda005781d879d2ca8da 
> 
> 
> Diff: https://reviews.apache.org/r/67308/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67308: Documented how to setup and use cquery with Mesos.

2018-05-24 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67308/#review203848
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67308']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67308

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67308/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (111 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1053 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (73 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (714 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (739 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (724 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (748 ms total)

[--] Global test environment tear-down
[==] 980 tests from 95 test cases ran. (435796 ms total)
[  PASSED  ] 979 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] 
DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange

 1 FAILED TEST
  YOU HAVE 220 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67308/logs/mesos-tests-stderr.log):

```
I0525 05:01:28.771742 18080 master.cpp:10843] Updating the state of task 
544045a0-eb06-42fe-84a9-448f4ef552c4 of framework 
367ab55f-c3f5-43f7-9e89-82c86a9413f6- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0525 05:01:28.771742 13776 slave.cpp:3935] Shutting down framework 
367ab55f-c3f5-43f7-9e89-82c86a9413f6-
I0525 05:01:28.771742 13776 slave.cpp:6656] Shutting down executor 
'544045a0-eb06-42fe-84a9-448f4ef552c4' of framework 
367ab55f-c3f5-43f7-9e89I0525 05:01:28.605736 23600 exec.cpp:162] Version: 1.7.0
I0525 05:01:28.631736 23912 exec.cpp:236] Executor registered on agent 
367ab55f-c3f5-43f7-9e89-82c86a9413f6-S0
I0525 05:01:28.635738 21644 executor.cpp:178] Received SUBSCRIBED event
I0525 05:01:28.639744 21644 executor.cpp:182] Subscribed executor on 
windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0525 05:01:28.640743 21644 executor.cpp:178] Received LAUNCH event
I0525 05:01:28.645750 21644 executor.cpp:665] Starting task 
544045a0-eb06-42fe-84a9-448f4ef552c4
I0525 05:01:28.725738 21644 executor.cpp:485] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0525 05:01:28.743734 21644 executor.cpp:678] Forked command at 21120
I0525 05:01:28.773739 21616 exec.cpp:445] Executor asked to shutdown
I0525 05:01:28.774838 20272 executor.cpp:178] Received SHUTDOWN event
I0525 05:01:28.774838 20272 executor.cpp:781] Shutting down
I0525 05:01:28.774838 20272 executor.cpp:894] Sending SIGTERM to process tree 
at pid 21-82c86a9413f6- at executor(1)@192.10.1.6:50366
I0525 05:01:28.773739 13776 slave.cpp:929] Agent terminating
W0525 05:01:28.773739 13776 slave.cpp:3931] Ignoring shutdown framework 
367ab55f-c3f5-43f7-9e89-82c86a9413f6- because it is terminating
I0525 05:01:28.773739 18080 master.cpp:10942] Removing task 
544045a0-eb06-42fe-84a9-448f4ef552c4 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 367ab55f-c3f5-43f7-9e89-82c86a9413f6- on 
agent 367ab55f-c3f5-43f7-9e89-82c86a9413f6-S0 at slave(447)@192.10.1.6:50345 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0525 05:01:28.42 18080 master.cpp:1293] Agent 
367ab55f-c3f5-43f7-9e89-82c86a9413f6-S0 at slave(447)@192.10.1.6:50345 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0525 05:01:28.42 18080 master.cpp:3303] Disconnecting agent 
367ab55f-c3f5-43f7-9e89-82c86a9413f6-S0 at slave(447)@192.10.1.6:50345 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0525 05:01:28.42 11844 hierarchical.cpp:344] Removed framework 
367ab55f-c3f5-43f7-9e89-82c86a9413f6-
I0525 05:01:28.42 18080 master.cpp:3322] Deactivating agent 
367ab55f-c3f5-43f7-9e89-82c86a9413f6-S0 at slave(447)@1