Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

2018-06-18 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/#review204980
---


Ship it!




Ship It!

- Gilbert Song


On June 13, 2018, 7:24 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67343/
> ---
> 
> (Updated June 13, 2018, 7:24 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When `cgroups/all` is specified in the agent flag `--isolation`, we
> will automatically load all the local enabled cgroups subsystems in
> the cgroups isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 17a1a3762b2012ff875e4da9c9d4622514e48051 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 215e32461e851668247f9fae62aa656f5dd5e245 
> 
> 
> Diff: https://reviews.apache.org/r/67343/diff/5/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

2018-06-13 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/
---

(Updated June 13, 2018, 10:24 p.m.)


Review request for mesos and Gilbert Song.


Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description (updated)
---

When `cgroups/all` is specified in the agent flag `--isolation`, we
will automatically load all the local enabled cgroups subsystems in
the cgroups isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
17a1a3762b2012ff875e4da9c9d4622514e48051 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
215e32461e851668247f9fae62aa656f5dd5e245 


Diff: https://reviews.apache.org/r/67343/diff/5/

Changes: https://reviews.apache.org/r/67343/diff/4-5/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

2018-06-08 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/#review204495
---




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 132-134 (patched)


Instead of returning an error; as we discussed, let's return an empty 
subsystem


- Gilbert Song


On May 31, 2018, 8:21 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67343/
> ---
> 
> (Updated May 31, 2018, 8:21 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When `cgroups/all` is specified in the agent flag `--isolation`, we
> will automatically load all the local enabled cgroups subsystems in
> the cgroups isolator with one exception: the `perf_event` subsystem,
> we will only automatically load it when the agent flag `--perf_events`
> is specified, otherwise it will be skipped.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 17a1a3762b2012ff875e4da9c9d4622514e48051 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 215e32461e851668247f9fae62aa656f5dd5e245 
> 
> 
> Diff: https://reviews.apache.org/r/67343/diff/4/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

2018-06-06 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/#review204434
---


Ship it!




Ship It!

- Gilbert Song


On May 31, 2018, 8:21 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67343/
> ---
> 
> (Updated May 31, 2018, 8:21 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When `cgroups/all` is specified in the agent flag `--isolation`, we
> will automatically load all the local enabled cgroups subsystems in
> the cgroups isolator with one exception: the `perf_event` subsystem,
> we will only automatically load it when the agent flag `--perf_events`
> is specified, otherwise it will be skipped.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 17a1a3762b2012ff875e4da9c9d4622514e48051 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 215e32461e851668247f9fae62aa656f5dd5e245 
> 
> 
> Diff: https://reviews.apache.org/r/67343/diff/4/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

2018-05-31 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/
---

(Updated June 1, 2018, 11:21 a.m.)


Review request for mesos and Gilbert Song.


Changes
---

Addressed review comments.


Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description
---

When `cgroups/all` is specified in the agent flag `--isolation`, we
will automatically load all the local enabled cgroups subsystems in
the cgroups isolator with one exception: the `perf_event` subsystem,
we will only automatically load it when the agent flag `--perf_events`
is specified, otherwise it will be skipped.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
17a1a3762b2012ff875e4da9c9d4622514e48051 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
215e32461e851668247f9fae62aa656f5dd5e245 


Diff: https://reviews.apache.org/r/67343/diff/4/

Changes: https://reviews.apache.org/r/67343/diff/3-4/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

2018-05-31 Thread Qian Zhang 


> On May 31, 2018, 8:42 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
> > Lines 108 (patched)
> > 
> >
> > enabled cgroup subsystems?

I'd like to be consistent with the existing ones, like:
https://github.com/apache/mesos/blob/1.6.0/src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp#L122

I guess we do not need the word `cgroups` here because we are already in the 
cgroups isolator.


> On May 31, 2018, 8:42 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
> > Lines 134 (patched)
> > 
> >
> > this is not like happen though, but I am thinking if we should return 
> > an error and block the agent in this case?

As we discussed, we'd better to error out in this case.


> On May 31, 2018, 8:42 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
> > Lines 163 (patched)
> > 
> >
> > why not const ref?

My bad, thanks for catching this!


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/#review204093
---


On May 30, 2018, 9:05 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67343/
> ---
> 
> (Updated May 30, 2018, 9:05 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When `cgroups/all` is specified in the agent flag `--isolation`, we
> will automatically load all the local enabled cgroups subsystems in
> the cgroups isolator with one exception: the `perf_event` subsystem,
> we will only automatically load it when the agent flag `--perf_events`
> is specified, otherwise it will be skipped.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 93197b05eb837d02c6c113264f20a33d6ed92d7f 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 6d663a5770418b7ffe2b3af50b9181ecde183c67 
> 
> 
> Diff: https://reviews.apache.org/r/67343/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

2018-05-30 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/#review204093
---




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 97 (patched)


one more space before (



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 108 (patched)


enabled cgroup subsystems?



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 134 (patched)


this is not like happen though, but I am thinking if we should return an 
error and block the agent in this case?



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 137 (patched)


cgroup subsystems



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 163 (patched)


why not const ref?


- Gilbert Song


On May 30, 2018, 6:05 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67343/
> ---
> 
> (Updated May 30, 2018, 6:05 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When `cgroups/all` is specified in the agent flag `--isolation`, we
> will automatically load all the local enabled cgroups subsystems in
> the cgroups isolator with one exception: the `perf_event` subsystem,
> we will only automatically load it when the agent flag `--perf_events`
> is specified, otherwise it will be skipped.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 93197b05eb837d02c6c113264f20a33d6ed92d7f 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 6d663a5770418b7ffe2b3af50b9181ecde183c67 
> 
> 
> Diff: https://reviews.apache.org/r/67343/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

2018-05-30 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/
---

(Updated May 30, 2018, 9:05 p.m.)


Review request for mesos and Gilbert Song.


Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description (updated)
---

When `cgroups/all` is specified in the agent flag `--isolation`, we
will automatically load all the local enabled cgroups subsystems in
the cgroups isolator with one exception: the `perf_event` subsystem,
we will only automatically load it when the agent flag `--perf_events`
is specified, otherwise it will be skipped.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
93197b05eb837d02c6c113264f20a33d6ed92d7f 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
6d663a5770418b7ffe2b3af50b9181ecde183c67 


Diff: https://reviews.apache.org/r/67343/diff/3/

Changes: https://reviews.apache.org/r/67343/diff/2-3/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

2018-05-29 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/#review203982
---



PASS: Mesos patch 67343 was successfully built and tested.

Reviews applied: `['67335', '67342', '67343']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67343

- Mesos Reviewbot Windows


On May 29, 2018, 2:21 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67343/
> ---
> 
> (Updated May 29, 2018, 2:21 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When `cgroups/*` is specified in the agent flag `--isolation`, we will
> automatically load all the local enabled cgroups subsystems in the
> cgroups isolator with one exception: the `perf_event` subsystem, we
> will only automatically load it when the agent flag `--perf_events` is
> specified, otherwise it will be skipped.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 93197b05eb837d02c6c113264f20a33d6ed92d7f 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 6d663a5770418b7ffe2b3af50b9181ecde183c67 
> 
> 
> Diff: https://reviews.apache.org/r/67343/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

2018-05-29 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/
---

(Updated May 29, 2018, 10:21 p.m.)


Review request for mesos and Gilbert Song.


Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description (updated)
---

When `cgroups/*` is specified in the agent flag `--isolation`, we will
automatically load all the local enabled cgroups subsystems in the
cgroups isolator with one exception: the `perf_event` subsystem, we
will only automatically load it when the agent flag `--perf_events` is
specified, otherwise it will be skipped.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
93197b05eb837d02c6c113264f20a33d6ed92d7f 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
6d663a5770418b7ffe2b3af50b9181ecde183c67 


Diff: https://reviews.apache.org/r/67343/diff/2/

Changes: https://reviews.apache.org/r/67343/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang