Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-27 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67601/#review205418
---



Patch looks great!

Reviews applied: [67552, 67601]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 27, 2018, 3:03 a.m., longfei niu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67601/
> ---
> 
> (Updated June 27, 2018, 3:03 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8816
> https://issues.apache.org/jira/browse/MESOS-8816
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added field container_id in ResourceUsage to agent monitor endpoint.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
>   src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed 
> 
> 
> Diff: https://reviews.apache.org/r/67601/diff/3/
> 
> 
> Testing
> ---
> 
> add unit test to src/tests/slave_tests.cpp line 2414 to test whether 
> container_id field added sucessfully or not
> 
> 
> Thanks,
> 
> longfei niu
> 
>

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-26 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67601/#review205412
---



PASS: Mesos patch 67601 was successfully built and tested.

Reviews applied: `['67601']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67601

- Mesos Reviewbot Windows


On June 27, 2018, 3:03 a.m., longfei niu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67601/
> ---
> 
> (Updated June 27, 2018, 3:03 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8816
> https://issues.apache.org/jira/browse/MESOS-8816
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added field container_id in ResourceUsage to agent monitor endpoint.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
>   src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed 
> 
> 
> Diff: https://reviews.apache.org/r/67601/diff/3/
> 
> 
> Testing
> ---
> 
> add unit test to src/tests/slave_tests.cpp line 2414 to test whether 
> container_id field added sucessfully or not
> 
> 
> Thanks,
> 
> longfei niu
> 
>

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-26 Thread longfei niu 


> On 六月 21, 2018, 6:52 p.m., Gilbert Song wrote:
> > src/tests/slave_tests.cpp
> > Lines 2413 (patched)
> > 
> >
> > Instead of to string.find(), I would prefer:
> > 
> > ```
> >   ASSERT_TRUE(value->is());
> > 
> >   JSON::Object object = value->as();
> >   EXPECT_SOME(object.find("container_id"));
> > ```

Got it!Let me fix.


- longfei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67601/#review205196
---


On 六月 27, 2018, 3:03 a.m., longfei niu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67601/
> ---
> 
> (Updated 六月 27, 2018, 3:03 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8816
> https://issues.apache.org/jira/browse/MESOS-8816
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added field container_id in ResourceUsage to agent monitor endpoint.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
>   src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed 
> 
> 
> Diff: https://reviews.apache.org/r/67601/diff/3/
> 
> 
> Testing
> ---
> 
> add unit test to src/tests/slave_tests.cpp line 2414 to test whether 
> container_id field added sucessfully or not
> 
> 
> Thanks,
> 
> longfei niu
> 
>

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-26 Thread longfei niu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67601/
---

(Updated 六月 27, 2018, 3:03 a.m.)


Review request for mesos and Gilbert Song.


Bugs: MESOS-8816
https://issues.apache.org/jira/browse/MESOS-8816


Repository: mesos


Description
---

Added field container_id in ResourceUsage to agent monitor endpoint.


Diffs (updated)
-

  src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
  src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed 


Diff: https://reviews.apache.org/r/67601/diff/3/

Changes: https://reviews.apache.org/r/67601/diff/2-3/


Testing
---

add unit test to src/tests/slave_tests.cpp line 2414 to test whether 
container_id field added sucessfully or not


Thanks,

longfei niu

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-21 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67601/#review205196
---


Fix it, then Ship it!





src/tests/slave_tests.cpp
Lines 2413 (patched)


Instead of to string.find(), I would prefer:

```
  ASSERT_TRUE(value->is());

  JSON::Object object = value->as();
  EXPECT_SOME(object.find("container_id"));
```


- Gilbert Song


On June 15, 2018, 6:20 p.m., longfei niu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67601/
> ---
> 
> (Updated June 15, 2018, 6:20 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8816
> https://issues.apache.org/jira/browse/MESOS-8816
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added field container_id in ResourceUsage to agent monitor endpoint.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
>   src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed 
> 
> 
> Diff: https://reviews.apache.org/r/67601/diff/2/
> 
> 
> Testing
> ---
> 
> add unit test to src/tests/slave_tests.cpp line 2414 to test whether 
> container_id field added sucessfully or not
> 
> 
> Thanks,
> 
> longfei niu
> 
>

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-16 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67601/#review204900
---



Patch looks great!

Reviews applied: [67552, 67601]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 16, 2018, 1:20 a.m., longfei niu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67601/
> ---
> 
> (Updated June 16, 2018, 1:20 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8816
> https://issues.apache.org/jira/browse/MESOS-8816
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added field container_id in ResourceUsage to agent monitor endpoint.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
>   src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed 
> 
> 
> Diff: https://reviews.apache.org/r/67601/diff/2/
> 
> 
> Testing
> ---
> 
> add unit test to src/tests/slave_tests.cpp line 2414 to test whether 
> container_id field added sucessfully or not
> 
> 
> Thanks,
> 
> longfei niu
> 
>

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-15 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67601/#review204890
---



PASS: Mesos patch 67601 was successfully built and tested.

Reviews applied: `['67601']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67601

- Mesos Reviewbot Windows


On June 15, 2018, 6:20 p.m., longfei niu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67601/
> ---
> 
> (Updated June 15, 2018, 6:20 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8816
> https://issues.apache.org/jira/browse/MESOS-8816
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added field container_id in ResourceUsage to agent monitor endpoint.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
>   src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed 
> 
> 
> Diff: https://reviews.apache.org/r/67601/diff/2/
> 
> 
> Testing
> ---
> 
> add unit test to src/tests/slave_tests.cpp line 2414 to test whether 
> container_id field added sucessfully or not
> 
> 
> Thanks,
> 
> longfei niu
> 
>

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-15 Thread longfei niu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67601/
---

(Updated 六月 16, 2018, 1:20 a.m.)


Review request for mesos and Gilbert Song.


Changes
---

Fixed questions


Bugs: MESOS-8816
https://issues.apache.org/jira/browse/MESOS-8816


Repository: mesos


Description (updated)
---

Added field container_id in ResourceUsage to agent monitor endpoint.


Diffs (updated)
-

  src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
  src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed 


Diff: https://reviews.apache.org/r/67601/diff/2/

Changes: https://reviews.apache.org/r/67601/diff/1-2/


Testing
---

add unit test to src/tests/slave_tests.cpp line 2414 to test whether 
container_id field added sucessfully or not


Thanks,

longfei niu

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-14 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67601/#review204808
---


Fix it, then Ship it!




LGTM! Thanks!


src/tests/slave_tests.cpp
Line 2413 (original), 2413 (patched)


no need to comment for this case



src/tests/slave_tests.cpp
Lines 2414 (patched)


newline below


- Gilbert Song


On June 14, 2018, 12:54 p.m., longfei niu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67601/
> ---
> 
> (Updated June 14, 2018, 12:54 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8816
> https://issues.apache.org/jira/browse/MESOS-8816
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added field container_id in ResourceUsage to agent /monitor/statistics 
> endpoint.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 
>   src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed 
> 
> 
> Diff: https://reviews.apache.org/r/67601/diff/1/
> 
> 
> Testing
> ---
> 
> add unit test to src/tests/slave_tests.cpp line 2414 to test whether 
> container_id field added sucessfully or not
> 
> 
> Thanks,
> 
> longfei niu
> 
>

Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.

2018-06-14 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67601/#review204802
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67601']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67601

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67601/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (111 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1105 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (33 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (73 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (675 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (698 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (730 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (754 ms total)

[--] Global test environment tear-down
[==] 988 tests from 97 test cases ran. (456940 ms total)
[  PASSED  ] 987 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] SlaveTest.StatisticsEndpointRunningExecutor

 1 FAILED TEST
  YOU HAVE 220 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67601/logs/mesos-tests-stderr.log):

```
I0614 22:40:15.808854  3928 slave.cpp:3939] Shutting down framework 
bed42b15-3ceb-4706-972f-e0671e68a7d9-
I0614 22:40:15.808854  8896 master.cpp:10863] Updating the state of task 
c6bef2a5-891a-438d-9a28-662d24e60326 of framework 
bed42b15-3ceb-4706-972f-e0671e68a7d9- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0614 22:40:15.808854  3928 slave.cI0614 22:40:15.647902  3376 exec.cpp:162] 
Version: 1.7.0
I0614 22:40:15.674870  3272 exec.cpp:236] Executor registered on agent 
bed42b15-3ceb-4706-972f-e0671e68a7d9-S0
I0614 22:40:15.677867  7988 executor.cpp:178] Received SUBSCRIBED event
I0614 22:40:15.682893  7988 executor.cpp:182] Subscribed executor on 
windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0614 22:40:15.682893  7988 executor.cpp:178] Received LAUNCH event
I0614 22:40:15.687880  7988 executor.cpp:665] Starting task 
c6bef2a5-891a-438d-9a28-662d24e60326
I0614 22:40:15.770893  7988 executor.cpp:485] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0614 22:40:15.783856  7988 executor.cpp:678] Forked command at 1020
I0614 22:40:15.810860  5840 exec.cpp:445] Executor asked to shutdown
I0614 22:40:15.812182  7988 executor.cpp:178] Received SHUTDOWN event
I0614 22:40:15.812182  7988 executor.cpp:781] Shutting down
I0614 22:40:15.812855  7988 executor.cpp:894] Sending SIGTERM to process tree 
at pid 102pp:6660] Shutting down executor 
'c6bef2a5-891a-438d-9a28-662d24e60326' of framework 
bed42b15-3ceb-4706-972f-e0671e68a7d9- at executor(1)@192.10.1.6:63508
I0614 22:40:15.810860  3928 slave.cpp:931] Agent terminating
W0614 22:40:15.810860  3928 slave.cpp:3935] Ignoring shutdown framework 
bed42b15-3ceb-4706-972f-e0671e68a7d9- because it is terminating
I0614 22:40:15.812182  8896 master.cpp:10962] Removing task 
c6bef2a5-891a-438d-9a28-662d24e60326 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework bed42b15-3ceb-4706-972f-e0671e68a7d9- on 
agent bed42b15-3ceb-4706-972f-e0671e68a7d9-S0 at slave(449)@192.10.1.6:63487 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0614 22:40:15.814859  8896 master.cpp:1293] Agent 
bed42b15-3ceb-4706-972f-e0671e68a7d9-S0 at slave(449)@192.10.1.6:63487 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0614 22:40:15.814859  8896 master.cpp:3303] Disconnecting agent 
bed42b15-3ceb-4706-972f-e0671e68a7d9-S0 at slave(449)@192.10.1.6:63487 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0614 22:40:15.815882  8896 master.cpp:3322] Deactivating agent 
bed42b15-3ceb-4706-972f-e0671e68a7d9-S0 at slave(449)@192.10.1.6:63487 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0614 22:40:15.815882  6404 hierarchical.cpp:344] Removed