Re: Review Request 69402: Fixed `CreateVolume` of the test CSI plugin.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69402/
---

(Updated Nov. 26, 2018, 8:29 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Addressed Benjamin's comments.


Bugs: MESOS-9275
https://issues.apache.org/jira/browse/MESOS-9275


Repository: mesos


Description
---

This patch makes sure that `CreateVolume` is idempotent, and check if
the specified volume capability is supported.


Diffs (updated)
-

  src/examples/test_csi_plugin.cpp 66f4ee0e2381e94bf9110d1e6e9f79eac939f683 


Diff: https://reviews.apache.org/r/69402/diff/3/

Changes: https://reviews.apache.org/r/69402/diff/2-3/


Testing
---

make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 69402: Fixed `CreateVolume` of the test CSI plugin.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69402/#review210783
---


Fix it, then Ship it!





src/examples/test_csi_plugin.cpp
Line 328 (original), 328 (patched)


Not yours, but should be
```
if (strings::contains(request->name(), string({os::PATH_SEPARATOR}))) {
```



src/examples/test_csi_plugin.cpp
Lines 337 (patched)


We could add a comment here that identity is determined by `name`; we only 
check `range` values for compatibility.


- Benjamin Bannier


On Nov. 21, 2018, 4:41 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69402/
> ---
> 
> (Updated Nov. 21, 2018, 4:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-9275
> https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch makes sure that `CreateVolume` is idempotent, and check if
> the specified volume capability is supported.
> 
> 
> Diffs
> -
> 
>   src/examples/test_csi_plugin.cpp 66f4ee0e2381e94bf9110d1e6e9f79eac939f683 
> 
> 
> Diff: https://reviews.apache.org/r/69402/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 69402: Fixed `CreateVolume` of the test CSI plugin.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69402/
---

(Updated Nov. 21, 2018, 3:41 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Check the volume capabilities outside the conditional.


Bugs: MESOS-9275
https://issues.apache.org/jira/browse/MESOS-9275


Repository: mesos


Description
---

This patch makes sure that `CreateVolume` is idempotent, and check if
the specified volume capability is supported.


Diffs (updated)
-

  src/examples/test_csi_plugin.cpp 66f4ee0e2381e94bf9110d1e6e9f79eac939f683 


Diff: https://reviews.apache.org/r/69402/diff/2/

Changes: https://reviews.apache.org/r/69402/diff/1-2/


Testing
---

make check


Thanks,

Chun-Hung Hsiao