Re: Review Request 70377: Added tests to check that framework cannot change its principal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70377/ --- (Updated April 17, 2019, 2:08 p.m.) Review request for mesos and Gastón Kleiman. Changes --- Attempt to fix the flaky test: now the scheduler does not resubscribe after getting an error. Bugs: MESOS-2842 https://issues.apache.org/jira/browse/MESOS-2842 Repository: mesos Description --- Added tests to check that framework cannot change its principal. Diffs (updated) - src/tests/fault_tolerance_tests.cpp 91cc9a2bcb98562cfdb60df229a88a0dabb34792 src/tests/http_fault_tolerance_tests.cpp d3db8a6efa0e56dd332d8cae48123b173d347cf2 src/tests/mesos.hpp d8c17eabdabd14f428946917d56eb8f261bfbd2a Diff: https://reviews.apache.org/r/70377/diff/5/ Changes: https://reviews.apache.org/r/70377/diff/4-5/ Testing --- Ran make check - these two tests fail, others don't. Thanks, Andrei Sekretenko
Re: Review Request 70377: Added tests to check that framework cannot change its principal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70377/ --- (Updated April 15, 2019, 12:19 p.m.) Review request for mesos and Gastón Kleiman. Bugs: MESOS-2842 https://issues.apache.org/jira/browse/MESOS-2842 Repository: mesos Description --- Added tests to check that framework cannot change its principal. Diffs (updated) - src/tests/fault_tolerance_tests.cpp 91cc9a2bcb98562cfdb60df229a88a0dabb34792 src/tests/http_fault_tolerance_tests.cpp d3db8a6efa0e56dd332d8cae48123b173d347cf2 src/tests/mesos.hpp d8c17eabdabd14f428946917d56eb8f261bfbd2a Diff: https://reviews.apache.org/r/70377/diff/4/ Changes: https://reviews.apache.org/r/70377/diff/3-4/ Testing --- Ran make check - these two tests fail, others don't. Thanks, Andrei Sekretenko
Re: Review Request 70377: Added tests to check that framework cannot change its principal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70377/#review214641 --- Ship it! Ship It! - Gastón Kleiman On April 10, 2019, 8:31 a.m., Andrei Sekretenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70377/ > --- > > (Updated April 10, 2019, 8:31 a.m.) > > > Review request for mesos and Gastón Kleiman. > > > Bugs: MESOS-2842 > https://issues.apache.org/jira/browse/MESOS-2842 > > > Repository: mesos > > > Description > --- > > Added tests to check that framework cannot change its principal. > > > Diffs > - > > src/tests/fault_tolerance_tests.cpp > 91cc9a2bcb98562cfdb60df229a88a0dabb34792 > src/tests/http_fault_tolerance_tests.cpp > d3db8a6efa0e56dd332d8cae48123b173d347cf2 > src/tests/mesos.hpp d8c17eabdabd14f428946917d56eb8f261bfbd2a > > > Diff: https://reviews.apache.org/r/70377/diff/3/ > > > Testing > --- > > Ran make check - these two tests fail, others don't. > > > Thanks, > > Andrei Sekretenko > >
Re: Review Request 70377: Added tests to check that framework cannot change its principal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70377/ --- (Updated April 10, 2019, 3:31 p.m.) Review request for mesos and Gastón Kleiman. Changes --- Converted the HTTP API test to using MockHTTPSCheduler. Bugs: MESOS-2842 https://issues.apache.org/jira/browse/MESOS-2842 Repository: mesos Description --- Added tests to check that framework cannot change its principal. Diffs (updated) - src/tests/fault_tolerance_tests.cpp 91cc9a2bcb98562cfdb60df229a88a0dabb34792 src/tests/http_fault_tolerance_tests.cpp d3db8a6efa0e56dd332d8cae48123b173d347cf2 src/tests/mesos.hpp d8c17eabdabd14f428946917d56eb8f261bfbd2a Diff: https://reviews.apache.org/r/70377/diff/3/ Changes: https://reviews.apache.org/r/70377/diff/2-3/ Testing --- Ran make check - these two tests fail, others don't. Thanks, Andrei Sekretenko
Re: Review Request 70377: Added tests to check that framework cannot change its principal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70377/ --- (Updated April 5, 2019, 3:10 p.m.) Review request for mesos and Gastón Kleiman. Summary (updated) - Added tests to check that framework cannot change its principal. Bugs: MESOS-2842 https://issues.apache.org/jira/browse/MESOS-2842 Repository: mesos Description (updated) --- Added tests to check that framework cannot change its principal. Diffs (updated) - src/tests/fault_tolerance_tests.cpp 91cc9a2bcb98562cfdb60df229a88a0dabb34792 src/tests/scheduler_http_api_tests.cpp d5b5eec0df0c01c4706c9bb4438c9daa305bd376 Diff: https://reviews.apache.org/r/70377/diff/2/ Changes: https://reviews.apache.org/r/70377/diff/1-2/ Testing --- Ran make check - these two tests fail, others don't. Thanks, Andrei Sekretenko
