Re: Review Request 32891: Support for entering and configuring a Linux chroot.

2015-06-22 Thread Ian Downes

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32891/
---

(Updated June 22, 2015, 9:38 a.m.)


Review request for mesos, Chi Zhang, Jay Buffington, Jie Yu, and James Peach.


Bugs: MESOS-2350
https://issues.apache.org/jira/browse/MESOS-2350


Repository: mesos


Description
---

Support for entering and configuring a Linux chroot.


Diffs (updated)
-

  src/linux/fs.hpp d7832a4b3761c48be6c1ccef58a30ee31c70dc1b 
  src/linux/fs.cpp 568565f878b34708170a886dc4d62849aa01f263 

Diff: https://reviews.apache.org/r/32891/diff/


Testing
---


Thanks,

Ian Downes



Re: Review Request 32891: Support for entering and configuring a Linux chroot.

2015-05-12 Thread Ian Downes

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32891/
---

(Updated May 12, 2015, 5:22 p.m.)


Review request for mesos, Chi Zhang, Jay Buffington, Jie Yu, and James Peach.


Bugs: MESOS-2350
https://issues.apache.org/jira/browse/MESOS-2350


Repository: mesos


Description
---

Support for entering and configuring a Linux chroot.


Diffs (updated)
-

  src/linux/fs.hpp d7832a4b3761c48be6c1ccef58a30ee31c70dc1b 
  src/linux/fs.cpp 1c9cf3f2ffead37148e4f6a81cefdbb97f679b09 

Diff: https://reviews.apache.org/r/32891/diff/


Testing
---


Thanks,

Ian Downes



Re: Review Request 32891: Support for entering and configuring a Linux chroot.

2015-05-12 Thread Ian Downes


> On April 13, 2015, 2:30 p.m., Jie Yu wrote:
> > src/linux/fs.cpp, line 432
> > 
> >
> > Copy comments from the other review, can you support `Option 
> > options` for fs::mount as well?

Decided to add as an alternate mount() version (wrapper) to preserve the 
original functionality where data is generally void*.


- Ian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32891/#review79947
---


On April 6, 2015, 11 a.m., Ian Downes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32891/
> ---
> 
> (Updated April 6, 2015, 11 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Jay Buffington, Jie Yu, and James Peach.
> 
> 
> Bugs: MESOS-2350
> https://issues.apache.org/jira/browse/MESOS-2350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for entering and configuring a Linux chroot.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp d7832a4b3761c48be6c1ccef58a30ee31c70dc1b 
>   src/linux/fs.cpp 1c9cf3f2ffead37148e4f6a81cefdbb97f679b09 
> 
> Diff: https://reviews.apache.org/r/32891/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Downes
> 
>