Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/ --- (Updated May 27, 2015, 6:05 p.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-2754 https://issues.apache.org/jira/browse/MESOS-2754 Repository: mesos Description --- Remove duplicate constant string references to mesos-containerizer, net_tcp_rtt_... Diffs - src/slave/containerizer/isolators/network/port_mapping.hpp c72fb47f60f40cda8d84a10497b9133f83cf018e src/slave/containerizer/isolators/network/port_mapping.cpp 49e983edab598e2ac487bb488fdd12840a9e7dfc src/slave/containerizer/mesos/containerizer.hpp 3e18617b0dbac58176bfd41dc550898eb6a4a79e src/slave/containerizer/mesos/containerizer.cpp 696e359de66305512eedf8e269543fafa21f4bc3 src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 Diff: https://reviews.apache.org/r/34432/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/#review85295 --- Ship it! Modulo Vinod's comment - Chi Zhang On May 22, 2015, 5:28 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/ --- (Updated May 22, 2015, 5:28 p.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-2754 https://issues.apache.org/jira/browse/MESOS-2754 Repository: mesos Description --- Remove duplicate constant string references to mesos-containerizer, net_tcp_rtt_... Diffs - src/slave/containerizer/isolators/network/port_mapping.hpp c72fb47f60f40cda8d84a10497b9133f83cf018e src/slave/containerizer/isolators/network/port_mapping.cpp 49e983edab598e2ac487bb488fdd12840a9e7dfc src/slave/containerizer/mesos/containerizer.hpp 3e18617b0dbac58176bfd41dc550898eb6a4a79e src/slave/containerizer/mesos/containerizer.cpp 696e359de66305512eedf8e269543fafa21f4bc3 src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 Diff: https://reviews.apache.org/r/34432/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/#review84885 --- src/slave/containerizer/isolators/network/port_mapping.hpp https://reviews.apache.org/r/34432/#comment136331 Please state why they are exposed. src/slave/containerizer/isolators/network/port_mapping.cpp https://reviews.apache.org/r/34432/#comment136332 Why not be consistent with the other const string inlines? - Ian Downes On May 21, 2015, 4:32 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/ --- (Updated May 21, 2015, 4:32 p.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-2754 https://issues.apache.org/jira/browse/MESOS-2754 Repository: mesos Description --- Remove duplicate constant string references to mesos-containerizer, net_tcp_rtt_... Diffs - src/slave/containerizer/isolators/network/port_mapping.hpp c72fb47f60f40cda8d84a10497b9133f83cf018e src/slave/containerizer/isolators/network/port_mapping.cpp 49e983edab598e2ac487bb488fdd12840a9e7dfc src/slave/containerizer/mesos/containerizer.hpp 3e18617b0dbac58176bfd41dc550898eb6a4a79e src/slave/containerizer/mesos/containerizer.cpp 696e359de66305512eedf8e269543fafa21f4bc3 src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 Diff: https://reviews.apache.org/r/34432/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/ --- (Updated May 22, 2015, 5:28 p.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Changes --- Address review comment Bugs: MESOS-2754 https://issues.apache.org/jira/browse/MESOS-2754 Repository: mesos Description --- Remove duplicate constant string references to mesos-containerizer, net_tcp_rtt_... Diffs (updated) - src/slave/containerizer/isolators/network/port_mapping.hpp c72fb47f60f40cda8d84a10497b9133f83cf018e src/slave/containerizer/isolators/network/port_mapping.cpp 49e983edab598e2ac487bb488fdd12840a9e7dfc src/slave/containerizer/mesos/containerizer.hpp 3e18617b0dbac58176bfd41dc550898eb6a4a79e src/slave/containerizer/mesos/containerizer.cpp 696e359de66305512eedf8e269543fafa21f4bc3 src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 Diff: https://reviews.apache.org/r/34432/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer
On May 22, 2015, 7:31 a.m., Ian Downes wrote: src/slave/containerizer/isolators/network/port_mapping.hpp, lines 67-73 https://reviews.apache.org/r/34432/diff/1/?file=965780#file965780line67 Please state why they are exposed. The same literarl strings are used in src/tests/port_mapping.cpp. On May 22, 2015, 7:31 a.m., Ian Downes wrote: src/slave/containerizer/isolators/network/port_mapping.cpp, lines 113-118 https://reviews.apache.org/r/34432/diff/1/?file=965781#file965781line113 Why not be consistent with the other const string inlines? Const char array is the preferred way to do it. - Paul --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/#review84885 --- On May 21, 2015, 11:32 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/ --- (Updated May 21, 2015, 11:32 p.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-2754 https://issues.apache.org/jira/browse/MESOS-2754 Repository: mesos Description --- Remove duplicate constant string references to mesos-containerizer, net_tcp_rtt_... Diffs - src/slave/containerizer/isolators/network/port_mapping.hpp c72fb47f60f40cda8d84a10497b9133f83cf018e src/slave/containerizer/isolators/network/port_mapping.cpp 49e983edab598e2ac487bb488fdd12840a9e7dfc src/slave/containerizer/mesos/containerizer.hpp 3e18617b0dbac58176bfd41dc550898eb6a4a79e src/slave/containerizer/mesos/containerizer.cpp 696e359de66305512eedf8e269543fafa21f4bc3 src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 Diff: https://reviews.apache.org/r/34432/diff/ Testing --- make check Thanks, Paul Brett
Review Request 34432: Remove duplicate constant string references to mesos-containerizer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-2754 https://issues.apache.org/jira/browse/MESOS-2754 Repository: mesos Description --- Remove duplicate constant string references to mesos-containerizer, net_tcp_rtt_... Diffs - src/slave/containerizer/isolators/network/port_mapping.hpp c72fb47f60f40cda8d84a10497b9133f83cf018e src/slave/containerizer/isolators/network/port_mapping.cpp 49e983edab598e2ac487bb488fdd12840a9e7dfc src/slave/containerizer/mesos/containerizer.hpp 3e18617b0dbac58176bfd41dc550898eb6a4a79e src/slave/containerizer/mesos/containerizer.cpp 696e359de66305512eedf8e269543fafa21f4bc3 src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 Diff: https://reviews.apache.org/r/34432/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/#review84609 --- Bad patch! Reviews applied: [34321, 34426, 34321] Failed command: ./support/apply-review.sh -n -r 34321 Error: 2015-05-20 22:55:02 URL:https://reviews.apache.org/r/34321/diff/raw/ [28663/28663] - 34321.patch [1] error: patch failed: src/linux/routing/filter/basic.hpp:30 error: src/linux/routing/filter/basic.hpp: patch does not apply error: patch failed: src/linux/routing/filter/basic.cpp:33 error: src/linux/routing/filter/basic.cpp: patch does not apply error: patch failed: src/linux/routing/filter/filter.hpp:29 error: src/linux/routing/filter/filter.hpp: patch does not apply error: patch failed: src/linux/routing/filter/handle.hpp:19 error: src/linux/routing/filter/handle.hpp: patch does not apply error: patch failed: src/linux/routing/filter/icmp.hpp:31 error: src/linux/routing/filter/icmp.hpp: patch does not apply error: patch failed: src/linux/routing/filter/icmp.cpp:37 error: src/linux/routing/filter/icmp.cpp: patch does not apply error: patch failed: src/linux/routing/filter/internal.hpp:58 error: src/linux/routing/filter/internal.hpp: patch does not apply error: patch failed: src/linux/routing/filter/ip.hpp:38 error: src/linux/routing/filter/ip.hpp: patch does not apply error: patch failed: src/linux/routing/filter/ip.cpp:33 error: src/linux/routing/filter/ip.cpp: patch does not apply error: src/linux/routing/handle.hpp: already exists in index error: patch failed: src/linux/routing/queueing/handle.hpp:19 error: src/linux/routing/queueing/handle.hpp: patch does not apply error: patch failed: src/tests/routing_tests.cpp:42 error: src/tests/routing_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On May 20, 2015, 9:57 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/ --- (Updated May 20, 2015, 9:57 p.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-2754 https://issues.apache.org/jira/browse/MESOS-2754 Repository: mesos Description --- Remove duplicate constant string references to mesos-containerizer, net_tcp_rtt_... Diffs - src/slave/containerizer/isolators/network/port_mapping.hpp c72fb47f60f40cda8d84a10497b9133f83cf018e src/slave/containerizer/isolators/network/port_mapping.cpp 49e983edab598e2ac487bb488fdd12840a9e7dfc src/slave/containerizer/mesos/containerizer.hpp 3e18617b0dbac58176bfd41dc550898eb6a4a79e src/slave/containerizer/mesos/containerizer.cpp 696e359de66305512eedf8e269543fafa21f4bc3 src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 Diff: https://reviews.apache.org/r/34432/diff/ Testing --- make check Thanks, Paul Brett
