Re: Review Request 34436: Factor out launch helper for easier reuse
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34436/#review84884
---
Where will this get re-used?
src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34436/#comment136329
It doesn't use the MesosContainerizer, it uses a helper that the MC uses.
src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34436/#comment136325
Why this change? This function shouldn't take a Try.
src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34436/#comment136330
{.., ..}?
src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34436/#comment136327
s/we/We/
s/clutter/noise
src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34436/#comment136328
How much noise is there? This seems onerous to users to modify source and
recompile to enable some debug output...
src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34436/#comment136326
This should be done by the caller when the launcher is created, indeed it's
done with a number of CHECK_SOMEs. What's the motivation to changing this
function?
- Ian Downes
On May 21, 2015, 4:31 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34436/
---
(Updated May 21, 2015, 4:31 p.m.)
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Bugs: MESOS-2332
https://issues.apache.org/jira/browse/MESOS-2332
Repository: mesos
Description
---
Factor out launch helper for easier reuse
Diffs
-
src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502
Diff: https://reviews.apache.org/r/34436/diff/
Testing
---
make check
Thanks,
Paul Brett
Re: Review Request 34436: Factor out launch helper for easier reuse
On May 22, 2015, 7:27 a.m., Ian Downes wrote: src/tests/port_mapping_tests.cpp, lines 186-187 https://reviews.apache.org/r/34436/diff/1/?file=966863#file966863line186 How much noise is there? This seems onerous to users to modify source and recompile to enable some debug output... Output goes down from around 160 lines per test to 2 lines. The advantage of removing the output is that you can see the test progress. The information that is output to the screen by default has so far been insufficient to a aid in debugging. - Paul --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34436/#review84884 --- On May 21, 2015, 11:31 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34436/ --- (Updated May 21, 2015, 11:31 p.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-2332 https://issues.apache.org/jira/browse/MESOS-2332 Repository: mesos Description --- Factor out launch helper for easier reuse Diffs - src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 Diff: https://reviews.apache.org/r/34436/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 34436: Factor out launch helper for easier reuse
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34436/ --- (Updated May 22, 2015, 8:48 p.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Changes --- Address review comments Bugs: MESOS-2332 https://issues.apache.org/jira/browse/MESOS-2332 Repository: mesos Description --- Factor out launch helper for easier reuse Diffs (updated) - src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 Diff: https://reviews.apache.org/r/34436/diff/ Testing --- make check Thanks, Paul Brett
Review Request 34436: Factor out launch helper for easier reuse
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34436/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-2332 https://issues.apache.org/jira/browse/MESOS-2332 Repository: mesos Description --- Factor out launch helper for easier reuse Diffs - src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 Diff: https://reviews.apache.org/r/34436/diff/ Testing --- make check Thanks, Paul Brett
