Re: Review Request 35687: Added capabilities to state.json

2015-07-15 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review91789
---

Ship it!


minor nits. i'll fix them and commit it for you. thanks.


src/master/http.cpp (line 125)


'framework' should be aligned with 'const'.



src/tests/master_tests.cpp (line 2957)


s/capabilityName/capabilityType/


- Vinod Kone


On July 15, 2015, 5:20 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35687/
> ---
> 
> (Updated July 15, 2015, 5:20 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Vinod Kone.
> 
> 
> Bugs: MESOS-2900
> https://issues.apache.org/jira/browse/MESOS-2900
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities to state.json and test for the same
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
>   src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 
> 
> Diff: https://reviews.apache.org/r/35687/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 35687: Added capabilities to state.json

2015-07-15 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review91774
---


Patch looks great!

Reviews applied: [35687]

All tests passed.

- Mesos ReviewBot


On July 15, 2015, 5:20 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35687/
> ---
> 
> (Updated July 15, 2015, 5:20 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Vinod Kone.
> 
> 
> Bugs: MESOS-2900
> https://issues.apache.org/jira/browse/MESOS-2900
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities to state.json and test for the same
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
>   src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 
> 
> Diff: https://reviews.apache.org/r/35687/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 35687: Added capabilities to state.json

2015-07-15 Thread Aditi Dixit 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/
---

(Updated July 15, 2015, 5:20 p.m.)


Review request for mesos, Marco Massenzio and Vinod Kone.


Bugs: MESOS-2900
https://issues.apache.org/jira/browse/MESOS-2900


Repository: mesos


Description
---

Added capabilities to state.json and test for the same


Diffs (updated)
-

  src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
  src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 

Diff: https://reviews.apache.org/r/35687/diff/


Testing
---

make check


Thanks,

Aditi Dixit

Re: Review Request 35687: Added capabilities to state.json

2015-07-13 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review91508
---


LGTM modulo Alex's reviews. Fix them and I'll commit this for you.

- Vinod Kone


On July 12, 2015, 6:25 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35687/
> ---
> 
> (Updated July 12, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Vinod Kone.
> 
> 
> Bugs: MESOS-2900
> https://issues.apache.org/jira/browse/MESOS-2900
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities to state.json and test for the same
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
>   src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 
> 
> Diff: https://reviews.apache.org/r/35687/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 35687: Added capabilities to state.json

2015-07-13 Thread Alexander Rukletsov 


> On June 20, 2015, 10:50 a.m., Alexander Rukletsov wrote:
> > src/master/http.cpp, line 124
> > 
> >
> > Let's make it `foreachvalue` for consistency.
> 
> Aditi Dixit wrote:
> Hi,
> I'm sorry, but I'm unable to understand how foreachvalue works.

No worries, I was referring to `foreach` anyway : ).


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review88640
---


On July 12, 2015, 6:25 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35687/
> ---
> 
> (Updated July 12, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Vinod Kone.
> 
> 
> Bugs: MESOS-2900
> https://issues.apache.org/jira/browse/MESOS-2900
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities to state.json and test for the same
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
>   src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 
> 
> Diff: https://reviews.apache.org/r/35687/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 35687: Added capabilities to state.json

2015-07-13 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review91436
---



src/master/http.cpp (line 124)


Please add a space between `foreach` and a bracket for consistency: 
`foreach (...`



src/tests/master_tests.cpp (line 2949)


We tend to limit comments to 70 chars, this line looks longer. Mind 
wrapping it?



src/tests/master_tests.cpp (line 2997)


We use `lowerCamelCase` for variable names, please rename.



src/tests/master_tests.cpp (line 3001)


Instead of the hardcoded constant, it makes sense to use 
`FrameworkInfo::Capability::Type_Name()` IMO.


- Alexander Rukletsov


On July 12, 2015, 6:25 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35687/
> ---
> 
> (Updated July 12, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Vinod Kone.
> 
> 
> Bugs: MESOS-2900
> https://issues.apache.org/jira/browse/MESOS-2900
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities to state.json and test for the same
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
>   src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 
> 
> Diff: https://reviews.apache.org/r/35687/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 35687: Added capabilities to state.json

2015-07-12 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review91414
---


Patch looks great!

Reviews applied: [35687]

All tests passed.

- Mesos ReviewBot


On July 12, 2015, 6:25 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35687/
> ---
> 
> (Updated July 12, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Vinod Kone.
> 
> 
> Bugs: MESOS-2900
> https://issues.apache.org/jira/browse/MESOS-2900
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities to state.json and test for the same
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
>   src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 
> 
> Diff: https://reviews.apache.org/r/35687/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 35687: Added capabilities to state.json

2015-07-12 Thread Aditi Dixit 


> On June 20, 2015, 10:50 a.m., Alexander Rukletsov wrote:
> > src/master/http.cpp, line 124
> > 
> >
> > Let's make it `foreachvalue` for consistency.

Hi,
I'm sorry, but I'm unable to understand how foreachvalue works.


- Aditi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review88640
---


On July 12, 2015, 6:25 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35687/
> ---
> 
> (Updated July 12, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Vinod Kone.
> 
> 
> Bugs: MESOS-2900
> https://issues.apache.org/jira/browse/MESOS-2900
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities to state.json and test for the same
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
>   src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 
> 
> Diff: https://reviews.apache.org/r/35687/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 35687: Added capabilities to state.json

2015-07-12 Thread Aditi Dixit 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/
---

(Updated July 12, 2015, 6:25 p.m.)


Review request for mesos, Marco Massenzio and Vinod Kone.


Bugs: MESOS-2900
https://issues.apache.org/jira/browse/MESOS-2900


Repository: mesos


Description
---

Added capabilities to state.json and test for the same


Diffs (updated)
-

  src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
  src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 

Diff: https://reviews.apache.org/r/35687/diff/


Testing
---

make check


Thanks,

Aditi Dixit

Re: Review Request 35687: Added capabilities to state.json

2015-07-12 Thread Alexander Rukletsov 


> On July 12, 2015, 10:48 a.m., Alexander Rukletsov wrote:
> > src/master/http.cpp, lines 124-125
> > 
> >
> > Hm, I wonder why didn't it work, did you get a compilation error? For 
> > example, we have the following code in the master, which compiles fine:
> > ```
> > case Offer::Operation::LAUNCH: {
> >   foreach (const TaskInfo& task, operation.launch().task_infos()) {
> > ...
> > ```

To @Vinod's comment above.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review91408
---


On July 9, 2015, 4:04 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35687/
> ---
> 
> (Updated July 9, 2015, 4:04 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Vinod Kone.
> 
> 
> Bugs: MESOS-2900
> https://issues.apache.org/jira/browse/MESOS-2900
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities to state.json and test for the same
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
>   src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 
> 
> Diff: https://reviews.apache.org/r/35687/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 35687: Added capabilities to state.json

2015-07-12 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review91408
---



src/master/http.cpp (lines 124 - 125)


Hm, I wonder why didn't it work, did you get a compilation error? For 
example, we have the following code in the master, which compiles fine:
```
case Offer::Operation::LAUNCH: {
  foreach (const TaskInfo& task, operation.launch().task_infos()) {
...
```


- Alexander Rukletsov


On July 9, 2015, 4:04 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35687/
> ---
> 
> (Updated July 9, 2015, 4:04 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Vinod Kone.
> 
> 
> Bugs: MESOS-2900
> https://issues.apache.org/jira/browse/MESOS-2900
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities to state.json and test for the same
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
>   src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 
> 
> Diff: https://reviews.apache.org/r/35687/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 35687: Added capabilities to state.json

2015-07-11 Thread Aditi Dixit 


> On July 9, 2015, 4:26 p.m., Vinod Kone wrote:
> > src/master/http.cpp, lines 124-125
> > 
> >
> > were you not able to use 'foreach' here?
> > 
> > foreach(FrameworkInfo::Capability& capability, 
> > framework.info.capabilities()) {
> > 
> > }

No. I think the problem is occurring because capabilities is a repeated field.


- Aditi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review91113
---


On July 9, 2015, 4:04 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35687/
> ---
> 
> (Updated July 9, 2015, 4:04 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Vinod Kone.
> 
> 
> Bugs: MESOS-2900
> https://issues.apache.org/jira/browse/MESOS-2900
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities to state.json and test for the same
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
>   src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 
> 
> Diff: https://reviews.apache.org/r/35687/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 35687: Added capabilities to state.json

2015-07-09 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review91128
---


Patch looks great!

Reviews applied: [35687]

All tests passed.

- Mesos ReviewBot


On July 9, 2015, 4:04 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35687/
> ---
> 
> (Updated July 9, 2015, 4:04 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Vinod Kone.
> 
> 
> Bugs: MESOS-2900
> https://issues.apache.org/jira/browse/MESOS-2900
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities to state.json and test for the same
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
>   src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 
> 
> Diff: https://reviews.apache.org/r/35687/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 35687: Added capabilities to state.json

2015-07-09 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review91113
---



src/master/http.cpp (lines 124 - 125)


were you not able to use 'foreach' here?

foreach(FrameworkInfo::Capability& capability, 
framework.info.capabilities()) {

}



src/tests/master_tests.cpp (lines 2994 - 2996)


pull this below #2998 so that webui_url testing is all in one block.

also, you captured 'Capability' into an JSON::array but doing nothing with 
it? did you forget to add an EXPECT_EQ to make sure this value is the same as 
the one you added in #2958?


- Vinod Kone


On July 9, 2015, 4:04 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35687/
> ---
> 
> (Updated July 9, 2015, 4:04 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Vinod Kone.
> 
> 
> Bugs: MESOS-2900
> https://issues.apache.org/jira/browse/MESOS-2900
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities to state.json and test for the same
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
>   src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 
> 
> Diff: https://reviews.apache.org/r/35687/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 35687: Added capabilities to state.json

2015-07-09 Thread Aditi Dixit 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/
---

(Updated July 9, 2015, 4:04 p.m.)


Review request for mesos, Marco Massenzio and Vinod Kone.


Bugs: MESOS-2900
https://issues.apache.org/jira/browse/MESOS-2900


Repository: mesos


Description (updated)
---

Added capabilities to state.json and test for the same


Diffs (updated)
-

  src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
  src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 

Diff: https://reviews.apache.org/r/35687/diff/


Testing
---

make check


Thanks,

Aditi Dixit

Re: Review Request 35687: Added capabilities to state.json

2015-06-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review88666
---


Patch looks great!

Reviews applied: [35687]

All tests passed.

- Mesos ReviewBot


On June 20, 2015, 7:14 a.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35687/
> ---
> 
> (Updated June 20, 2015, 7:14 a.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Vinod Kone.
> 
> 
> Bugs: MESOS-2900
> https://issues.apache.org/jira/browse/MESOS-2900
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities to state.json
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 8b694137fe3491e4d40af0f31ee87d3e3ef8ab5a 
> 
> Diff: https://reviews.apache.org/r/35687/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 35687: Added capabilities to state.json

2015-06-20 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review88640
---



src/master/http.cpp (line 124)


Let's make it `foreachvalue` for consistency.


- Alexander Rukletsov


On June 20, 2015, 7:14 a.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35687/
> ---
> 
> (Updated June 20, 2015, 7:14 a.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Vinod Kone.
> 
> 
> Bugs: MESOS-2900
> https://issues.apache.org/jira/browse/MESOS-2900
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities to state.json
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 8b694137fe3491e4d40af0f31ee87d3e3ef8ab5a 
> 
> Diff: https://reviews.apache.org/r/35687/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Review Request 35687: Added capabilities to state.json

2015-06-20 Thread Aditi Dixit 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/
---

Review request for mesos, Marco Massenzio and Vinod Kone.


Bugs: MESOS-2900
https://issues.apache.org/jira/browse/MESOS-2900


Repository: mesos


Description
---

Added capabilities to state.json


Diffs
-

  src/master/http.cpp 8b694137fe3491e4d40af0f31ee87d3e3ef8ab5a 

Diff: https://reviews.apache.org/r/35687/diff/


Testing
---

make check


Thanks,

Aditi Dixit