Review Request 35750: Added a test to verify recovering mixed known and unknown orphans for port mapping isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35750/ --- Review request for mesos, Chi Zhang, Paul Brett, and Vinod Kone. Bugs: MESOS-2914 https://issues.apache.org/jira/browse/MESOS-2914 Repository: mesos Description --- Added a test to verify recovering mixed known and unknown orphans for port mapping isolator. Diffs - src/tests/port_mapping_tests.cpp 6caab134fdbf3894f9fae801daf9491a13888c7d Diff: https://reviews.apache.org/r/35750/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 35750: Added a test to verify recovering mixed known and unknown orphans for port mapping isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35750/#review88879 --- Patch looks great! Reviews applied: [35749, 35750] All tests passed. - Mesos ReviewBot On June 22, 2015, 11:09 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35750/ > --- > > (Updated June 22, 2015, 11:09 p.m.) > > > Review request for mesos, Chi Zhang, Paul Brett, and Vinod Kone. > > > Bugs: MESOS-2914 > https://issues.apache.org/jira/browse/MESOS-2914 > > > Repository: mesos > > > Description > --- > > Added a test to verify recovering mixed known and unknown orphans for port > mapping isolator. > > > Diffs > - > > src/tests/port_mapping_tests.cpp 6caab134fdbf3894f9fae801daf9491a13888c7d > > Diff: https://reviews.apache.org/r/35750/diff/ > > > Testing > --- > > sudo make check > > > Thanks, > > Jie Yu > >
Re: Review Request 35750: Added a test to verify recovering mixed known and unknown orphans for port mapping isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35750/#review0 --- Ship it! It's not very clean to reply on `___recover`'s implementation details IMO, but looks like this is not the first time we test based on this. - Chi Zhang On June 22, 2015, 11:09 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35750/ > --- > > (Updated June 22, 2015, 11:09 p.m.) > > > Review request for mesos, Chi Zhang, Paul Brett, and Vinod Kone. > > > Bugs: MESOS-2914 > https://issues.apache.org/jira/browse/MESOS-2914 > > > Repository: mesos > > > Description > --- > > Added a test to verify recovering mixed known and unknown orphans for port > mapping isolator. > > > Diffs > - > > src/tests/port_mapping_tests.cpp 6caab134fdbf3894f9fae801daf9491a13888c7d > > Diff: https://reviews.apache.org/r/35750/diff/ > > > Testing > --- > > sudo make check > > > Thanks, > > Jie Yu > >
