Re: Review Request 36041: The "configure" phase breaks with the IBM JVM.

2016-07-09 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36041/#review141473
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On July 22, 2015, 7:29 a.m., Jihun Kang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36041/
> ---
> 
> (Updated July 22, 2015, 7:29 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2216
> https://issues.apache.org/jira/browse/MESOS-2216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The "configure" phase breaks with the IBM JVM.
> 
> 
> Diffs
> -
> 
>   configure.ac 92909580ea735a1ccffbe03a2eb44e3d07566488 
> 
> Diff: https://reviews.apache.org/r/36041/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jihun Kang
> 
>



Re: Review Request 36041: The "configure" phase breaks with the IBM JVM.

2015-07-22 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36041/#review92566
---


Patch looks great!

Reviews applied: [36041]

All tests passed.

- Mesos ReviewBot


On July 22, 2015, 7:29 a.m., Jihun Kang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36041/
> ---
> 
> (Updated July 22, 2015, 7:29 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2216
> https://issues.apache.org/jira/browse/MESOS-2216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The "configure" phase breaks with the IBM JVM.
> 
> 
> Diffs
> -
> 
>   configure.ac 92909580ea735a1ccffbe03a2eb44e3d07566488 
> 
> Diff: https://reviews.apache.org/r/36041/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jihun Kang
> 
>



Re: Review Request 36041: The "configure" phase breaks with the IBM JVM.

2015-07-22 Thread Jihun Kang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36041/
---

(Updated July 22, 2015, 7:29 a.m.)


Review request for mesos.


Bugs: MESOS-2216
https://issues.apache.org/jira/browse/MESOS-2216


Repository: mesos


Description
---

The "configure" phase breaks with the IBM JVM.


Diffs (updated)
-

  configure.ac 92909580ea735a1ccffbe03a2eb44e3d07566488 

Diff: https://reviews.apache.org/r/36041/diff/


Testing
---


Thanks,

Jihun Kang



Re: Review Request 36041: The "configure" phase breaks with the IBM JVM.

2015-07-15 Thread Jihun Kang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36041/
---

(Updated July 16, 2015, 1:54 a.m.)


Review request for mesos.


Bugs: MESOS-2216
https://issues.apache.org/jira/browse/MESOS-2216


Repository: mesos


Description
---

The "configure" phase breaks with the IBM JVM.


Diffs
-

  configure.ac 92909580ea735a1ccffbe03a2eb44e3d07566488 

Diff: https://reviews.apache.org/r/36041/diff/


Testing
---


Thanks,

Jihun Kang



Re: Review Request 36041: The "configure" phase breaks with the IBM JVM.

2015-07-15 Thread Jihun Kang


> On July 9, 2015, 7:11 a.m., Till Toenshoff wrote:
> > Do we have a JIRA issue that would cover this issue? If so, please add it 
> > to this review-request within the "Bugs" section. If there is no JIRA, 
> > please create one that describes the problem briefly.
> > 
> > Next question; once the configuration phase is patched like this, do the 
> > tests then fully work using the IBM JVM? In other words, right now I don't 
> > know if this patch is sufficient to fully support the IBM JVM.

Sorry for late response. I will update a JIRA issue. On the testing, I already 
tested IBM JVM 1.6 and 1.7, and you can also download IBM JDK for linux from 
the following link. 
http://www.ibm.com/developerworks/java/jdk/linux/download.html


- Jihun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36041/#review91071
---


On June 30, 2015, 9:09 a.m., Jihun Kang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36041/
> ---
> 
> (Updated June 30, 2015, 9:09 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The "configure" phase breaks with the IBM JVM.
> 
> 
> Diffs
> -
> 
>   configure.ac 92909580ea735a1ccffbe03a2eb44e3d07566488 
> 
> Diff: https://reviews.apache.org/r/36041/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jihun Kang
> 
>



Re: Review Request 36041: The "configure" phase breaks with the IBM JVM.

2015-07-09 Thread Till Toenshoff

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36041/#review91071
---


Do we have a JIRA issue that would cover this issue? If so, please add it to 
this review-request within the "Bugs" section. If there is no JIRA, please 
create one that describes the problem briefly.

Next question; once the configuration phase is patched like this, do the tests 
then fully work using the IBM JVM? In other words, right now I don't know if 
this patch is sufficient to fully support the IBM JVM.

- Till Toenshoff


On June 30, 2015, 9:09 a.m., Jihun Kang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36041/
> ---
> 
> (Updated June 30, 2015, 9:09 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The "configure" phase breaks with the IBM JVM.
> 
> 
> Diffs
> -
> 
>   configure.ac 92909580ea735a1ccffbe03a2eb44e3d07566488 
> 
> Diff: https://reviews.apache.org/r/36041/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jihun Kang
> 
>



Re: Review Request 36041: The "configure" phase breaks with the IBM JVM.

2015-06-30 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36041/#review8
---


Patch looks great!

Reviews applied: [36041]

All tests passed.

- Mesos ReviewBot


On June 30, 2015, 9:09 a.m., Jihun Kang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36041/
> ---
> 
> (Updated June 30, 2015, 9:09 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The "configure" phase breaks with the IBM JVM.
> 
> 
> Diffs
> -
> 
>   configure.ac 92909580ea735a1ccffbe03a2eb44e3d07566488 
> 
> Diff: https://reviews.apache.org/r/36041/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jihun Kang
> 
>



Review Request 36041: The "configure" phase breaks with the IBM JVM.

2015-06-30 Thread Jihun Kang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36041/
---

Review request for mesos.


Repository: mesos


Description
---

The "configure" phase breaks with the IBM JVM.


Diffs
-

  configure.ac 92909580ea735a1ccffbe03a2eb44e3d07566488 

Diff: https://reviews.apache.org/r/36041/diff/


Testing
---


Thanks,

Jihun Kang