Re: Review Request 36708: Added HEARTBEAT event to the scheduler API.

2015-07-23 Thread Anand Mazumdar 


> On July 23, 2015, 6:24 p.m., Ben Mahler wrote:
> > include/mesos/scheduler/scheduler.proto, lines 46-52
> > 
> >
> > "does not receive heartbeats, or any other events, for an extended"?
> > 
> > Just thinking that we don't care about heartbeats when there are lots 
> > of events flowing (and this may skew the scheduler's perception of time 
> > between heartbeats).

Wondering if we should also mention about the usage of a backoff strategy here ?

Something like:

s/resubscribe./resubscribe using a suitable backoff strategy. ?


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36708/#review92784
---


On July 23, 2015, 12:23 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36708/
> ---
> 
> (Updated July 23, 2015, 12:23 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.
> 
> 
> Bugs: MESOS-3131
> https://issues.apache.org/jira/browse/MESOS-3131
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is to deal with network partition and also making sure that network 
> intermediaries do not close the persistent connection between scheduler and 
> master.
> 
> Will add the code in the master once it can speak HTTP.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> e2ca8e5cfb3d6405bf7be93d621743ce48c6c7e6 
> 
> Diff: https://reviews.apache.org/r/36708/diff/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 36708: Added HEARTBEAT event to the scheduler API.

2015-07-23 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36708/#review92784
---

Ship it!



include/mesos/scheduler/scheduler.proto (lines 46 - 52)


"does not receive heartbeats, or any other events, for an extended"?

Just thinking that we don't care about heartbeats when there are lots of 
events flowing (and this may skew the scheduler's perception of time between 
heartbeats).


- Ben Mahler


On July 23, 2015, 12:23 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36708/
> ---
> 
> (Updated July 23, 2015, 12:23 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.
> 
> 
> Bugs: MESOS-3131
> https://issues.apache.org/jira/browse/MESOS-3131
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is to deal with network partition and also making sure that network 
> intermediaries do not close the persistent connection between scheduler and 
> master.
> 
> Will add the code in the master once it can speak HTTP.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> e2ca8e5cfb3d6405bf7be93d621743ce48c6c7e6 
> 
> Diff: https://reviews.apache.org/r/36708/diff/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 36708: Added HEARTBEAT event to the scheduler API.

2015-07-22 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36708/#review92687
---


Patch looks great!

Reviews applied: [36698, 36708]

All tests passed.

- Mesos ReviewBot


On July 23, 2015, 12:23 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36708/
> ---
> 
> (Updated July 23, 2015, 12:23 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.
> 
> 
> Bugs: MESOS-3131
> https://issues.apache.org/jira/browse/MESOS-3131
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is to deal with network partition and also making sure that network 
> intermediaries do not close the persistent connection between scheduler and 
> master.
> 
> Will add the code in the master once it can speak HTTP.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> e2ca8e5cfb3d6405bf7be93d621743ce48c6c7e6 
> 
> Diff: https://reviews.apache.org/r/36708/diff/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 36708: Added HEARTBEAT event to the scheduler API.

2015-07-22 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36708/
---

(Updated July 23, 2015, 12:23 a.m.)


Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.


Changes
---

added "heartbeat_interval_seconds" to SUBSCRIBED.


Bugs: MESOS-3131
https://issues.apache.org/jira/browse/MESOS-3131


Repository: mesos


Description
---

This is to deal with network partition and also making sure that network 
intermediaries do not close the persistent connection between scheduler and 
master.

Will add the code in the master once it can speak HTTP.


Diffs (updated)
-

  include/mesos/scheduler/scheduler.proto 
e2ca8e5cfb3d6405bf7be93d621743ce48c6c7e6 

Diff: https://reviews.apache.org/r/36708/diff/


Testing
---

None.


Thanks,

Vinod Kone

Re: Review Request 36708: Added HEARTBEAT event to the scheduler API.

2015-07-22 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36708/#review92663
---



include/mesos/scheduler/scheduler.proto (lines 46 - 53)


Hm.. how does the scheduler know the period if we make it configurable on 
the master?

Should SUBSCRIBED include a 'heartbeat_interval', or?


- Ben Mahler


On July 22, 2015, 10:14 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36708/
> ---
> 
> (Updated July 22, 2015, 10:14 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.
> 
> 
> Bugs: MESOS-3131
> https://issues.apache.org/jira/browse/MESOS-3131
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is to deal with network partition and also making sure that network 
> intermediaries do not close the persistent connection between scheduler and 
> master.
> 
> Will add the code in the master once it can speak HTTP.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> e2ca8e5cfb3d6405bf7be93d621743ce48c6c7e6 
> 
> Diff: https://reviews.apache.org/r/36708/diff/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Review Request 36708: Added HEARTBEAT event to the scheduler API.

2015-07-22 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36708/
---

Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.


Bugs: MESOS-3131
https://issues.apache.org/jira/browse/MESOS-3131


Repository: mesos


Description
---

This is to deal with network partition and also making sure that network 
intermediaries do not close the persistent connection between scheduler and 
master.

Will add the code in the master once it can speak HTTP.


Diffs
-

  include/mesos/scheduler/scheduler.proto 
e2ca8e5cfb3d6405bf7be93d621743ce48c6c7e6 

Diff: https://reviews.apache.org/r/36708/diff/


Testing
---

None.


Thanks,

Vinod Kone