Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-10-02 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review101316
---

Ship it!


Ship It!

- Alexander Rukletsov


On Sept. 2, 2015, 1:38 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> ---
> 
> (Updated Sept. 2, 2015, 1:38 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3164
> https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> ---
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-09-08 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review97972
---

Ship it!


Ship It!

- Qian Zhang


On Sept. 2, 2015, 9:38 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> ---
> 
> (Updated Sept. 2, 2015, 9:38 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3164
> https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> ---
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-09-02 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/
---

(Updated Sept. 2, 2015, 1:38 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
Toenshoff.


Changes
---

Rebased and minor rename.


Bugs: MESOS-3164
https://issues.apache.org/jira/browse/MESOS-3164


Repository: mesos


Description
---

Added QuotaInfo Protobuf.


Diffs (updated)
-

  include/mesos/master/quota.hpp PRE-CREATION 
  include/mesos/master/quota.proto PRE-CREATION 
  src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5 

Diff: https://reviews.apache.org/r/36908/diff/


Testing
---

make distcheck


Thanks,

Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-09-02 Thread Joerg Schad 


> On Aug. 24, 2015, 9:12 p.m., Alexander Rukletsov wrote:
> > include/mesos/master/quota.proto, line 19
> > 
> >
> > I think we should version this protobuf.

As so far only mesos and scheduler are versioned, we don't do this right now 
(as discussed).


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96213
---


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> ---
> 
> (Updated Aug. 5, 2015, 2:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3164
> https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> ---
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-28 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96906
---



include/mesos/master/quota.proto (line 38)
https://reviews.apache.org/r/36908/#comment152591

s/guarantees/guarantee


- Alexander Rukletsov


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36908/
 ---
 
 (Updated Aug. 5, 2015, 2:03 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
 Toenshoff.
 
 
 Bugs: MESOS-3164
 https://issues.apache.org/jira/browse/MESOS-3164
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added QuotaInfo Protobuf.
 
 
 Diffs
 -
 
   include/mesos/master/quota.hpp PRE-CREATION 
   include/mesos/master/quota.proto PRE-CREATION 
   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
 
 Diff: https://reviews.apache.org/r/36908/diff/
 
 
 Testing
 ---
 
 make distcheck
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-25 Thread Alexander Rukletsov 


 On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote:
  src/Makefile.am, line 182
  https://reviews.apache.org/r/36908/diff/4/?file=1032680#file1032680line182
 
  It is better consider the alpha order of those files, we can add quota 
  related files under module related files.
 
 Alexander Rukletsov wrote:
 Could you please elaborate? I'm not sure I follow.
 
 Guangya Liu wrote:
 I mean the file order in Makefile.am should follow alpha order as other 
 part in this file.
 
 My propose is that you only need to re-order the file list here as 
 following:
 
 module/module.pb.cc \
   ../include/mesos/module/module.pb.h   \
 master/quota.pb.cc  \
   ../include/mesos/master/quota.pb.h\
 
 Just adjust the order should works.

I see. We also include folder into lexicographic sorting, therefore `module  
master` and hence all `master/**` go before `module/**`. Does it make sense?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96299
---


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36908/
 ---
 
 (Updated Aug. 5, 2015, 2:03 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
 Toenshoff.
 
 
 Bugs: MESOS-3164
 https://issues.apache.org/jira/browse/MESOS-3164
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added QuotaInfo Protobuf.
 
 
 Diffs
 -
 
   include/mesos/master/quota.hpp PRE-CREATION 
   include/mesos/master/quota.proto PRE-CREATION 
   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
 
 Diff: https://reviews.apache.org/r/36908/diff/
 
 
 Testing
 ---
 
 make distcheck
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-25 Thread Alexander Rukletsov 


 On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote:
  include/mesos/master/quota.proto, line 19
  https://reviews.apache.org/r/36908/diff/4/?file=1032679#file1032679line19
 
  Yes, does v1 API will be supportted for quota?

Adding new protobufs should be backwards-compatible, so I suppose the answer is 
yes.


 On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote:
  src/Makefile.am, line 182
  https://reviews.apache.org/r/36908/diff/4/?file=1032680#file1032680line182
 
  It is better consider the alpha order of those files, we can add quota 
  related files under module related files.

Could you please elaborate? I'm not sure I follow.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96299
---


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36908/
 ---
 
 (Updated Aug. 5, 2015, 2:03 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
 Toenshoff.
 
 
 Bugs: MESOS-3164
 https://issues.apache.org/jira/browse/MESOS-3164
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added QuotaInfo Protobuf.
 
 
 Diffs
 -
 
   include/mesos/master/quota.hpp PRE-CREATION 
   include/mesos/master/quota.proto PRE-CREATION 
   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
 
 Diff: https://reviews.apache.org/r/36908/diff/
 
 
 Testing
 ---
 
 make distcheck
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-25 Thread Guangya Liu 


 On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote:
  src/Makefile.am, line 182
  https://reviews.apache.org/r/36908/diff/4/?file=1032680#file1032680line182
 
  It is better consider the alpha order of those files, we can add quota 
  related files under module related files.
 
 Alexander Rukletsov wrote:
 Could you please elaborate? I'm not sure I follow.

I mean the file order in Makefile.am should follow alpha order as other part in 
this file.

My propose is that you only need to re-order the file list here as following:

module/module.pb.cc \
  ../include/mesos/module/module.pb.h   \
master/quota.pb.cc  \
  ../include/mesos/master/quota.pb.h\

Just adjust the order should works.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96299
---


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36908/
 ---
 
 (Updated Aug. 5, 2015, 2:03 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
 Toenshoff.
 
 
 Bugs: MESOS-3164
 https://issues.apache.org/jira/browse/MESOS-3164
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added QuotaInfo Protobuf.
 
 
 Diffs
 -
 
   include/mesos/master/quota.hpp PRE-CREATION 
   include/mesos/master/quota.proto PRE-CREATION 
   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
 
 Diff: https://reviews.apache.org/r/36908/diff/
 
 
 Testing
 ---
 
 make distcheck
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-25 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96482
---



src/Makefile.am (line 182)
https://reviews.apache.org/r/36908/#comment151876

I mean the file order in Makefile.am should follow alpha order as other 
part in this file.

My propose is that you only need to re-order the file list here as 
following:

module/module.pb.cc \
  ../include/mesos/module/module.pb.h   
\
master/quota.pb.cc  \
  ../include/mesos/master/quota.pb.h
\
  
Just adjust the order should works.


- Guangya Liu


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36908/
 ---
 
 (Updated Aug. 5, 2015, 2:03 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
 Toenshoff.
 
 
 Bugs: MESOS-3164
 https://issues.apache.org/jira/browse/MESOS-3164
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added QuotaInfo Protobuf.
 
 
 Diffs
 -
 
   include/mesos/master/quota.hpp PRE-CREATION 
   include/mesos/master/quota.proto PRE-CREATION 
   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
 
 Diff: https://reviews.apache.org/r/36908/diff/
 
 
 Testing
 ---
 
 make distcheck
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-24 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96299
---



include/mesos/master/quota.proto (line 19)
https://reviews.apache.org/r/36908/#comment151622

Yes, does v1 API will be supportted for quota?



src/Makefile.am (line 182)
https://reviews.apache.org/r/36908/#comment151621

It is better consider the alpha order of those files, we can add quota 
related files under module related files.


- Guangya Liu


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36908/
 ---
 
 (Updated Aug. 5, 2015, 2:03 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
 Toenshoff.
 
 
 Bugs: MESOS-3164
 https://issues.apache.org/jira/browse/MESOS-3164
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added QuotaInfo Protobuf.
 
 
 Diffs
 -
 
   include/mesos/master/quota.hpp PRE-CREATION 
   include/mesos/master/quota.proto PRE-CREATION 
   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
 
 Diff: https://reviews.apache.org/r/36908/diff/
 
 
 Testing
 ---
 
 make distcheck
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-05 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/
---

(Updated Aug. 5, 2015, 2:03 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
Toenshoff.


Bugs: MESOS-3164
https://issues.apache.org/jira/browse/MESOS-3164


Repository: mesos


Description
---

Added QuotaInfo Protobuf.


Diffs (updated)
-

  include/mesos/master/quota.hpp PRE-CREATION 
  include/mesos/master/quota.proto PRE-CREATION 
  src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 

Diff: https://reviews.apache.org/r/36908/diff/


Testing
---

make distcheck


Thanks,

Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-05 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review94258
---


Patch looks great!

Reviews applied: [36908]

All tests passed.

- Mesos ReviewBot


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36908/
 ---
 
 (Updated Aug. 5, 2015, 2:03 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
 Toenshoff.
 
 
 Bugs: MESOS-3164
 https://issues.apache.org/jira/browse/MESOS-3164
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added QuotaInfo Protobuf.
 
 
 Diffs
 -
 
   include/mesos/master/quota.hpp PRE-CREATION 
   include/mesos/master/quota.proto PRE-CREATION 
   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
 
 Diff: https://reviews.apache.org/r/36908/diff/
 
 
 Testing
 ---
 
 make distcheck
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-04 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review94014
---


Patch looks great!

Reviews applied: [36908]

All tests passed.

- Mesos ReviewBot


On Aug. 3, 2015, 7:01 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36908/
 ---
 
 (Updated Aug. 3, 2015, 7:01 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
 Toenshoff.
 
 
 Bugs: MESOS-3164
 https://issues.apache.org/jira/browse/MESOS-3164
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added QuotaInfo Protobuf.
 
 
 Diffs
 -
 
   include/mesos/master/quota.hpp PRE-CREATION 
   include/mesos/master/quota.proto PRE-CREATION 
   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
 
 Diff: https://reviews.apache.org/r/36908/diff/
 
 
 Testing
 ---
 
 make distcheck
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-03 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review93909
---

Ship it!


Looks good to me.


src/Makefile.am (lines 182 - 183)
https://reviews.apache.org/r/36908/#comment148342

Shall we order these as well a little?



src/Makefile.am (line 801)
https://reviews.apache.org/r/36908/#comment148338

You really do not want to reorder them, huh? :)



src/Makefile.am (line 818)
https://reviews.apache.org/r/36908/#comment148343

Not yours but it seems we got some spaces in here that we dont need. Hint, 
always have a look at your RRs within RB as well and check for such red bars :)


- Till Toenshoff


On July 29, 2015, 4:59 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36908/
 ---
 
 (Updated July 29, 2015, 4:59 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
 Toenshoff.
 
 
 Bugs: MESOS-3164
 https://issues.apache.org/jira/browse/MESOS-3164
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added QuotaInfo Protobuf.
 
 
 Diffs
 -
 
   include/mesos/master/quota.hpp PRE-CREATION 
   include/mesos/master/quota.proto PRE-CREATION 
   src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 
 
 Diff: https://reviews.apache.org/r/36908/diff/
 
 
 Testing
 ---
 
 make distcheck
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-03 Thread Till Toenshoff 


 On Aug. 3, 2015, 2:44 p.m., Bernd Mathiske wrote:
  include/mesos/master/quota.proto, line 38
  https://reviews.apache.org/r/36908/diff/2/?file=1024652#file1024652line38
 
  limit, bound - plural

I would suggest to reword:
Add upper bounds limit of resources that ...


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review93908
---


On July 29, 2015, 4:59 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36908/
 ---
 
 (Updated July 29, 2015, 4:59 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
 Toenshoff.
 
 
 Bugs: MESOS-3164
 https://issues.apache.org/jira/browse/MESOS-3164
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added QuotaInfo Protobuf.
 
 
 Diffs
 -
 
   include/mesos/master/quota.hpp PRE-CREATION 
   include/mesos/master/quota.proto PRE-CREATION 
   src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 
 
 Diff: https://reviews.apache.org/r/36908/diff/
 
 
 Testing
 ---
 
 make distcheck
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-03 Thread Bernd Mathiske 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review93908
---



include/mesos/master/quota.proto (line 25)
https://reviews.apache.org/r/36908/#comment148337

If the guaranteed resource allocation is ALL that QuotaInfo describes, we 
should rename it. However, reading on, it seems to me that we want QuotaInfo to 
describe both the minimum AND the limit in the long run. So this should be 
pointed out right here. The TODO further below comes a bit too late IMHO.



include/mesos/master/quota.proto (line 34)
https://reviews.apache.org/r/36908/#comment148339

s/should/must
s/Resource.role/guaranteed.role
s/QuotaInfo.role/the above role



include/mesos/master/quota.proto (line 36)
https://reviews.apache.org/r/36908/#comment148340

s/guaranteed/guarantees



include/mesos/master/quota.proto (line 38)
https://reviews.apache.org/r/36908/#comment148341

limit, bound - plural


- Bernd Mathiske


On July 29, 2015, 9:59 a.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36908/
 ---
 
 (Updated July 29, 2015, 9:59 a.m.)
 
 
 Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
 Toenshoff.
 
 
 Bugs: MESOS-3164
 https://issues.apache.org/jira/browse/MESOS-3164
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added QuotaInfo Protobuf.
 
 
 Diffs
 -
 
   include/mesos/master/quota.hpp PRE-CREATION 
   include/mesos/master/quota.proto PRE-CREATION 
   src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 
 
 Diff: https://reviews.apache.org/r/36908/diff/
 
 
 Testing
 ---
 
 make distcheck
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-03 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/
---

(Updated Aug. 3, 2015, 7:01 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
Toenshoff.


Bugs: MESOS-3164
https://issues.apache.org/jira/browse/MESOS-3164


Repository: mesos


Description
---

Added QuotaInfo Protobuf.


Diffs (updated)
-

  include/mesos/master/quota.hpp PRE-CREATION 
  include/mesos/master/quota.proto PRE-CREATION 
  src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 

Diff: https://reviews.apache.org/r/36908/diff/


Testing
---

make distcheck


Thanks,

Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-07-29 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/
---

(Updated July 29, 2015, 4:59 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
Toenshoff.


Bugs: MESOS-3164
https://issues.apache.org/jira/browse/MESOS-3164


Repository: mesos


Description
---

Added QuotaInfo Protobuf.


Diffs (updated)
-

  include/mesos/master/quota.hpp PRE-CREATION 
  include/mesos/master/quota.proto PRE-CREATION 
  src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 

Diff: https://reviews.apache.org/r/36908/diff/


Testing
---

make distcheck


Thanks,

Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-07-29 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review93496
---


Patch looks great!

Reviews applied: [36908]

All tests passed.

- Mesos ReviewBot


On July 29, 2015, 4:59 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36908/
 ---
 
 (Updated July 29, 2015, 4:59 p.m.)
 
 
 Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
 Toenshoff.
 
 
 Bugs: MESOS-3164
 https://issues.apache.org/jira/browse/MESOS-3164
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added QuotaInfo Protobuf.
 
 
 Diffs
 -
 
   include/mesos/master/quota.hpp PRE-CREATION 
   include/mesos/master/quota.proto PRE-CREATION 
   src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 
 
 Diff: https://reviews.apache.org/r/36908/diff/
 
 
 Testing
 ---
 
 make distcheck
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-07-29 Thread Joerg Schad 


 On July 29, 2015, 12:21 p.m., Till Toenshoff wrote:
  src/Makefile.am, line 261
  https://reviews.apache.org/r/36908/diff/1/?file=1024447#file1024447line261
 
  This line looks too long.
 
 Till Toenshoff wrote:
 Seems we actually tolerate this - feel free to drop this issue.

I was wondering as well but it is consistent with the sourrounding code, so i 
would drop this.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review93432
---


On July 29, 2015, 11:54 a.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36908/
 ---
 
 (Updated July 29, 2015, 11:54 a.m.)
 
 
 Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
 Toenshoff.
 
 
 Bugs: MESOS-3164
 https://issues.apache.org/jira/browse/MESOS-3164
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added QuotaInfo Protobuf.
 
 
 Diffs
 -
 
   include/mesos/master/quota.hpp PRE-CREATION 
   include/mesos/master/quota.proto PRE-CREATION 
   src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 
 
 Diff: https://reviews.apache.org/r/36908/diff/
 
 
 Testing
 ---
 
 make distcheck
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-07-29 Thread Till Toenshoff 


 On July 29, 2015, 12:21 p.m., Till Toenshoff wrote:
  src/Makefile.am, line 261
  https://reviews.apache.org/r/36908/diff/1/?file=1024447#file1024447line261
 
  This line looks too long.

Seems we actually tolerate this - feel free to drop this issue.


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review93432
---


On July 29, 2015, 11:54 a.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36908/
 ---
 
 (Updated July 29, 2015, 11:54 a.m.)
 
 
 Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
 Toenshoff.
 
 
 Bugs: MESOS-3164
 https://issues.apache.org/jira/browse/MESOS-3164
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added QuotaInfo Protobuf.
 
 
 Diffs
 -
 
   include/mesos/master/quota.hpp PRE-CREATION 
   include/mesos/master/quota.proto PRE-CREATION 
   src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 
 
 Diff: https://reviews.apache.org/r/36908/diff/
 
 
 Testing
 ---
 
 make distcheck
 
 
 Thanks,
 
 Joerg Schad

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-07-29 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review93445
---



include/mesos/master/quota.hpp (lines 19 - 20)
https://reviews.apache.org/r/36908/#comment147819

I know we are utterly inconsistent here, but my suggestion would be 
`__MESOS_MASTER_QUOTA_PROTO_HPP__`



include/mesos/master/quota.proto (line 26)
https://reviews.apache.org/r/36908/#comment147818

Let's add a comment here. Something like:
```
To stay in tune with the dynamic reservation mechanism and be able to 
leverage role weights, quota is reserved per role and not per framework. This 
behaviour may change in the future, and if so then most likely in coordination 
with dynamic reservations.
```



include/mesos/master/quota.proto (lines 37 - 40)
https://reviews.apache.org/r/36908/#comment147816

I think we should remove it for now, since we do not plan to implement it 
right now, but let's leave a TODO so that folks understand that quota != limit/



include/mesos/master/quota.proto (lines 44 - 49)
https://reviews.apache.org/r/36908/#comment147815

Let's remove it for now, it's not part of the MVP.



src/Makefile.am (lines 154 - 155)
https://reviews.apache.org/r/36908/#comment147824

Hard tabs here and everywhere else, please!



src/Makefile.am (line 261)
https://reviews.apache.org/r/36908/#comment147822

Can we do something like `master/%.pb.cc ../include/mesos/master/%.pb.h: 
$(ALLOCATOR_PROTO) $(QUOTA_PROTO)` for clarity?



src/Makefile.am (lines 482 - 484)
https://reviews.apache.org/r/36908/#comment147823

Hard tabs here as well, please.


- Alexander Rukletsov


On July 29, 2015, 11:54 a.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36908/
 ---
 
 (Updated July 29, 2015, 11:54 a.m.)
 
 
 Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
 Toenshoff.
 
 
 Bugs: MESOS-3164
 https://issues.apache.org/jira/browse/MESOS-3164
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added QuotaInfo Protobuf.
 
 
 Diffs
 -
 
   include/mesos/master/quota.hpp PRE-CREATION 
   include/mesos/master/quota.proto PRE-CREATION 
   src/Makefile.am 0794969b4b147e0f837006f2f2eba6c6b28eb332 
 
 Diff: https://reviews.apache.org/r/36908/diff/
 
 
 Testing
 ---
 
 make distcheck
 
 
 Thanks,
 
 Joerg Schad