Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

2015-07-30 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/
---

Review request for mesos, Bernd Mathiske and Klaus Ma.


Bugs: MESOS-3023
https://issues.apache.org/jira/browse/MESOS-3023


Repository: mesos


Description
---

Factored out the pattern for URL generation in (another)fetcher test.


Diffs
-

  src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 

Diff: https://reviews.apache.org/r/36946/diff/


Testing
---

GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check


Thanks,

Artem Harutyunyan

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

2015-07-30 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/#review93605
---



src/tests/fetcher_tests.cpp (line 332)


```
// Tests whether fetcher can process URIs that contain leading whitespace
```
Does this patch broke this?


- haosdent huang


On July 30, 2015, 4:37 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36946/
> ---
> 
> (Updated July 30, 2015, 4:37 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Klaus Ma.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Factored out the pattern for URL generation in (another)fetcher test.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 
> 
> Diff: https://reviews.apache.org/r/36946/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

2015-07-30 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/#review93607
---


Patch looks great!

Reviews applied: [36946]

All tests passed.

- Mesos ReviewBot


On July 30, 2015, 4:37 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36946/
> ---
> 
> (Updated July 30, 2015, 4:37 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Klaus Ma.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Factored out the pattern for URL generation in (another)fetcher test.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 
> 
> Diff: https://reviews.apache.org/r/36946/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

2015-07-30 Thread Klaus Ma 


> On July 30, 2015, 5:14 p.m., haosdent huang wrote:
> > src/tests/fetcher_tests.cpp, line 332
> > 
> >
> > ```
> > // Tests whether fetcher can process URIs that contain leading 
> > whitespace
> > ```
> > Does this patch broke this?

Nop, it did NOT include the UT for that case ("Tests whether fetcher can 
process URIs that contain leading whitespace").


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/#review93605
---


On July 30, 2015, 4:37 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36946/
> ---
> 
> (Updated July 30, 2015, 4:37 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Klaus Ma.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Factored out the pattern for URL generation in (another)fetcher test.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 
> 
> Diff: https://reviews.apache.org/r/36946/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

2015-07-31 Thread Bernd Mathiske 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/#review93704
---



src/tests/fetcher_tests.cpp (line 343)


This change seems to eliminate the essence of the test, namely the leading 
white space.


- Bernd Mathiske


On July 30, 2015, 9:37 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36946/
> ---
> 
> (Updated July 30, 2015, 9:37 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Klaus Ma.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Factored out the pattern for URL generation in (another)fetcher test.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 
> 
> Diff: https://reviews.apache.org/r/36946/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

2015-07-31 Thread Klaus Ma 


> On July 31, 2015, 7:39 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_tests.cpp, line 343
> > 
> >
> > This change seems to eliminate the essence of the test, namely the 
> > leading white space.

There are two UT cases here:

- FetcherTest-OSNetUriTest
- FetcherTest-OSNetUriSpaceTest

This fix only handle #1, which did not handle leading white space :)


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/#review93704
---


On July 30, 2015, 4:37 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36946/
> ---
> 
> (Updated July 30, 2015, 4:37 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Klaus Ma.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Factored out the pattern for URL generation in (another)fetcher test.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 
> 
> Diff: https://reviews.apache.org/r/36946/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

2015-07-31 Thread Artem Harutyunyan 


> On July 31, 2015, 12:39 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_tests.cpp, line 343
> > 
> >
> > This change seems to eliminate the essence of the test, namely the 
> > leading white space.
> 
> Klaus Ma wrote:
> There are two UT cases here:
> 
> - FetcherTest-OSNetUriTest
> - FetcherTest-OSNetUriSpaceTest
> 
> This fix only handle #1, which did not handle leading white space :)

You're right :facepalm:. Should be fixed now.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/#review93704
---


On July 31, 2015, 8:23 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36946/
> ---
> 
> (Updated July 31, 2015, 8:23 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Klaus Ma.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Factored out the pattern for URL generation in (another)fetcher test.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 
> 
> Diff: https://reviews.apache.org/r/36946/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

2015-07-31 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/
---

(Updated July 31, 2015, 8:23 a.m.)


Review request for mesos, Bernd Mathiske and Klaus Ma.


Changes
---

Actually add whitespace to URL.


Bugs: MESOS-3023
https://issues.apache.org/jira/browse/MESOS-3023


Repository: mesos


Description
---

Factored out the pattern for URL generation in (another)fetcher test.


Diffs (updated)
-

  src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 

Diff: https://reviews.apache.org/r/36946/diff/


Testing
---

GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check


Thanks,

Artem Harutyunyan

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

2015-07-31 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/#review93728
---

Ship it!


Ship It!

- haosdent huang


On July 31, 2015, 3:23 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36946/
> ---
> 
> (Updated July 31, 2015, 3:23 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Klaus Ma.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Factored out the pattern for URL generation in (another)fetcher test.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 
> 
> Diff: https://reviews.apache.org/r/36946/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

2015-07-31 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/#review93733
---


Patch looks great!

Reviews applied: [36946]

All tests passed.

- Mesos ReviewBot


On July 31, 2015, 3:23 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36946/
> ---
> 
> (Updated July 31, 2015, 3:23 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Klaus Ma.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Factored out the pattern for URL generation in (another)fetcher test.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 
> 
> Diff: https://reviews.apache.org/r/36946/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

2015-08-03 Thread Bernd Mathiske 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/#review93878
---

Ship it!


Ship It!

- Bernd Mathiske


On July 31, 2015, 8:23 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36946/
> ---
> 
> (Updated July 31, 2015, 8:23 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Klaus Ma.
> 
> 
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Factored out the pattern for URL generation in (another)fetcher test.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_tests.cpp 3ded3c037bdfe7095aa15503d81a8d2ee9d420df 
> 
> Diff: https://reviews.apache.org/r/36946/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER='FetcherTest.OSNetUriSpaceTest' make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>